Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-09 00:53:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix packaging when cross compiling (#33454)

Browse source 
We need to check the compilation target,
not the host platform.

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This commit is contained in:
Jonathan Schwender 2024-09-14 10:42:03 +02:00 • committed by GitHub
parent ed6b1b5e6a
commit f8ca5c3194
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
python/servo/package_commands.py
View file

@ -36,7 +36,6 @@ from servo.command_base import (
BuildNotFound,
cd,
CommandBase,
is_macosx,
is_windows,
)
from servo.util import delete, get_target_dir
@ -179,7 +178,7 @@ class PackageCommands(CommandBase):
except subprocess.CalledProcessError as e:
print("Packaging Android exited with return value %d" % e.returncode)
return e.returncode
elif is_macosx():
elif 'darwin' in self.target.triple():
print("Creating Servo.app")
dir_to_dmg = path.join(target_dir, 'dmg')
dir_to_app = path.join(dir_to_dmg, 'Servo.app')
@ -248,7 +247,7 @@ class PackageCommands(CommandBase):
delete(dir_to_dmg)
print("Packaged Servo into " + dmg_path)
elif is_windows():
elif 'windows' in self.target.triple():
dir_to_msi = path.join(target_dir, 'msi')
if path.exists(dir_to_msi):
print("Cleaning up from previous packaging")