Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 00:25:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add spec comment on handle_will_send_keys

Browse source 
Signed-off-by: PotatoCP <kenzieradityatirtarahardja18@gmail.com>
This commit is contained in:
PotatoCP 2025-06-03 17:49:01 +08:00
parent b0fba0f110
commit f90c80fbf5
1 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
components/script/webdriver_handlers.rs
View file

@ -846,10 +846,13 @@ pub(crate) fn handle_will_send_keys(
reply
.send(
find_node_by_unique_id(documents, pipeline, element_id).and_then(|node| {
// Step 6: Let file be true if element is input element
// in the file upload state, or false otherwise
let file_input = node
.downcast::<HTMLInputElement>()
.filter(|&input_element| input_element.input_type() == InputType::File);
// Step 7: If file is false or the session's strict file interactability
if file_input.is_none() || strict_file_interactability {
match node.downcast::<HTMLElement>() {
Some(element) => {
@ -860,20 +863,35 @@ pub(crate) fn handle_will_send_keys(
}
}
// Step 8 (file input)
if let Some(file_input) = file_input {
// Step 8.1: Let files be the result of splitting text
// on the newline (\n) character.
let files: Vec<DOMString> = text.split("\n").map(|s| s.into()).collect();
// Step 8.2
if files.is_empty() {
return Err(ErrorStatus::InvalidArgument);
}
// Step 8.3 - 8.4
if !file_input.Multiple() && files.len() > 1 {
return Err(ErrorStatus::InvalidArgument);
}
// Step 8.5
// TODO: Should return invalid argument error if file doesn't exist
// Step 8.6 - 8.7
// Input and change event already fired in `htmlinputelement.rs`.
file_input.SelectFiles(files, can_gc);
// Step 8.8
return Ok(false);
}
// TODO: Check non-typeable form control
// TODO: Check content editable
Ok(true)
}),