mirror of
https://github.com/servo/servo.git
synced 2025-08-06 06:00:15 +01:00
Auto merge of #15029 - aneeshusa:check-whole-constellation-for-panics, r=asajeffrey
Check all constellation files for panics Teaches the `etc/ci/check_no_panic.sh` script to handle directories, so it can check all constellation files for panics. <!-- Please describe your changes on the following line: --> r? @asajeffrey There are currently 4 `unwrap()`s in `components/constellation/timer_scheduler.rs`; I'm not sure how you want to handle those. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14976 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it adds more testing coverage <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15029) <!-- Reviewable:end -->
This commit is contained in:
commit
f9505c7faf
2 changed files with 21 additions and 14 deletions
|
@ -39,7 +39,7 @@ impl PartialEq for ScheduledEvent {
|
|||
|
||||
impl TimerScheduler {
|
||||
pub fn start() -> IpcSender<TimerEventRequest> {
|
||||
let (req_ipc_sender, req_ipc_receiver) = ipc::channel().unwrap();
|
||||
let (req_ipc_sender, req_ipc_receiver) = ipc::channel().expect("Channel creation failed.");
|
||||
let (req_sender, req_receiver) = mpsc::sync_channel(1);
|
||||
|
||||
// We could do this much more directly with recv_timeout
|
||||
|
@ -92,7 +92,7 @@ impl TimerScheduler {
|
|||
// This thread can terminate if the req_ipc_sender is dropped.
|
||||
warn!("TimerScheduler thread terminated.");
|
||||
})
|
||||
.unwrap()
|
||||
.expect("Thread creation failed.")
|
||||
.thread()
|
||||
.clone();
|
||||
|
||||
|
@ -105,13 +105,13 @@ impl TimerScheduler {
|
|||
.name(String::from("TimerProxy"))
|
||||
.spawn(move || {
|
||||
while let Ok(req) = req_ipc_receiver.recv() {
|
||||
req_sender.send(req).unwrap();
|
||||
let _ = req_sender.send(req);
|
||||
timeout_thread.unpark();
|
||||
}
|
||||
// This thread can terminate if the req_ipc_sender is dropped.
|
||||
warn!("TimerProxy thread terminated.");
|
||||
})
|
||||
.unwrap();
|
||||
.expect("Thread creation failed.");
|
||||
|
||||
// Return the IPC sender
|
||||
req_ipc_sender
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue