Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-24 09:04:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add check for non-Text children for document.title.(fixes #1742)

Browse source
This commit is contained in:
lpy 2014-02-27 14:40:35 +08:00
parent 7ff35c0abe
commit f9f82ff4e6
2 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/script/dom/document.rs
View file

@ -288,8 +288,10 @@ impl Document {
.find(|node| node.type_id() == ElementNodeTypeId(HTMLTitleElementTypeId)) .find(|node| node.type_id() == ElementNodeTypeId(HTMLTitleElementTypeId))
.map(|title_elem| { .map(|title_elem| {
for child in title_elem.children() { for child in title_elem.children() {
let text: JS<Text> = TextCast::to(&child); if child.is_text() {
title.push_str(text.get().characterdata.data.as_slice()); let text: JS<Text> = TextCast::to(&child);
title.push_str(text.get().characterdata.data.as_slice());
}
} }
}); });
}); });

9
src/test/html/content/test_document_title_nontextchildren.html Normal file
View file

@ -0,0 +1,9 @@
<html>
<title>x</title>
<script src="harness.js"></script>
<script>
document.head.firstChild.appendChild(document.createElement("foo"));
is(document.title, "x");
finish();
</script>
</html>