Use boxed slice instead of vec for FuntionTimerCallback

This commit is contained in:
Sadman Kazi 2017-07-11 13:48:52 -07:00
parent eec51cdd57
commit fa678992ff
2 changed files with 10 additions and 2 deletions

View file

@ -177,6 +177,14 @@ unsafe impl<T: JSTraceable + ?Sized> JSTraceable for Box<T> {
} }
} }
unsafe impl<T: JSTraceable> JSTraceable for [T] {
unsafe fn trace(&self, trc: *mut JSTracer) {
for e in self.iter() {
e.trace(trc);
}
}
}
unsafe impl<T: JSTraceable + Copy> JSTraceable for Cell<T> { unsafe impl<T: JSTraceable + Copy> JSTraceable for Cell<T> {
unsafe fn trace(&self, trc: *mut JSTracer) { unsafe fn trace(&self, trc: *mut JSTracer) {
self.get().trace(trc) self.get().trace(trc)

View file

@ -350,7 +350,7 @@ pub enum TimerCallback {
#[derive(JSTraceable, Clone)] #[derive(JSTraceable, Clone)]
enum InternalTimerCallback { enum InternalTimerCallback {
StringTimerCallback(DOMString), StringTimerCallback(DOMString),
FunctionTimerCallback(Rc<Function>, Rc<Vec<Heap<JSVal>>>), FunctionTimerCallback(Rc<Function>, Rc<Box<[Heap<JSVal>]>>),
} }
impl HeapSizeOf for InternalTimerCallback { impl HeapSizeOf for InternalTimerCallback {
@ -392,7 +392,7 @@ impl JsTimers {
for (i, item) in arguments.iter().enumerate() { for (i, item) in arguments.iter().enumerate() {
args.get_mut(i).unwrap().set(item.get()); args.get_mut(i).unwrap().set(item.get());
} }
InternalTimerCallback::FunctionTimerCallback(function, Rc::new(args)) InternalTimerCallback::FunctionTimerCallback(function, Rc::new(args.into_boxed_slice()))
} }
}; };