From fa93d820413224fffe759999ade98897846a202e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Tue, 23 May 2017 15:49:46 +0200 Subject: [PATCH] style: Reject non-positive resolution values in media queries. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1366961 See: https://github.com/w3c/csswg-drafts/issues/1454 --- components/style/gecko/media_queries.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/components/style/gecko/media_queries.rs b/components/style/gecko/media_queries.rs index 2444338f174..ff08fcc0813 100644 --- a/components/style/gecko/media_queries.rs +++ b/components/style/gecko/media_queries.rs @@ -181,6 +181,10 @@ impl Resolution { _ => return Err(()), }; + if value <= 0. { + return Err(()) + } + Ok(match_ignore_ascii_case! { &unit, "dpi" => Resolution::Dpi(value), "dppx" => Resolution::Dppx(value),