Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #16795 - mrobinson:out-of-viewport-transform, r=glennw

Browse source 
Don't optimize display list for projective transforms

There are situations where elements are transformed from outside the
display list. With projective transforms it's currently difficult to
detect these. In those cases we just don't optimize the display list,
so that they will always be shown.

Fixes #13822.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13822 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16795)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2017-05-16 21:27:47 -05:00 • committed by GitHub
commit fada0eb660
4 changed files with 81 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/layout/display_list_builder.rs
View file

@ -2236,6 +2236,14 @@ impl BlockFlowDisplayListBuilding for BlockFlow {
}
match transform {
Some(transform) if transform.m13 != 0.0 || transform.m23 != 0.0 => {
// We cannot properly handle perspective transforms, because there may be a
// situation where an element is transformed from outside the clip into the
// clip region. Here we don't have enough information to detect when that is
// happening. For the moment we just punt on trying to optimize the display
// list for those cases.
max_rect()
}
Some(transform) => {
let clip = Rect::new(Point2D::new((clip.origin.x - origin.x).to_f32_px(),
(clip.origin.y - origin.y).to_f32_px()),

25
tests/wpt/mozilla/meta/MANIFEST.json
View file

@ -5849,6 +5849,18 @@
{}
]
],
"css/transform_3d_from_outside_viewport.html": [
[
"/_mozilla/css/transform_3d_from_outside_viewport.html",
[
[
"/_mozilla/css/transform_3d_from_outside_viewport_ref.html",
"!="
]
],
{}
]
],
"css/transform_optimization.html": [
[
"/_mozilla/css/transform_optimization.html",
@ -9259,6 +9271,11 @@
{}
]
],
"css/transform_3d_from_outside_viewport_ref.html": [
[
{}
]
],
"css/transform_3d_ref.html": [
[
{}
@ -24074,6 +24091,14 @@
"1450d169d4c5506fff240adca5c28b0cb6accd9f",
"reftest"
],
"css/transform_3d_from_outside_viewport.html": [
"b59ccc70dec5de8bf55440ef3d4dd35d2ec1493a",
"reftest"
],
"css/transform_3d_from_outside_viewport_ref.html": [
"87531bec4e8b60f17d885d6236ec0629f68f6c9a",
"support"
],
"css/transform_3d_ref.html": [
"e59866f74ae9dc10a2220c1bb240862371f3edc9",
"support"

33
tests/wpt/mozilla/tests/css/transform_3d_from_outside_viewport.html Normal file
View file

@ -0,0 +1,33 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Ensure that content transformed from outside the viewport is displayed</title>
<link rel="match" href="transform_3d_from_outside_viewport_ref.html">
<style>
#container {
left: 0;
top: 0;
position: absolute;
width: 100%;
height: 100%;
overflow: hidden;
perspective: 2000px;
perspective-origin: 20% 50%;
background: yellow;
}
#transformed {
height: 200px;
transform: translate3d(0px, 0px, -1300px) rotateY(45deg);
background: green;
}
</style>
</head>
<body>
<div id="container">
<div id="transformed"></div>
</div>
</body>
</html>

15
tests/wpt/mozilla/tests/css/transform_3d_from_outside_viewport_ref.html Normal file
View file

@ -0,0 +1,15 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Ensure that content transformed from outside the viewport is displayed</title>
<style>
body {
background: yellow;
}
</style>
</head>
<body>
</body>
</html>