Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #11011 - fabricedesre:friendly-time, r=jdm

Browse source 
Make build time display more human friendly

I mean, I like to convert seconds in my head, only almost every day ;)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11011)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-05-05 03:27:31 -07:00
commit fb5e00c294
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
python/servo/build_commands.py
View file

@ -9,6 +9,7 @@
from __future__ import print_function, unicode_literals from __future__ import print_function, unicode_literals
import datetime
import os import os
import os.path as path import os.path as path
import sys import sys
@ -85,7 +86,7 @@ def notify_build_done(elapsed):
"""Generate desktop notification when build is complete and the """Generate desktop notification when build is complete and the
elapsed build time was longer than 30 seconds.""" elapsed build time was longer than 30 seconds."""
if elapsed > 30: if elapsed > 30:
notify("Servo build", "Completed in %0.2fs" % elapsed) notify("Servo build", "Completed in %s" % str(datetime.timedelta(seconds=elapsed)))
def notify(title, text): def notify(title, text):
@ -240,7 +241,7 @@ class MachCommands(CommandBase):
# Generate Desktop Notification if elapsed-time > some threshold value # Generate Desktop Notification if elapsed-time > some threshold value
notify_build_done(elapsed) notify_build_done(elapsed)
print("Build completed in %0.2fs" % elapsed) print("Build completed in %s" % str(datetime.timedelta(seconds=elapsed)))
return status return status
@Command('build-cef', @Command('build-cef',
@ -276,7 +277,7 @@ class MachCommands(CommandBase):
# Generate Desktop Notification if elapsed-time > some threshold value # Generate Desktop Notification if elapsed-time > some threshold value
notify_build_done(elapsed) notify_build_done(elapsed)
print("CEF build completed in %0.2fs" % elapsed) print("CEF build completed in %s" % str(datetime.timedelta(seconds=elapsed)))
return ret return ret
@ -313,7 +314,7 @@ class MachCommands(CommandBase):
# Generate Desktop Notification if elapsed-time > some threshold value # Generate Desktop Notification if elapsed-time > some threshold value
notify_build_done(elapsed) notify_build_done(elapsed)
print("GeckoLib build completed in %0.2fs" % elapsed) print("GeckoLib build completed in %s" % str(datetime.timedelta(seconds=elapsed)))
return ret return ret
@ -351,7 +352,7 @@ class MachCommands(CommandBase):
# Generate Desktop Notification if elapsed-time > some threshold value # Generate Desktop Notification if elapsed-time > some threshold value
notify_build_done(elapsed) notify_build_done(elapsed)
print("Gonk build completed in %0.2fs" % elapsed) print("Gonk build completed in %s" % str(datetime.timedelta(seconds=elapsed)))
return ret return ret