Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Cookie header values can be utf8

Browse source
This commit is contained in:
Patrick Shaughnessy 2020-01-28 12:47:18 -05:00
parent 2b3c4eba2d
commit fc13bd8b2f
3 changed files with 2 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/net/http_loader.rs
View file

@ -272,7 +272,7 @@ fn set_cookies_from_headers(
cookie_jar: &RwLock<CookieStorage>, cookie_jar: &RwLock<CookieStorage>,
) { ) {
for cookie in headers.get_all(header::SET_COOKIE) { for cookie in headers.get_all(header::SET_COOKIE) {
if let Ok(cookie_str) = cookie.to_str() { if let Ok(cookie_str) = std::str::from_utf8(cookie.as_bytes()) {
set_cookie_for_url(&cookie_jar, &url, &cookie_str); set_cookie_for_url(&cookie_jar, &url, &cookie_str);
} }
} }

2
components/net/websocket_loader.rs
View file

@ -92,7 +92,7 @@ impl<'a> Handler for Client<'a> {
let mut jar = self.http_state.cookie_jar.write().unwrap(); let mut jar = self.http_state.cookie_jar.write().unwrap();
// TODO(eijebong): Replace thise once typed headers settled on a cookie impl // TODO(eijebong): Replace thise once typed headers settled on a cookie impl
for cookie in headers.get_all(header::SET_COOKIE) { for cookie in headers.get_all(header::SET_COOKIE) {
if let Ok(s) = cookie.to_str() { if let Ok(s) = std::str::from_utf8(cookie.as_bytes()) {
if let Some(cookie) = if let Some(cookie) =
Cookie::from_cookie_string(s.into(), self.resource_url, CookieSource::HTTP) Cookie::from_cookie_string(s.into(), self.resource_url, CookieSource::HTTP)
{ {

13
tests/wpt/metadata/cookies/http-state/charset-tests.html.ini
View file

@ -1,13 +0,0 @@
[charset-tests.html]
[charset0002 - charset0002]
expected: FAIL
[charset0003 - charset0003]
expected: FAIL
[charset0004 - charset0004]
expected: FAIL
[charset0001 - charset0001]
expected: FAIL