Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 15:23:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove warnings about unnecessary mutability.

Browse source
This commit is contained in:
Alan Jeffrey 2017-01-27 14:03:18 -06:00
parent ec12b7665b
commit fc67878edf
7 changed files with 9 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/extendablemessageevent.rs
View file

@ -17,7 +17,6 @@ use dom::serviceworkerglobalscope::ServiceWorkerGlobalScope;
use js::jsapi::{HandleValue, Heap, JSContext}; use js::jsapi::{HandleValue, Heap, JSContext};
use js::jsval::JSVal; use js::jsval::JSVal;
use servo_atoms::Atom; use servo_atoms::Atom;
use std::default::Default;
#[dom_struct] #[dom_struct]
pub struct ExtendableMessageEvent { pub struct ExtendableMessageEvent {
@ -32,13 +31,12 @@ impl ExtendableMessageEvent {
bubbles: bool, cancelable: bool, bubbles: bool, cancelable: bool,
data: HandleValue, origin: DOMString, lastEventId: DOMString) data: HandleValue, origin: DOMString, lastEventId: DOMString)
-> Root<ExtendableMessageEvent> { -> Root<ExtendableMessageEvent> {
let mut ev = box ExtendableMessageEvent { let ev = box ExtendableMessageEvent {
event: ExtendableEvent::new_inherited(), event: ExtendableEvent::new_inherited(),
data: Heap::default(), data: Heap::new(data.get()),
origin: origin, origin: origin,
lastEventId: lastEventId, lastEventId: lastEventId,
}; };
ev.data.set(data.get());
let ev = reflect_dom_object(ev, global, ExtendableMessageEventBinding::Wrap); let ev = reflect_dom_object(ev, global, ExtendableMessageEventBinding::Wrap);
{ {
let event = ev.upcast::<Event>(); let event = ev.upcast::<Event>();

2
components/script/dom/imagedata.rs
View file

@ -27,7 +27,7 @@ pub struct ImageData {
impl ImageData { impl ImageData {
#[allow(unsafe_code)] #[allow(unsafe_code)]
pub fn new(global: &GlobalScope, width: u32, height: u32, data: Option<Vec<u8>>) -> Root<ImageData> { pub fn new(global: &GlobalScope, width: u32, height: u32, data: Option<Vec<u8>>) -> Root<ImageData> {
let mut imagedata = box ImageData { let imagedata = box ImageData {
reflector_: Reflector::new(), reflector_: Reflector::new(),
width: width, width: width,
height: height, height: height,

6
components/script/dom/messageevent.rs
View file

@ -16,7 +16,6 @@ use dom::globalscope::GlobalScope;
use js::jsapi::{HandleValue, Heap, JSContext}; use js::jsapi::{HandleValue, Heap, JSContext};
use js::jsval::JSVal; use js::jsval::JSVal;
use servo_atoms::Atom; use servo_atoms::Atom;
use std::default::Default;
#[dom_struct] #[dom_struct]
pub struct MessageEvent { pub struct MessageEvent {
@ -38,13 +37,12 @@ impl MessageEvent {
data: HandleValue, data: HandleValue,
origin: DOMString, origin: DOMString,
lastEventId: DOMString) -> Root<MessageEvent> { lastEventId: DOMString) -> Root<MessageEvent> {
let mut ev = box MessageEvent { let ev = box MessageEvent {
event: Event::new_inherited(), event: Event::new_inherited(),
data: Heap::default(), data: Heap::new(data.get()),
origin: origin, origin: origin,
lastEventId: lastEventId, lastEventId: lastEventId,
}; };
ev.data.set(data.get());
reflect_dom_object(ev, global, MessageEventBinding::Wrap) reflect_dom_object(ev, global, MessageEventBinding::Wrap)
} }

2
components/script/dom/vreyeparameters.rs
View file

@ -31,7 +31,7 @@ impl VREyeParameters {
#[allow(unrooted_must_root)] #[allow(unrooted_must_root)]
fn new_inherited(parameters: WebVREyeParameters, global: &GlobalScope) -> VREyeParameters { fn new_inherited(parameters: WebVREyeParameters, global: &GlobalScope) -> VREyeParameters {
let fov = VRFieldOfView::new(&global, parameters.field_of_view.clone()); let fov = VRFieldOfView::new(&global, parameters.field_of_view.clone());
let mut result = VREyeParameters { let result = VREyeParameters {
reflector_: Reflector::new(), reflector_: Reflector::new(),
parameters: DOMRefCell::new(parameters), parameters: DOMRefCell::new(parameters),
offset: Heap::default(), offset: Heap::default(),

2
components/script/dom/vrframedata.rs
View file

@ -39,7 +39,7 @@ impl VRFrameData {
0.0, 0.0, 0.0, 1.0f32]; 0.0, 0.0, 0.0, 1.0f32];
let pose = VRPose::new(&global, &Default::default()); let pose = VRPose::new(&global, &Default::default());
let mut framedata = VRFrameData { let framedata = VRFrameData {
reflector_: Reflector::new(), reflector_: Reflector::new(),
left_proj: Heap::default(), left_proj: Heap::default(),
left_view: Heap::default(), left_view: Heap::default(),

2
components/script/dom/vrpose.rs
View file

@ -29,7 +29,7 @@ pub struct VRPose {
unsafe fn update_or_create_typed_array(cx: *mut JSContext, unsafe fn update_or_create_typed_array(cx: *mut JSContext,
src: Option<&[f32]>, src: Option<&[f32]>,
dst: &DOMRefCell<Heap<*mut JSObject>>) { dst: &DOMRefCell<Heap<*mut JSObject>>) {
let mut dst = dst.borrow_mut(); let dst = dst.borrow();
match src { match src {
Some(ref data) => { Some(ref data) => {
if dst.get().is_null() { if dst.get().is_null() {

2
components/script/dom/vrstageparameters.rs
View file

@ -28,7 +28,7 @@ impl VRStageParameters {
#[allow(unsafe_code)] #[allow(unsafe_code)]
#[allow(unrooted_must_root)] #[allow(unrooted_must_root)]
fn new_inherited(parameters: WebVRStageParameters, global: &GlobalScope) -> VRStageParameters { fn new_inherited(parameters: WebVRStageParameters, global: &GlobalScope) -> VRStageParameters {
let mut stage = VRStageParameters { let stage = VRStageParameters {
reflector_: Reflector::new(), reflector_: Reflector::new(),
parameters: DOMRefCell::new(parameters), parameters: DOMRefCell::new(parameters),
transform: Heap::default() transform: Heap::default()