Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 15:23:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix insert-adjacent error

Browse source
This commit is contained in:
Guillaume Gomez 2016-06-23 15:06:27 +02:00
parent 0fb5d634a0
commit fc88f81de3
5 changed files with 3 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/element.rs
View file

@ -2069,14 +2069,14 @@ impl ElementMethods for Element {
let context = match context.downcast::<Element>() { let context = match context.downcast::<Element>() {
Some(elem) if elem.local_name() != &atom!("html") || Some(elem) if elem.local_name() != &atom!("html") ||
!elem.html_element_in_html_document() => Root::from_ref(elem), !elem.html_element_in_html_document() => Root::from_ref(elem),
_ => Root::upcast(HTMLBodyElement::new(atom!("body"), None, &*context.owner_doc())) _ => Root::upcast(HTMLBodyElement::new(atom!("body"), None, &*context.owner_doc())),
}; };
// Step 3. // Step 3.
let fragment = try!(context.upcast::<Node>().parse_fragment(text)); let fragment = try!(context.upcast::<Node>().parse_fragment(text));
// Step 4. // Step 4.
context.insert_adjacent(position, fragment.upcast()).map(|_| ()) self.insert_adjacent(position, fragment.upcast()).map(|_| ())
} }
} }

8
tests/wpt/metadata/domparsing/insert-adjacent.html.ini
View file

@ -1,8 +0,0 @@
[insert-adjacent.html]
type: testharness
[insertAdjacentHTML(beforebegin, <h3>beforebegin</h3> )]
expected: FAIL
[insertAdjacentHTML(afterend, <h3>afterend</h3> )]
expected: FAIL

32
tests/wpt/metadata/domparsing/insert_adjacent_html.html.ini
View file

@ -1,32 +0,0 @@
[insert_adjacent_html.html]
type: testharness
[beforeBegin content without next sibling]
expected: FAIL
[afterend content without next sibling]
expected: FAIL
[beforeBegin content again, with next sibling]
expected: FAIL
[afterend content again, with next sibling]
expected: FAIL
[beforeBegin child node not in tree but has parent]
expected: FAIL
[afterend child node not in tree but has parent]
expected: FAIL
[beforeBegin content2 without next sibling]
expected: FAIL
[afterend content2 without next sibling]
expected: FAIL
[beforeBegin content2 test again, now that there's a next sibling]
expected: FAIL
[afterend content2 test again, now that there's a next sibling]
expected: FAIL

30
tests/wpt/metadata/domparsing/insert_adjacent_html.xhtml.ini
View file

@ -1,35 +1,5 @@
[insert_adjacent_html.xhtml] [insert_adjacent_html.xhtml]
type: testharness type: testharness
[beforeBegin content without next sibling]
expected: FAIL
[afterend content without next sibling]
expected: FAIL
[beforeBegin content again, with next sibling]
expected: FAIL
[afterend content again, with next sibling]
expected: FAIL
[beforeBegin child node not in tree but has parent]
expected: FAIL
[afterend child node not in tree but has parent]
expected: FAIL
[beforeBegin content2 without next sibling]
expected: FAIL
[afterend content2 without next sibling]
expected: FAIL
[beforeBegin content2 test again, now that there's a next sibling]
expected: FAIL
[afterend content2 test again, now that there's a next sibling]
expected: FAIL
[insertAdjacentHTML in HTML] [insertAdjacentHTML in HTML]
expected: FAIL expected: FAIL

2
tests/wpt/mozilla/meta/mozilla/sigsegv.html.ini
View file

@ -1,4 +1,4 @@
[sigsegv.html] [sigsegv.html]
type: testharness type: testharness
prefs: [dom.testbinding.enabled:true,dom.testable_crash.enabled:true] prefs: [dom.testbinding.enabled:true, dom.testable_crash.enabled:true]
expected: CRASH expected: CRASH