diff --git a/components/script/dom/eventtarget.rs b/components/script/dom/eventtarget.rs index 12cf7d0253b..ea259a6d2d7 100644 --- a/components/script/dom/eventtarget.rs +++ b/components/script/dom/eventtarget.rs @@ -227,14 +227,13 @@ impl CompiledEventListener { rooted!(in(*cx) let value = value); let value = value.handle(); - //Step 4 - let should_cancel = match event.type_() { - atom!("mouseover") => { - value.is_boolean() && value.to_boolean() == true - }, - _ => value.is_boolean() && value.to_boolean() == false, - }; + //Step 5 + let should_cancel = value.is_boolean() && value.to_boolean() == false; + if should_cancel { + // FIXME: spec says to set the cancelled flag directly + // here, not just to prevent default; + // can that ever make a difference? event.PreventDefault(); } } diff --git a/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-processing-algorithm.html.ini b/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-processing-algorithm.html.ini index 4940ff4ac62..656089c1f0d 100644 --- a/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-processing-algorithm.html.ini +++ b/tests/wpt/metadata/html/webappapis/scripting/events/event-handler-processing-algorithm.html.ini @@ -3,16 +3,3 @@ [beforeunload listener returning null cancels event] bug: https://github.com/servo/servo/issues/10787 expected: FAIL - - [mouseover listener returning false cancels event (using Event)] - expected: FAIL - - [mouseover listener returning false cancels event (using MouseEvent)] - expected: FAIL - - [mouseover listener returning true doesn't cancel event (using Event)] - expected: FAIL - - [mouseover listener returning true doesn't cancel event (using MouseEvent)] - expected: FAIL -