Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement historical returnValue attribute for Event interface

Browse source
This commit is contained in:
Patrick Ngai 2019-02-24 23:58:51 +08:00
parent 427003210b
commit fcadff7bad
6 changed files with 13 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

12
components/script/dom/event.rs
View file

@ -297,6 +297,18 @@ impl EventMethods for Event {
self.cancelable.get() self.cancelable.get()
} }
// https://dom.spec.whatwg.org/#dom-event-returnvalue
fn ReturnValue(&self) -> bool {
self.canceled.get() == EventDefault::Allowed
}
// https://dom.spec.whatwg.org/#dom-event-returnvalue
fn SetReturnValue(&self, val: bool) {
if !val {
self.PreventDefault();
}
}
// https://dom.spec.whatwg.org/#dom-event-timestamp // https://dom.spec.whatwg.org/#dom-event-timestamp
fn TimeStamp(&self) -> u64 { fn TimeStamp(&self) -> u64 {
self.timestamp self.timestamp

1
components/script/dom/webidls/Event.webidl
View file

@ -26,6 +26,7 @@ interface Event {
readonly attribute boolean bubbles; readonly attribute boolean bubbles;
[Pure] [Pure]
readonly attribute boolean cancelable; readonly attribute boolean cancelable;
attribute boolean returnValue; // historical
void preventDefault(); void preventDefault();
[Pure] [Pure]
readonly attribute boolean defaultPrevented; readonly attribute boolean defaultPrevented;

4
tests/wpt/metadata/dom/events/Event-defaultPrevented.html.ini
View file

@ -1,4 +0,0 @@
[Event-defaultPrevented.html]
[returnValue should change defaultPrevented if cancelable is true.]
expected: FAIL

19
tests/wpt/metadata/dom/events/Event-returnValue.html.ini
View file

@ -1,19 +0,0 @@
[Event-returnValue.html]
[When an event is created, returnValue should be initialized to true.]
expected: FAIL
[preventDefault() should not change returnValue if cancelable is false.]
expected: FAIL
[returnValue=false should have no effect if cancelable is false.]
expected: FAIL
[preventDefault() should change returnValue if cancelable is true.]
expected: FAIL
[initEvent should unset returnValue.]
expected: FAIL
[returnValue=true should have no effect once the canceled flag was set.]
expected: FAIL

7
tests/wpt/metadata/dom/events/EventTarget-dispatchEvent-returnvalue.html.ini
View file

@ -1,7 +0,0 @@
[EventTarget-dispatchEvent-returnvalue.html]
[Return value of EventTarget.dispatchEvent() affected by preventDefault().]
expected: FAIL
[Return value of EventTarget.dispatchEvent() affected by returnValue.]
expected: FAIL

12
tests/wpt/metadata/dom/interfaces.html.ini
View file

@ -872,9 +872,6 @@
[Event interface: operation composedPath()] [Event interface: operation composedPath()]
expected: FAIL expected: FAIL
[Event interface: attribute returnValue]
expected: FAIL
[Event interface: attribute composed] [Event interface: attribute composed]
expected: FAIL expected: FAIL
@ -887,9 +884,6 @@
[Event interface: document.createEvent("Event") must inherit property "composedPath()" with the proper type] [Event interface: document.createEvent("Event") must inherit property "composedPath()" with the proper type]
expected: FAIL expected: FAIL
[Event interface: document.createEvent("Event") must inherit property "returnValue" with the proper type]
expected: FAIL
[Event interface: document.createEvent("Event") must inherit property "composed" with the proper type] [Event interface: document.createEvent("Event") must inherit property "composed" with the proper type]
expected: FAIL expected: FAIL
@ -899,9 +893,6 @@
[Event interface: new Event("foo") must inherit property "composedPath()" with the proper type] [Event interface: new Event("foo") must inherit property "composedPath()" with the proper type]
expected: FAIL expected: FAIL
[Event interface: new Event("foo") must inherit property "returnValue" with the proper type]
expected: FAIL
[Event interface: new Event("foo") must inherit property "composed" with the proper type] [Event interface: new Event("foo") must inherit property "composed" with the proper type]
expected: FAIL expected: FAIL
@ -914,9 +905,6 @@
[Event interface: new CustomEvent("foo") must inherit property "composedPath()" with the proper type] [Event interface: new CustomEvent("foo") must inherit property "composedPath()" with the proper type]
expected: FAIL expected: FAIL
[Event interface: new CustomEvent("foo") must inherit property "returnValue" with the proper type]
expected: FAIL
[Event interface: new CustomEvent("foo") must inherit property "composed" with the proper type] [Event interface: new CustomEvent("foo") must inherit property "composed" with the proper type]
expected: FAIL expected: FAIL