Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Better error reporting for missing gstreamer

Browse source
This commit is contained in:
Manish Goregaokar 2018-09-03 14:04:53 +05:30
parent 36797801e9
commit fcc06b5a16
1 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

17
python/servo/command_base.py
View file

@ -478,13 +478,22 @@ class CommandBase(object):
return path.join(bin_folder, "servo{}".format(BIN_SUFFIX)) return path.join(bin_folder, "servo{}".format(BIN_SUFFIX))
def needs_gstreamer_env(self, target): def needs_gstreamer_env(self, target):
if check_gstreamer_lib():
return False
gstpath = path.join(self.context.topdir, "support", "linux", "gstreamer", "gstreamer") gstpath = path.join(self.context.topdir, "support", "linux", "gstreamer", "gstreamer")
if sys.platform == "linux2" and path.isdir(gstpath): if sys.platform == "linux2":
if not check_gstreamer_lib(): if "x86_64" not in (target or host_triple()):
if "x86_64" not in (target or host_triple()): raise Exception("We don't currently support using local gstreamer builds \
raise Exception("We don't currently support using local gstreamer builds \
for non-x86_64, please file a bug") for non-x86_64, please file a bug")
if path.isdir(gstpath):
return True return True
else:
raise Exception("Your system's gstreamer libraries are out of date \
(we need at least 1.12). Please run ./mach bootstrap-gstreamer")
else:
raise Exception("Your system's gstreamer libraries are out of date \
(we need at least 1.12). If you're unable to \
install them, let us know by filing a bug!")
return False return False
def set_run_env(self): def set_run_env(self):