From fd1255932b5d3cb72596bea5eda1129171fec3f6 Mon Sep 17 00:00:00 2001
From: shuppy <dazabani@igalia.com>
Date: Thu, 19 Jun 2025 18:09:50 +1000
Subject: [PATCH] Devtools: make `mach test-devtools` use BuildType (#37548)

`mach test-devtools` was previously hard-coded to using the release
build, which is confusing and different from how the rest of mach works
(e.g. `mach build`, `mach run`). This patch makes `mach test-devtools`
run with the debug build by default, or the other builds with
`--release` or `--profile`.

Testing: this patch directly affects our devtools tests
Fixes: many hours of head scratching

Signed-off-by: Delan Azabani <dazabani@igalia.com>
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
---
 python/servo/devtools_tests.py   | 7 +++++--
 python/servo/testing_commands.py | 5 +++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/python/servo/devtools_tests.py b/python/servo/devtools_tests.py
index f505639a534..cbd2b465192 100644
--- a/python/servo/devtools_tests.py
+++ b/python/servo/devtools_tests.py
@@ -24,6 +24,7 @@ from threading import Thread
 from typing import Optional
 import unittest
 
+from servo.command_base import BuildType
 
 # Set this to true to log requests in the internal web servers.
 LOG_REQUESTS = False
@@ -32,6 +33,7 @@ LOG_REQUESTS = False
 class DevtoolsTests(unittest.IsolatedAsyncioTestCase):
     # /path/to/servo/python/servo
     script_path = None
+    build_type: Optional[BuildType] = None
 
     def __init__(self, methodName="runTest"):
         super().__init__(methodName)
@@ -136,7 +138,7 @@ class DevtoolsTests(unittest.IsolatedAsyncioTestCase):
         # Run servoshell.
         if url is None:
             url = f"{self.base_url}/test.html"
-        self.servoshell = subprocess.Popen(["target/release/servo", "--devtools=6080", url])
+        self.servoshell = subprocess.Popen([f"target/{self.build_type.directory_name()}/servo", "--devtools=6080", url])
 
         # FIXME: Don’t do this
         time.sleep(1)
@@ -269,8 +271,9 @@ class DevtoolsTests(unittest.IsolatedAsyncioTestCase):
         client.disconnect()
 
 
-def run_tests(script_path):
+def run_tests(script_path, build_type: BuildType):
     DevtoolsTests.script_path = script_path
+    DevtoolsTests.build_type = build_type
     verbosity = 1 if logging.getLogger().level >= logging.WARN else 2
     suite = unittest.TestLoader().loadTestsFromTestCase(DevtoolsTests)
     return unittest.TextTestRunner(verbosity=verbosity).run(suite).wasSuccessful()
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py
index cee73184314..d0e87e34295 100644
--- a/python/servo/testing_commands.py
+++ b/python/servo/testing_commands.py
@@ -344,9 +344,10 @@ class MachCommands(CommandBase):
         return 0 if passed else 1
 
     @Command("test-devtools", description="Run tests for devtools.", category="testing")
-    def test_devtools(self):
+    @CommandBase.common_command_arguments(build_type=True)
+    def test_devtools(self, build_type: BuildType, **kwargs):
         print("Running devtools tests...")
-        passed = servo.devtools_tests.run_tests(SCRIPT_PATH)
+        passed = servo.devtools_tests.run_tests(SCRIPT_PATH, build_type)
         return 0 if passed else 1
 
     @Command(