Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-18 02:48:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout(grid): implement named grid lines and areas (#38306)

Browse source 
### Changes made

This implements named grid lines (line names in `grid-template-*`),
named grid areas (`grid-template-areas`), and the ability to target
those using `grid-{row,column}-{start,end}`. It also includes a bunch of
miscelaneous fixes for `repeat(auto-fill | auto-fit, ...)` syntax as
that interacts with the specification of line names.

The actual layout implementation is in Taffy. The bulk of this PR is
updating Servo to translate (CSS Grid-related) Stylo types into Taffy
types using a new iterator-based API which uses iterators and lazy
translation for efficiency (which is more important now that we're
dealing with string data, even though they're `Atom`s).

### Testing

This functionality has lots of WPT tests. It fixes some seemingly random
CSS Grid tests that use named lines/areas even though that's not what
they're testing.

### Screenshots

wikipedia.org

<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 03 16"
src="https://github.com/user-attachments/assets/2c50b96f-ae36-4405-ac48-b771bfdcb515"
/>

bbc.co.uk:

<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 32 57"
src="https://github.com/user-attachments/assets/ba84e211-65d2-4411-95fb-7b9b91bea31c"
/>

theguardian.com:

<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 33 29"
src="https://github.com/user-attachments/assets/e85daaa6-5fb0-45d4-b9ec-b22b38b087ec"
/>

---------

Signed-off-by: Nico Burns <nico@nicoburns.com>
This commit is contained in:
Nico Burns 2025-08-07 15:41:19 +01:00 • committed by GitHub
parent a9664c4199
commit fd20a5df42
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
44 changed files with 260 additions and 553 deletions
Download patch file Download diff file Expand all files Collapse all files

55
tests/wpt/meta/css/css-grid/parsing/grid-template-columns-computed-withcontent.html.ini vendored
View file

@ -1,74 +1,19 @@
[grid-template-columns-computed-withcontent.html]
expected: CRASH
[Property grid-template-columns value 'none']
expected: FAIL
[Property grid-template-columns value '20%']
expected: FAIL
[Property grid-template-columns value 'calc(-0.5em + 10px)']
expected: FAIL
[Property grid-template-columns value 'calc(0.5em + 10px)']
expected: FAIL
[Property grid-template-columns value 'calc(30% + 40px)']
expected: FAIL
[Property grid-template-columns value '5fr']
expected: FAIL
[Property grid-template-columns value 'min-content']
expected: FAIL
[Property grid-template-columns value 'max-content']
expected: FAIL
[Property grid-template-columns value 'auto']
expected: FAIL
[Property grid-template-columns value 'minmax(10px, auto)']
expected: FAIL
[Property grid-template-columns value 'minmax(20%, max-content)']
expected: FAIL
[Property grid-template-columns value 'minmax(min-content, calc(-0.5em + 10px))']
expected: FAIL
[Property grid-template-columns value 'minmax(auto, 0)']
expected: FAIL
[Property grid-template-columns value 'fit-content(70px)']
expected: FAIL
[Property grid-template-columns value 'fit-content(20%)']
expected: FAIL
[Property grid-template-columns value 'fit-content(calc(-0.5em + 10px))']
expected: FAIL
[Property grid-template-columns value 'repeat(1, 10px)']
expected: FAIL
[Property grid-template-columns value 'repeat(1, [one two\] 20%)']
expected: FAIL
[Property grid-template-columns value 'repeat(2, minmax(10px, auto))']
expected: FAIL
[Property grid-template-columns value 'repeat(2, fit-content(20%) [three four\] 30px 40px [five six\])']
expected: FAIL
[Property grid-template-columns value 'min-content repeat(5, minmax(10px, auto))']
expected: FAIL
[Property grid-template-columns value '[\] 150px [\] 1fr [\]']
expected: FAIL
[Property grid-template-columns value 'repeat(auto-fill, 200px)']
expected: FAIL
[Property grid-template-columns value 'repeat(auto-fit, [one\] 20%)']
expected: FAIL