Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-18 02:48:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout(grid): implement named grid lines and areas (#38306)

Browse source 
### Changes made

This implements named grid lines (line names in `grid-template-*`),
named grid areas (`grid-template-areas`), and the ability to target
those using `grid-{row,column}-{start,end}`. It also includes a bunch of
miscelaneous fixes for `repeat(auto-fill | auto-fit, ...)` syntax as
that interacts with the specification of line names.

The actual layout implementation is in Taffy. The bulk of this PR is
updating Servo to translate (CSS Grid-related) Stylo types into Taffy
types using a new iterator-based API which uses iterators and lazy
translation for efficiency (which is more important now that we're
dealing with string data, even though they're `Atom`s).

### Testing

This functionality has lots of WPT tests. It fixes some seemingly random
CSS Grid tests that use named lines/areas even though that's not what
they're testing.

### Screenshots

wikipedia.org

<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 03 16"
src="https://github.com/user-attachments/assets/2c50b96f-ae36-4405-ac48-b771bfdcb515"
/>

bbc.co.uk:

<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 32 57"
src="https://github.com/user-attachments/assets/ba84e211-65d2-4411-95fb-7b9b91bea31c"
/>

theguardian.com:

<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 33 29"
src="https://github.com/user-attachments/assets/e85daaa6-5fb0-45d4-b9ec-b22b38b087ec"
/>

---------

Signed-off-by: Nico Burns <nico@nicoburns.com>
This commit is contained in:
Nico Burns 2025-08-07 15:41:19 +01:00 • committed by GitHub
parent a9664c4199
commit fd20a5df42
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
44 changed files with 260 additions and 553 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/wpt/meta/css/css-grid/parsing/grid-template-rows-computed-implicit-track.html.ini vendored
View file

@ -1,11 +1,7 @@
[grid-template-rows-computed-implicit-track.html]
expected: CRASH
[Property grid-template-rows value 'none' computes to '10px']
expected: FAIL
[Property grid-template-rows value '1px' computes to '10px 1px']
expected: FAIL
[Property grid-template-rows value '1px [a\]' computes to '10px 1px [a\]']
expected: FAIL
@ -18,15 +14,6 @@
[Property grid-template-rows value '[a\] 1px [b\]' computes to '10px [a\] 1px [b\]']
expected: FAIL
[Property grid-template-rows value '1px repeat(1, 2px) 3px' computes to '10px 1px 2px 3px']
expected: FAIL
[Property grid-template-rows value '1px repeat(auto-fill, 2px) 3px' computes to '10px 1px 2px 3px']
expected: FAIL
[Property grid-template-rows value '1px repeat(auto-fit, 2px) 3px' computes to '10px 1px 0px 3px']
expected: FAIL
[Property grid-template-rows value '1px [a\] repeat(1, 2px 3px) [b\] 4px' computes to '10px 1px [a\] 2px 3px [b\] 4px']
expected: FAIL