From fd402782aa4fa9f07da2ea7c0fc694bf324aec7d Mon Sep 17 00:00:00 2001 From: Shubham Gupta <32428749+shubhamg13@users.noreply.github.com> Date: Fri, 19 Sep 2025 10:36:44 +0800 Subject: [PATCH] OHOS: Fix empty log filter issue on OHOS (#39362) Due to empty log filter, no logs are logged. Testing: Tested locally Fixes: None Signed-off-by: Shubham Gupta --- ports/servoshell/prefs.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ports/servoshell/prefs.rs b/ports/servoshell/prefs.rs index 14df9bc00e3..b7b6c3f7a4f 100644 --- a/ports/servoshell/prefs.rs +++ b/ports/servoshell/prefs.rs @@ -669,11 +669,9 @@ pub(crate) fn parse_command_line_arguments(args: Vec) -> ArgumentParsing userscripts_directory: cmd_args.userscripts, experimental_prefs_enabled: cmd_args.enable_experimental_web_platform_features, #[cfg(target_env = "ohos")] - log_filter: Some( - cmd_args - .log_filter - .unwrap_or(preferences.log_filter.clone()), - ), + log_filter: cmd_args.log_filter.or_else(|| { + (!preferences.log_filter.is_empty()).then(|| preferences.log_filter.clone()) + }), #[cfg(target_env = "ohos")] log_to_file: cmd_args.log_to_file, ..Default::default()