mirror of
https://github.com/servo/servo.git
synced 2025-08-07 14:35:33 +01:00
Auto merge of #25446 - pshaughn:fixme11868, r=jdm
Make getOwnPropertyDescriptor hold the correct value for indexed/named properties This is towards #25036 and #25415; it could have far-reaching implications so I want to test it in isolation and see the results on the full test suite. A few lines of code had a FIXME(#11868) despite that issue being closed, and looking for the pattern that was marked that way, I found one other unmarked instance of it. It doesn't immediately crash, and maybe it will pass some tests or fail some tests in informative ways. EDIT: After adding an overlooked extended attribute to HTMLFormElement, this works very well indeed and seems to be worth merging! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25036 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
commit
fdfc840bac
8 changed files with 6 additions and 30 deletions
|
@ -1,14 +1,5 @@
|
|||
[legacy-platform-object.html]
|
||||
type: testharness
|
||||
[[[GetOwnProperty\]\] with getters and no setters]
|
||||
expected: FAIL
|
||||
|
||||
[[[GetOwnProperty\]\] with named property getters and setters]
|
||||
expected: FAIL
|
||||
|
||||
[[[GetOwnProperty\]\] with indexed property getters and setters]
|
||||
expected: FAIL
|
||||
|
||||
[Test [[DefineOwnProperty\]\] with no indexed property setter support.]
|
||||
expected: FAIL
|
||||
|
||||
|
|
|
@ -6,6 +6,3 @@
|
|||
[Trying to set an expando with an indexed property name past the end of the list]
|
||||
expected: FAIL
|
||||
|
||||
[Trying to delete an indexed property name should never work]
|
||||
expected: FAIL
|
||||
|
||||
|
|
|
@ -5,9 +5,3 @@
|
|||
[Setting property for key 9 with accessor property on prototype]
|
||||
expected: FAIL
|
||||
|
||||
[Getting property descriptor for key 9]
|
||||
expected: FAIL
|
||||
|
||||
[Getting property descriptor for key x]
|
||||
expected: FAIL
|
||||
|
||||
|
|
|
@ -1,8 +1,5 @@
|
|||
[form-nameditem.html]
|
||||
type: testharness
|
||||
[Name for a single element should work]
|
||||
expected: FAIL
|
||||
|
||||
[All listed elements except input type=image should be present in the form]
|
||||
expected: FAIL
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue