mirror of
https://github.com/servo/servo.git
synced 2025-08-09 15:35:34 +01:00
Auto merge of #20740 - fabricedesre:mutation-observer-disconnect, r=jdm
Implement MutationObserver.disconnect() <!-- Please describe your changes on the following line: --> This implements https://dom.spec.whatwg.org/#dom-mutationobserver-disconnect I added a `node_list` to the `MutationObserver` struct to keep track of the nodes involved in an observer because otherwise I could not find a way to unregister the observers on the node themselves without traversing the whole document tree. Let me know if there's something I missed. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20740) <!-- Reviewable:end -->
This commit is contained in:
commit
fe1a057bd1
7 changed files with 25 additions and 15 deletions
|
@ -1,6 +1,5 @@
|
|||
[Element-classlist.html]
|
||||
type: testharness
|
||||
expected: TIMEOUT
|
||||
[classList.remove("a") with attribute value null (HTML node)]
|
||||
expected: FAIL
|
||||
|
||||
|
|
|
@ -1,8 +0,0 @@
|
|||
[MutationObserver-disconnect.html]
|
||||
type: testharness
|
||||
[subtree mutations]
|
||||
expected: FAIL
|
||||
|
||||
[disconnect discarded some mutations]
|
||||
expected: FAIL
|
||||
|
|
@ -1,7 +1,5 @@
|
|||
[MutationObserver-document.html]
|
||||
type: testharness
|
||||
[setup test]
|
||||
expected: FAIL
|
||||
|
||||
[parser insertion mutations]
|
||||
expected: FAIL
|
||||
|
|
|
@ -1,2 +0,0 @@
|
|||
[MutationObserver-takeRecords.html]
|
||||
type: testharness
|
Loading…
Add table
Add a link
Reference in a new issue