From 5c19eb59983898221746a1bcfa9ed20fc5a41279 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sat, 10 Feb 2018 19:47:04 +0100 Subject: [PATCH 1/3] style: Nix -moz-user-input: disabled. It does nothing, and there's only one use of it anyway. See the intent to unship for research on out of the tree usage: https://groups.google.com/d/msg/mozilla.dev.platform/E6tfP__wkwg/YVW6nPX9CQAJ Bug: 1405087 Reviewed-by: bz MozReview-Commit-ID: 5XnsewYdvgQ --- components/style/properties/longhand/pointing.mako.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/style/properties/longhand/pointing.mako.rs b/components/style/properties/longhand/pointing.mako.rs index 6361e394a09..9596a7029ec 100644 --- a/components/style/properties/longhand/pointing.mako.rs +++ b/components/style/properties/longhand/pointing.mako.rs @@ -21,7 +21,7 @@ ${helpers.single_keyword("pointer-events", "auto none", animation_value_type="di flags="APPLIES_TO_PLACEHOLDER", spec="https://www.w3.org/TR/SVG11/interact.html#PointerEventsProperty")} -${helpers.single_keyword("-moz-user-input", "auto none enabled disabled", +${helpers.single_keyword("-moz-user-input", "auto none enabled", products="gecko", gecko_ffi_name="mUserInput", gecko_enum_prefix="StyleUserInput", animation_value_type="discrete", From 3378d295482ac5090c58847fc00fa89b6f09f42c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sun, 11 Feb 2018 21:12:26 +0100 Subject: [PATCH 2/3] style: Also nix -moz-user-input: enabled. It only has one use, has the same effect that "auto", and should have no effect in elements anyway (plus it's not overridden or used in that file at all anyway), so we can remove its only use instead. I can also change that use to "auto" if you want, but bug 760876 doesn't mention -moz-user-input at all, so I think this is quite useless... See the intent to unship for research on out of the tree usage: https://groups.google.com/d/msg/mozilla.dev.platform/E6tfP__wkwg/YVW6nPX9CQAJ Bug: 1405087 Reviewed-by: bz MozReview-Commit-ID: 8EzQlzu9drE --- components/style/properties/longhand/pointing.mako.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/style/properties/longhand/pointing.mako.rs b/components/style/properties/longhand/pointing.mako.rs index 9596a7029ec..fbd34cc5754 100644 --- a/components/style/properties/longhand/pointing.mako.rs +++ b/components/style/properties/longhand/pointing.mako.rs @@ -21,7 +21,7 @@ ${helpers.single_keyword("pointer-events", "auto none", animation_value_type="di flags="APPLIES_TO_PLACEHOLDER", spec="https://www.w3.org/TR/SVG11/interact.html#PointerEventsProperty")} -${helpers.single_keyword("-moz-user-input", "auto none enabled", +${helpers.single_keyword("-moz-user-input", "auto none", products="gecko", gecko_ffi_name="mUserInput", gecko_enum_prefix="StyleUserInput", animation_value_type="discrete", From db689c85c2735c17619da59a94937f1fbec2c1be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Thu, 15 Feb 2018 11:50:50 +0100 Subject: [PATCH 3/3] style: Update bindings. --- components/style/gecko/generated/structs.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/components/style/gecko/generated/structs.rs b/components/style/gecko/generated/structs.rs index 5762d067e28..ec899494fe3 100644 --- a/components/style/gecko/generated/structs.rs +++ b/components/style/gecko/generated/structs.rs @@ -4973,9 +4973,7 @@ pub mod root { #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)] pub enum StyleUserInput { None = 0, - Enabled = 1, - Disabled = 2, - Auto = 3, + Auto = 1, } #[repr(u8)] #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)]