Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix wrong priority for XHR username/password

Browse source
This commit is contained in:
Vincent Ricard 2020-09-21 18:37:58 +02:00
parent 46f8f3d009
commit ff6194cc74
2 changed files with 3 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/script/dom/xmlhttprequest.rs
View file

@ -390,8 +390,9 @@ impl XMLHttpRequestMethods for XMLHttpRequest {
if parsed_url.host().is_some() {
if let Some(user_str) = username {
parsed_url.set_username(&user_str.0).unwrap();
let password = password.as_ref().map(|pass_str| &*pass_str.0);
parsed_url.set_password(password).unwrap();
}
if let Some(pass_str) = password {
parsed_url.set_password(Some(&pass_str.0)).unwrap();
}
}

13
tests/wpt/metadata/xhr/send-authentication-competing-names-passwords.htm.ini
View file

@ -1,13 +0,0 @@
[send-authentication-competing-names-passwords.htm]
[XMLHttpRequest user/pass options: pass in URL, user in open()]
expected: FAIL
[XMLHttpRequest user/pass options: user in URL, pass in open()]
expected: FAIL
[XMLHttpRequest user/pass options: user/pass in URL; user in open()]
expected: FAIL
[XMLHttpRequest user/pass options: user/pass in URL; pass in open()]
expected: FAIL