Auto merge of #23279 - snarasi6:master, r=jdm

Implement deprecated setPosition and setOrientation methods for AudioListener #22898

<!-- Please describe your changes on the following line: -->
I have uncommented the two methods SetPosition and SetOrientation in AudioListener.webidl and have included the two methods in the AudioListener.rs file. I have some errors while handling the NotSupported error for the methods. Can you please review the code and help me out with the errors?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23279)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2019-04-27 20:47:11 -04:00 committed by GitHub
commit ffd9441a3d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 42 additions and 21 deletions

View file

@ -5,9 +5,6 @@
[StereoPannerNode interface: attribute pan]
expected: FAIL
[AudioListener interface: calling setPosition(float, float, float) on context.listener with too few arguments must throw TypeError]
expected: FAIL
[AudioNode interface: new MediaElementAudioSourceNode(context, {mediaElement: new Audio}) must inherit property "disconnect(AudioParam)" with the proper type]
expected: FAIL
@ -353,9 +350,6 @@
[AudioNode interface: new IIRFilterNode(context, {feedforward: [1\], feedback: [1\]}) must inherit property "disconnect(AudioNode)" with the proper type]
expected: FAIL
[AudioListener interface: calling setOrientation(float, float, float, float, float, float) on context.listener with too few arguments must throw TypeError]
expected: FAIL
[ScriptProcessorNode interface: existence and properties of interface prototype object's "constructor" property]
expected: FAIL
@ -422,9 +416,6 @@
[AudioNode interface: new MediaElementAudioSourceNode(context, {mediaElement: new Audio}) must inherit property "disconnect()" with the proper type]
expected: FAIL
[AudioListener interface: operation setOrientation(float, float, float, float, float, float)]
expected: FAIL
[AudioNode interface: new StereoPannerNode(context) must inherit property "disconnect(AudioNode, unsigned long, unsigned long)" with the proper type]
expected: FAIL
@ -719,9 +710,6 @@
[OfflineAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "suspend(double)" with the proper type]
expected: FAIL
[AudioListener interface: operation setPosition(float, float, float)]
expected: FAIL
[AudioNode interface: new ConvolverNode(context) must inherit property "channelCount" with the proper type]
expected: FAIL
@ -1304,9 +1292,6 @@
[AudioNode interface: new IIRFilterNode(context, {feedforward: [1\], feedback: [1\]}) must inherit property "disconnect(AudioParam, unsigned long)" with the proper type]
expected: FAIL
[AudioListener interface: context.listener must inherit property "setOrientation(float, float, float, float, float, float)" with the proper type]
expected: FAIL
[WaveShaperNode interface object name]
expected: FAIL
@ -1532,9 +1517,6 @@
[AudioNode interface: new ConvolverNode(context) must inherit property "context" with the proper type]
expected: FAIL
[AudioListener interface: context.listener must inherit property "setPosition(float, float, float)" with the proper type]
expected: FAIL
[ConvolverNode interface: new ConvolverNode(context) must inherit property "normalize" with the proper type]
expected: FAIL