Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-13 08:28:19 +01:00
Code Issues Projects Releases Packages Wiki Activity

canvas: ensure there is a subpath in PathBuilderRef (#37251)

Browse source 
This is also required by spec:
https://html.spec.whatwg.org/multipage/canvas.html#ensure-there-is-a-subpath
and if we not ensure it vello will trigger debug asserts. Enforcing this
at `PathBuilderRef` is the lowest possible level that avoids misuse (and
avoids IPC messages if we were to do this in content process) while
still keeping it from backend.

Testing: There are tests in WPT
Split of https://github.com/servo/servo/pull/36821
try run: https://github.com/sagudev/servo/actions/runs/15449044694

---------

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This commit is contained in:
sagudev 2025-06-05 04:47:37 +02:00 • committed by GitHub
parent b13f49ab09
commit ffe9163892
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 33 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/wpt/meta/css/css-borders/tentative/corner-shape/corner-shape-render-precise.html.ini vendored
View file

@ -37,9 +37,6 @@
[corner-shape-render-precise.html?corner-top-left-shape=bevel&border-width=10px&border-color=black]
expected: FAIL
[corner-shape-render-precise.html?corner-bottom-right-shape=bevel&corner-bottom-left-shape=bevel]
expected: FAIL
[corner-shape-render-precise.html?corner-shape=superellipse(8)&border-radius=10px&box-shadow=10px 10px 0 10px black]
expected: FAIL
@ -91,11 +88,5 @@
[corner-shape-render-precise.html?corner-shape=superellipse(-2)&border-top-left-radius=40%&border-width=20px]
expected: FAIL
[corner-shape-render-precise.html?corner-top-left-shape=bevel&border-width=10px]
expected: FAIL
[corner-shape-render-precise.html?corner-shape=notch&border-radius=30px&border-width=30px]
expected: FAIL
[corner-shape-render-precise.html?corner-top-right-shape=bevel&border-width=10px]
expected: FAIL