this way of invoking mach is incorrect now that we use uv, and it will
prevent us from running bencher builds on self-hosted runners (#39269),
where the system Python is too old (3.10 vs 3.11).
Testing:
- mach try bencher
<https://github.com/servo/servo/actions/runs/17675086579>
Fixes: part of #39269
Signed-off-by: Delan Azabani <dazabani@igalia.com>
Renames `--branch-start-point`, `--branch-start-point-hash`, and
`--branch-reset`, in favor of `--start-point`, `--start-point-hash`, and
`--start-point-reset`, according to [Bencher's
Docs](https://bencher.dev/docs/reference/changelog/#v0421).
Fixes: #38501
---------
Signed-off-by: Timmy <timmy@Timmys-Mac-mini.local>
Signed-off-by: Timothy Elems <timmy@Timmys-Mac-mini.local>
Signed-off-by: elemstimothy@protonmail.com <timmy@Timmys-Mac-mini.local>
Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
Co-authored-by: Timmy <timmy@Timmys-Mac-mini.local>
Co-authored-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
When running bencher on pull requests or try, we want to clone any
thresholds we setup for main to detect regressions.
Note: The thresholds we are actually interested in are defined on the
production profile, while in PRs we currently test release. Probably we
should reconsider that, but perhaps that could be a different PR with
seperate discussion.
Testing: ./mach try
([ohos](https://github.com/servo/servo/actions/runs/16779272577))
---------
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
Co-authored-by: sagudev <16504129+sagudev@users.noreply.github.com>
This is causing a validation error because Github's static analysis sees
nightly.yml is calling bencher.yml but the latter requires permissions
that are more relaxed than the former (for android & ohos). Since other
workflows are not failing validation, they presumably already run with
default permissions that are satisfy bencher.yml's requirements
(bencher.yml is not relaxing the parent workflow's permissions as that
would defeat the usefulness of the validation that Github is enforcing).
In the long run we should move to default-restrictive permissions and
then have the top-level workflows declare the required permissions. The
permissions in bencher.yml seems to serve only as machine-checked
documentation, but as it is causing issues with nested calls that are
not possible at runtime, it seems like we have to either pass additional
permissions in top-level workflows (that are not needed, so that is bad)
or not declare them in nested workflows.
Fixes#35141.
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
