Commit graph

2212 commits

Author SHA1 Message Date
Simon Martin
fa555d0e2e Issue #6791: Allow more array types in bufferData and bufferSubData. 2015-12-06 15:28:59 +01:00
bors-servo
b32128e299 Auto merge of #8768 - vegayours:8616_intermittent_option_unwrap_in_timers, r=jdm
fix intermittent Option::unwrap in timers

fixes intermittent #8616

This intermittent indicates real problem in code.
Lets consider such code:
```javascript
// timer 1
setTimeout(function() {
     //timer 2
     setTimeout(function() {}, 0);
}, 0);
```
When we receive event to fire timer 1 it will be selected and extracted from active timers list in fire_timer function. During timer 1 handler execution we will schedule timer 2 and request timer event for it. But it will be executed during same fire_timer call because of 0 timeout. And as a result we will have empty timers list and expecting event for timer 2 that will crash in assert.

I'm not sure that all I've written is clear, but we have something like this:
```
install timer 1 -> [1] in timers list
push and expect timer event 1 -> expected_event=1
received timer event 1
    fire_timer()
         select timer 1 to execute -> [] in timers list
         execute timer 1 handler
             install timer 2 -> [2] in timers list
             push and expect timer event 2 -> expected_event=2
         select timer 2 to execute (because of 0 timeout) -> [] in tiemrs list
         execute timer 2 handler
expected_event=2 is dangling
received timer event 2
    fire_timer() -> BOOM
```

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8768)
<!-- Reviewable:end -->
2015-12-04 21:19:58 +05:30
Aleksandr Likhanov
d891e75d9d fix intermittent Option::unwrap in timers
not allow to fire timers installed during another timer call
2015-12-04 20:16:43 +05:00
bors-servo
2bb34feb3e Auto merge of #8728 - dzbarsky:reset_bitmpa, r=dzbarsky
Reset canvas state when changing bitmap dimensions

Ran http://mxr.mozilla.org/servo/source/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.2dstate.html?force=1#88 to confirm that this code is being executed, but the test still fails because the font isn't implemented and the expando doesn't get reset.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8728)
<!-- Reviewable:end -->
2015-12-04 11:57:55 +05:30
bors-servo
18f74a3d69 Auto merge of #8293 - simartin:issue_8113, r=jdm
Issue #8113: Support file, about and data schemes as form action.

Fix https://github.com/servo/servo/issues/8113 by supporting those schemes as form action and unit test the "about:blank" case

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8293)
<!-- Reviewable:end -->
2015-12-03 22:48:46 +05:30
bors-servo
db0a0ac9f6 Auto merge of #8793 - Ms2ger:test-ref, r=frewsxcv
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8793)
<!-- Reviewable:end -->
2015-12-03 20:34:39 +05:30
bors-servo
c2bdae1ec3 Auto merge of #8781 - Ms2ger:test-ref, r=frewsxcv
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8781)
<!-- Reviewable:end -->
2015-12-03 13:30:50 +05:30
Simon Martin
2b332a2138 Issue #8113: Support file, about and data schemes as form action. 2015-12-02 22:41:24 +01:00
Anthony Ramine
60976406cc Implement [Unforgeable]
This is mostly stolen from Gecko. As there, we define the unforgeable members
on an object stored in the slots of the prototype object. They are then copied
onto instance objects when they are instantiated. It should be noted that
proxy objects see their unforgeable memebers defined on their expando object.

Unforgeable attributes aren't properly inherited in codegen (in a similar
fashion as getters and setters as filed in #5875) and require to be redefined
in derived interfaces. Fortunately, there are currently no such interfaces.

No unforgeable members can be included into the TestBinding interfaces for good
measure because they are not compatible with setters.

Given the unforgeable holder object has the same prototype as actual instances
of the interface, the finalize hook needs to check its slot pointer for nullity
before dropping it.

The new failing test isn't related to Unforgeable attributes, but to the fact
that all Document instances currently have a Location, even if their window
isn't in a browsing context.
2015-12-02 22:15:11 +01:00
Ms2ger
81a5948b23 Move vertical-lr-blocks.html to wpt reftests. 2015-12-02 16:07:20 +01:00
Ms2ger
d8fe60ccb1 Move text_decoration_propagation_a.html to wpt reftests. 2015-12-02 15:48:17 +01:00
Ms2ger
1ff3424a8b Move text_overflow_a.html to wpt reftests. 2015-12-02 15:34:10 +01:00
Ms2ger
03d5db9e12 Move position_fixed_static_y_a.html to wpt reftests. 2015-12-02 14:11:06 +01:00
Ms2ger
9b7864aa1a Move position_fixed_simple_a.html to wpt reftests. 2015-12-02 14:08:58 +01:00
Ms2ger
91d798cbd6 Move position_fixed_a.html to wpt reftests. 2015-12-02 14:05:20 +01:00
Ms2ger
2c4232b620 Move overflow_position_abs_inside_normal_a.html to wpt reftests. 2015-12-02 14:01:10 +01:00
David Zbarsky
302f41d34b Reset canvas state when changing bitmap dimensions 2015-11-30 21:23:51 -08:00
Ms2ger
ae6585da88 Move overconstrained_block.html to wpt reftests. 2015-11-29 10:57:16 +01:00
Ms2ger
facee849c2 Move link_style_dynamic_addition.html to wpt reftests. 2015-11-29 10:57:15 +01:00
Ms2ger
27e3ca61ec Move linebreak_simple_a.html to wpt reftests. 2015-11-29 10:57:14 +01:00
Ms2ger
51af73d872 Fix the metadata file for size_attributes_vertical_writing_mode.html. 2015-11-29 10:57:12 +01:00
bors-servo
99223656fb Auto merge of #8675 - GuillaumeGomez:master, r=nox
Add XMLDocument object

Fixes #8000

(Still working on it)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8675)
<!-- Reviewable:end -->
2015-11-27 19:29:04 +05:30
Guillaume Gomez
adf8b359bb Add XMLDocument object 2015-11-27 14:55:41 +01:00
bors-servo
4e8c9c9811 Auto merge of #8686 - Ms2ger:test-ref, r=frewsxcv
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8686)
<!-- Reviewable:end -->
2015-11-27 06:35:15 +05:30
Josh Matthews
ca882762fc Disable canvas_over_area.html due to frequent timeouts, pending further investigation for #8311. 2015-11-26 13:23:38 -05:00
Ms2ger
b7dab2947f Move stacking_context_position_a.html to wpt reftests. 2015-11-26 16:08:54 +01:00
Ms2ger
300eb9e8dd Move stacking_context.html to wpt reftests. 2015-11-26 09:11:49 +01:00
Ms2ger
b0243d66a6 Move size_attributes_vertical_writing_mode.html to wpt reftests. 2015-11-26 09:08:11 +01:00
Ms2ger
e2c5143ec7 Move size_attributes.html to wpt reftests. 2015-11-26 09:01:18 +01:00
Ms2ger
3f99612e5d Move simple_inline_width_percentage.html to wpt reftests. 2015-11-26 09:01:17 +01:00
Ms2ger
9889fa2139 Move simple_inline_width_height.html to wpt reftests. 2015-11-26 09:01:16 +01:00
Ms2ger
86f2187e6a Move simple_inline_width.html to wpt reftests. 2015-11-26 09:01:15 +01:00
Ms2ger
1e868aab6f Move simple_inline_min.html to wpt reftests. 2015-11-26 09:01:14 +01:00
Ms2ger
bffde87f78 Move simple_inline_max.html to wpt reftests. 2015-11-26 09:01:13 +01:00
Ms2ger
dbc79eea96 Move simple_inline_height.html to wpt reftests. 2015-11-26 09:01:11 +01:00
bors-servo
e7b1924948 Auto merge of #6826 - dzbarsky:deletecontents, r=jdm
Implement Range#deleteContents

Sadly calling ExtractContents and discarding the result doesn't do the right thing.
It may be worth having a CutContents method that takes an `Option<DocumentFragment>` and switch the behavior based on it, to share the code between DeleteContents and ExtractContents, like what Gecko does.  Maybe a followup.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6826)
<!-- Reviewable:end -->
2015-11-25 19:55:02 +05:30
bors-servo
6684804846 Auto merge of #8648 - Ms2ger:test-ref, r=frewsxcv
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8648)
<!-- Reviewable:end -->
2015-11-25 15:30:12 +05:30
David Zbarsky
25b7c9523c Implement Range#deleteContents 2015-11-25 00:02:25 -08:00
Ms2ger
3a79c9b53f Update web-platform-tests to revision ee40b886c701ffa25a673240cabdedd59ee3ace4 2015-11-24 13:35:04 +01:00
Ms2ger
576c4f7e4b Move simple_inline_default.html to wpt reftests. 2015-11-22 15:39:10 +01:00
Ms2ger
7254a25fc5 Move simple.html to wpt reftests. 2015-11-22 15:34:52 +01:00
Ms2ger
2450694eee Move positioning_margin.html to wpt reftests. 2015-11-22 15:24:28 +01:00
Ms2ger
e228e29289 Move overflow.html to wpt reftests. 2015-11-22 15:22:00 +01:00
Ms2ger
ea118c56d6 Move multiple_external.html to wpt reftests. 2015-11-22 15:16:29 +01:00
Ms2ger
4cb6a87992 Move hide_layers1.html and hide_layers2.html to wpt reftests. 2015-11-22 15:14:37 +01:00
Ms2ger
4466fc3537 Move hide_and_show.html to wpt reftests. 2015-11-22 15:12:08 +01:00
Ms2ger
19c4991c55 Move hide_after_load.html to wpt reftests. 2015-11-22 15:10:15 +01:00
Ms2ger
833cd524e0 Move bg_color.html to wpt reftests. 2015-11-22 15:08:05 +01:00
bors-servo
f2fe1171d2 Auto merge of #8601 - mfeckie:feature/manifest-diff-ci-check, r=jdm
Check if MANIFEST.json changes as per #8587

Adds a script which checks if either of the MANIFEST.json files change in `test/wpt` in response to #8587

- Addresses currently incorrect MANIFEST.json
- Adds checking script

PR for saltfs to add to CI checks to follow (https://github.com/servo/saltfs/pull/163)

https://reviewable.io/reviews/servo/servo/8601

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8601)
<!-- Reviewable:end -->
2015-11-21 20:13:10 +05:30
Ms2ger
bd25225cd2 Move viewport_meta.html and viewport_rule.html to wpt reftests. 2015-11-21 10:21:02 +01:00