Commit graph

35453 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
fcada8a71e
style: Remove outdated comment. 2018-11-17 09:52:52 +01:00
bors-servo
94991db145
Auto merge of #22202 - servo:webgl, r=jdm
Clean up some code on the WebGL texture upload paths

This doesn't actually change anything… yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22202)
<!-- Reviewable:end -->
2018-11-17 02:35:22 -05:00
bors-servo
679fb36924
Auto merge of #22176 - servo:jdm-patch-20, r=KiChjang
Don't try to use test-css command in CI.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22176)
<!-- Reviewable:end -->
2018-11-17 00:37:38 -05:00
WPT Sync Bot
1d0624b343 Update web-platform-tests to revision 04cd5eb8e5c47e4fe341f2fb541d39fa2346f464 2018-11-16 22:24:36 -05:00
bors-servo
ef9e892aa1
Auto merge of #22210 - asajeffrey:magicleap-very-well-hidden-flag, r=jdm
Add debuggable flag to magicleap taildata

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they fix a crash

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22210)
<!-- Reviewable:end -->
2018-11-16 21:50:35 -05:00
bors-servo
e50e2621fe
Auto merge of #22191 - mandreyel:update-sw-global-scope, r=paulrouget
Update webidl of ServiceWorkerGlobalScope

Part of #19302.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes are part of #19302  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they just update the webidl for `ServiceWorkerGlobalScope`; related tests should be updated when we start to implement its functions.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22191)
<!-- Reviewable:end -->
2018-11-16 19:55:30 -05:00
bors-servo
0ab2c3f8a3
Auto merge of #22196 - paulrouget:ndkfilter, r=Manishearth
Add only one architecture per apk

Fix #22192

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22196)
<!-- Reviewable:end -->
2018-11-16 18:14:37 -05:00
bors-servo
1517298820
Auto merge of #22175 - servo:jdm-patch-19, r=jdm
Fix linux-rel-intermittent build.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22175)
<!-- Reviewable:end -->
2018-11-16 16:18:03 -05:00
bors-servo
fa77675488
Auto merge of #22171 - CYBAI:sw-up-to-date, r=jdm
Update webidl of ServiceWorkerRegistration

I'll start to work on #19302 and I'd like to update these sw related webidl one by one.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes is part of #19302
- [x] These changes do not require tests because it just updates the webidl for `ServiceWorkerRegistration`; related tests should be updated when we start to implement its functions.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22171)
<!-- Reviewable:end -->
2018-11-16 15:11:25 -05:00
Alan Jeffrey
ff07fc3132 Add debuggable flag to magicleap taildata 2018-11-16 13:29:58 -06:00
bors-servo
369983211d
Auto merge of #22170 - CYBAI:fix-promiserejectevent, r=jdm
Fix PromiseRejectionEvent constructor when promise argument is None

Due to lack of `required` of the `promise` argument in webidl, we need to handle this so that it can be correct behavior. And then the constructor test will be passed!

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22170)
<!-- Reviewable:end -->
2018-11-16 12:27:08 -05:00
bors-servo
831f966b0c
Auto merge of #21978 - jimberlage:input-value-fix, r=jdm
Fixes panic on DOMString::strip_leading_and_trailing_ascii_whitespace

<!-- Please describe your changes on the following line: -->
This changes `DOMString::strip_leading_and_trailing_ascii_whitespace` to handle multi-byte unicode characters.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21963 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21978)
<!-- Reviewable:end -->
2018-11-16 11:10:32 -05:00
bors-servo
a2937d9488
Auto merge of #21804 - AgustinCB:unify-task-source-canceller-api, r=gterzian
Unify the task source and task canceller API

To do so, I created a struct `TaskManagement(TaskSource,
TaskCanceller)` and made `*_task_source` return that instead of just
the task source.

Next, I refactored all places in which `task_canceller` by basically
removing them in favour of a previously called `*_task_source`.

I tried to make `task_canceller` a private method in `Window`, with the
hope of enforcing the use of `*_task_source`. However, it's used in
components/script/dom/globalscope.rs:575 in such a way that will make it
harder to avoid. I decided to leave it that way.

It'd be possible to unify `*_task_source` in such a way that we would
have only one method. However, I decided not to do it because one of the
`TaskSource` implementations is special:
`history_traversal_task_source`. Not wanting to over complicate things,
I decided to leave the structure this way.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21154 (github issue number if applicable).

- [x] These changes do not require tests because it's refactoring code that should already be tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21804)
<!-- Reviewable:end -->
2018-11-16 09:54:40 -05:00
bors-servo
050b2bca70
Auto merge of #22165 - pyfisch:assert-glyph, r=jdm
Enable old glyph assertion

The assertion had a note that it should be enabled
when something like debug_assert is available.

This must have been disabled since before Rust 1.0 as it uses invalid syntax.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22165)
<!-- Reviewable:end -->
2018-11-16 08:22:43 -05:00
Anthony Ramine
af2b4dbc21 Pass a TexPixels value to tex_image_2d and tex_sub_image_2d 2018-11-16 12:43:19 +01:00
Anthony Ramine
947e5afa0c Remove some boolean flags in tex_image_2d and tex_sub_image_2d 2018-11-16 12:42:57 +01:00
Anthony Ramine
3f8a3b2887 Simplify define_resource_id 2018-11-16 12:39:21 +01:00
Anthony Ramine
1c89ac90b9 Send alignment info directly in TexImage2D and TexSubImage2d messages 2018-11-16 12:39:20 +01:00
Anthony Ramine
1675991b12 Fix the data type sent in tex_sub_image_2d 2018-11-16 12:38:33 +01:00
Anthony Ramine
65d1b11929 Make TexImage2D and TexSubImage2D struct variants 2018-11-16 12:38:07 +01:00
Anthony Ramine
da43e35ab2 Optimise memory allocation in set_webrender_image_key 2018-11-16 12:37:53 +01:00
Anthony Ramine
a5779ad372 Prefix some pixels functions with rgba8_ 2018-11-16 12:37:34 +01:00
Anthony Ramine
adf363a208 Move prepare_pixels helper functions to canvas_traits 2018-11-16 12:37:31 +01:00
Anthony Ramine
86987ed75d Introduce TexPixels 2018-11-16 12:18:22 +01:00
Anthony Ramine
1e2a72abfe Call prepare_pixels in tex_image_2d and tex_sub_image_2d 2018-11-16 12:17:07 +01:00
Alan Jeffrey
deb599f5ee Use a laser pointer rather than the trackpad to control web content. 2018-11-15 16:17:14 -06:00
bors-servo
24cb7491d6
Auto merge of #22149 - CYBAI:rejectionhandled, r=jdm
Implement rejectionhandled event

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22006 .
- [x] There are more tests `PASS`ed for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22149)
<!-- Reviewable:end -->
2018-11-15 16:51:30 -05:00
bors-servo
4620f0b8c8
Auto merge of #22180 - asajeffrey:magicleap-nightly, r=jdm
Package and release the Servo magicleap app

<!-- Please describe your changes on the following line: -->

Package the Magic Leap Servo2D app, and build and release it nightly.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't test ML

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22180)
<!-- Reviewable:end -->
2018-11-15 15:34:37 -05:00
bors-servo
b8281b4374
Auto merge of #22185 - servo:tc-mac, r=Manishearth
Taskcluster: add dev build and unit tests on macOS

For simplicity, Salt is used in [agentless](https://docs.saltstack.com/en/getstarted/ssh/) mode for now.

I’m also hoping to have most of the dependencies be installed by tasks for themselves, so that changes can be made in the same `servo/servo` PR that uses them without redeploying servers.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22185)
<!-- Reviewable:end -->
2018-11-15 13:35:25 -05:00
Simon Sapin
1c7dbe1036 Taskcluster: Add dev build and unit tests on macOS 2018-11-15 17:38:21 +01:00
Simon Sapin
79bd98b679 generic-worker on macOS: more docs, move minion config out of roster 2018-11-15 17:38:13 +01:00
Simon Sapin
2017bc8931 UTC 2018-11-15 17:38:13 +01:00
Simon Sapin
ef4e72ca7d generic-worker on macOS: move generic-worker.plist template to a separate file 2018-11-15 17:38:13 +01:00
Simon Sapin
fe0e1ae7d3 generic-worker on macOS: read-only config 2018-11-15 17:38:13 +01:00
Simon Sapin
ff1e2c2394 generic-worker on macOS: configure livelog 2018-11-15 17:38:13 +01:00
Simon Sapin
a5089885ac generic-worker on macOS: restart service on config change 2018-11-15 17:38:13 +01:00
Simon Sapin
70f507879f generic-worker on macOS: run as unprivileged user, start as a service 2018-11-15 17:38:13 +01:00
Simon Sapin
889d479935 Initial generic-worker config file 2018-11-15 17:38:13 +01:00
Simon Sapin
11b9391e90 Initial agentless SaltStack config for generic-worker on macOS 2018-11-15 17:38:13 +01:00
bors-servo
13e322183d
Auto merge of #22199 - servo-wpt-sync:wpt_update_14-11-2018, r=jdm
Sync WPT with upstream (14-11-2018)

Automated downstream sync of changes from upstream as of 14-11-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22199)
<!-- Reviewable:end -->
2018-11-15 11:17:18 -05:00
bors-servo
359ec7a76f
Auto merge of #22201 - servo:jdm-patch-24, r=simonsapin
Remove android emulator tests from buildbot CI.

This works around #22187 on CI, since I have not been able to figure out what changed yet. I can reproduce the problem locally, so I can keep poking at it without holding up all the other work going on.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22201)
<!-- Reviewable:end -->
2018-11-15 09:58:01 -05:00
Josh Matthews
cf998d5c58
Mock android x86 task instead of commenting it. 2018-11-15 09:57:39 -05:00
Josh Matthews
cdb5b60202
Remove android emulator tests from taskcluster. 2018-11-15 09:26:07 -05:00
Josh Matthews
0780f8c37e
Remove android emulator tests from buildbot CI. 2018-11-15 09:24:22 -05:00
WPT Sync Bot
ff06f1d031 Update web-platform-tests to revision 6856483bcc86322198f10e0c42385a7f9127eb66 2018-11-14 22:29:47 -05:00
Agustin Chiappe Berrini
75eb94afca Unify the task source and task canceller API
I moved away from the `Window` struct all the logic to handle task
sources, into a new struct called `TaskManager`. In a happy world, I'd
be able to just have there two functions, of the types:

```rust
fn task_source<T: TaskSource>(&self, name: TaskSourceName) -> Box<T>
fn task_source_with_canceller<T: TaskSource>(&self, name: TaskSourceName)
  -> (Box<T>, TaskSourceCanceller)
```

And not so much duplicated code. However, because TaskSource can't be a
trait object (because it has generic type parameters), that's not
possible. Instead, I decided to reduce duplicated logic through macros.

For reasons[1], I have to pass both the name of the function with
canceller and the name of the function without, as I'm not able to
concatenate them in the macro itself. I could probably use
`concat_idents` to create both types already defined and reduce the
amount of arguments by one, but that macro is nightly only. At the same
time, not being able to declare macros inside `impl` forces me to pass
`self` as an argument.

All this makes this solution more verbose than it would be ideally. It
does reduce duplication, but it doesn't reduce the size of the file.

[1](https://github.com/rust-lang/rust/issues/29599)
2018-11-14 06:36:44 -05:00
Paul Rouget
971bda7b10 Add only one architecture per apk 2018-11-14 11:41:38 +01:00
Alan Jeffrey
ef2c2f933b Add magicleap-nightly builder 2018-11-13 16:33:01 -06:00
mandreyel
df1a3a7ea3 Update webidl of ServiceWorkerGlobalScope 2018-11-13 23:10:44 +01:00
Agustin Chiappe Berrini
14bc8ab754 Implement TaskSource for HistoryTraversal
And remove the method in window that returns it, because it isn't used
so far.
2018-11-13 14:18:51 -05:00