Commit graph

19510 commits

Author SHA1 Message Date
Ting-Yu Lin
0c0ffef1a5
style: Convert NS_STYLE_COLUMN_SPAN_* to an enum class.
Bug: 1477533
Reviewed-by: heycam
MozReview-Commit-ID: F8M1DlpBop2
2018-07-24 03:31:53 +02:00
Ting-Yu Lin
23b1d4d640
style: Convert NS_STYLE_COLUMN_FILL_* to an enum class.
I put Balance as the first item in StyleColumnFill because it is the default
value.

Bug: 1477533
Reviewed-by: heycam
MozReview-Commit-ID: A4DVMLL6XBa
2018-07-24 03:31:41 +02:00
Ting-Yu Lin
9f5237b87c
style: Use static const class variable to represent column-count: auto.
NS_STYLE_COLUMN_COUNT_UNLIMITED is unused, so I remove it.

Bug: 1477533
Reviewed-by: heycam
MozReview-Commit-ID: HLHLn9ZbkUY
2018-07-24 03:31:24 +02:00
Emilio Cobos Álvarez
77f47eea34
style: Hide display: -moz-box|-moz-inline-box from content on Nightly and early beta.
Bug: 1477553
Differential Revision: https://phabricator.services.mozilla.com/D2288
2018-07-24 03:31:12 +02:00
Emilio Cobos Álvarez
7e77f4dd4e
style: Add @-moz-document media-document(image|video|plugin).
Bug: 1475511
Reviewed-by: xidorn
MozReview-Commit-ID: CD3O1vGLAoV
2018-07-24 03:30:59 +02:00
Emilio Cobos Álvarez
5634a3f670
style: Make document condition parsing a bit nicer.
Bug: 1475511
Reviewed-by: xidorn
MozReview-Commit-ID: Gi0FxrEAYcE
2018-07-24 03:30:46 +02:00
Emilio Cobos Álvarez
095841db7f
style: UrlMatchingFunction -> DocumentMatchingFunction.
Bug: 1475511
Reviewed-by: xidorn
MozReview-Commit-ID: HLcaVmehFW7
2018-07-24 03:30:33 +02:00
Emilio Cobos Álvarez
02d27ad3dd
style: Make svg:use use an actual shadow tree.
This fixes a couple fuzz bugs and prevents special-casing <svg:use> even more in
bug 1431255.

Unfortunately not as many hacks went away as I'd have hoped, since we still need
to match document rules, see the linked SVGWG issues.

But blocks_ancestor_combinators goes away, which is nice since it's on a very
hot path.

Bug: 1450250
Reviewed-by: heycam
Differential Revision: https://phabricator.services.mozilla.com/D2154

MozReview-Commit-ID: C4mthjoSNFh
2018-07-24 03:30:12 +02:00
Xidorn Quan
1a91beaf57
style: Remove DeclarationPushMode.
Bug: 1473180
Reviewed-by: emilio
MozReview-Commit-ID: LFgYeKE1SNk
2018-07-24 03:29:59 +02:00
Xidorn Quan
a0edeb1a92
style: Remove DeclarationPushMode::Update and related code.
Bug: 1473180
Reviewed-by: emilio
MozReview-Commit-ID: 1fI5YRa54lQ
2018-07-24 03:29:42 +02:00
Xidorn Quan
b14b2beaad
style: Add new algorithm for setting property to be used in later commit.
Bug: 1473180
Reviewed-by: emilio
MozReview-Commit-ID: CdM8hDB6rFj
2018-07-24 03:29:28 +02:00
Xidorn Quan
d245f8b579
style: Introduce a concept of logical group.
Bug: 1473180
Reviewed-by: emilio
MozReview-Commit-ID: GXlf8JNML4N
2018-07-24 03:29:15 +02:00
Emilio Cobos Álvarez
08dcd7fca0
style: Remove IS_STYLE_IF_VISITED.
Bug: 1474959
Reviewed-by: xidorn
MozReview-Commit-ID: 8rnlaMOJisA
2018-07-24 03:29:03 +02:00
Emilio Cobos Álvarez
4e1606bfaf
style: Push visited style computation a bit further down.
Bug: 1474959
Reviewed-by: xidorn
MozReview-Commit-ID: 1DILenWIw4D
2018-07-24 03:28:50 +02:00
Emilio Cobos Álvarez
45435a57e9
style: Cleanup might_need_transitions_update.
Thought I had to update this as well, but nope. When basically any style changes
we already update transitions.

needs_transitions_update already handles the physical mapping changing by
checking whether any transition for the physical property remain there or not.

Bug: 1309752
Reviewed-by: birtles
MozReview-Commit-ID: 6vKwal4yzRU
2018-07-24 03:28:36 +02:00
Emilio Cobos Álvarez
856e5d1db6
style: Update animations if the logical to physical property mapping changes.
Bug: 1309752
Reviewed-by: birtles
MozReview-Commit-ID: 1lbOcniojVO
2018-07-24 03:28:23 +02:00
Emilio Cobos Álvarez
5504cbdfd7
style: Animate logical properties.
The setup is that AnimationValue only contains physical properties, and
we physicalize when building keyframes and transitions.

Bug: 1309752
Reviewed-by: birtles
MozReview-Commit-ID: 9dI20N0LFrk
2018-07-24 03:28:10 +02:00
Emilio Cobos Álvarez
be9acba801
style: Introduce PropertyDeclaration::to_physical.
Bug: 1309752
Reviewed-by: heycam
MozReview-Commit-ID: FAL04K5G948
2018-07-24 03:27:56 +02:00
Bobby Holley
89880727ec
style: Use an acquire load for is_unique in servo_arc.
Fixes #21186

Bug: 1476445
Reviewed-by: Manishearth
Differential Revision: https://phabricator.services.mozilla.com/D2205
2018-07-24 03:27:08 +02:00
Sylvestre Ledru
498592ff61
style: autopep8
Bug: 1468273
Reviewed-by: ted
MozReview-Commit-ID: 8j8EU3E08GP
2018-07-24 03:26:12 +02:00
bors-servo
b539ae7fe5
Auto merge of #21219 - paavininanda:Update_the_image_data, r=jdm
Complete remaining algo update_the_image_data

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11416.

<!-- Either: -->
- [x] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21219)
<!-- Reviewable:end -->
2018-07-23 14:54:50 -04:00
Emilio Cobos Álvarez
39e647de06
script: Fix the logic for mutation observer attributes. 2018-07-23 19:28:29 +02:00
Emilio Cobos Álvarez
073629076f
script: Avoid useless string clones in mutation observer stuff. 2018-07-23 19:28:29 +02:00
Emilio Cobos Álvarez
e4f978e215
script: Queue a mutation record from CharacterData::append_data. 2018-07-23 19:06:22 +02:00
Connor Brewster
a2064cef28 Rustfmt the constellation 2018-07-21 15:03:23 -06:00
bors-servo
a97d8b99ef
Auto merge of #21048 - cbrewster:hash_change_history, r=asajeffrey
Track hash changes in session history

<!-- Please describe your changes on the following line: -->
Adds tracking of hash changes in the session history.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14970 fix #13437 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21048)
<!-- Reviewable:end -->
2018-07-21 14:39:25 -04:00
Connor Brewster
61442cce4b Track hash changes in session history
Notify history changed on pushState and scroll to frag
2018-07-21 12:38:51 -06:00
paavininanda
5b77926460 Step3,4,5 2018-07-21 15:13:43 +05:30
bors-servo
37a73d3bc0
Auto merge of #21213 - servo:android-wpt, r=nox+jgraham
Add some support for WPT tests in an Android emulator through WebDriver

This succeeds on my machine:

`./mach test-wpt --product servodriver --binary etc/run_in_headless_android_emulator.py --binary-arg servo-x86 --binary-arg target/i686-linux-android/release/servo.apk /_mozilla/mozilla/DOMParser.html`

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21213)
<!-- Reviewable:end -->
2018-07-20 18:53:23 -04:00
bors-servo
aa76909f55
Auto merge of #21215 - nupurbaghel:update_source_set, r=jdm
Implement step 5 of select_image_source

<!-- Please describe your changes on the following line: -->
This step is responsible for selecting an image source based on user agent's environment( closest value which is greater than user's pixel density)
In case of no device, maximum density source is selected.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11416

<!-- Either: -->
- [x] These changes do not require tests because tests are already present

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21215)
<!-- Reviewable:end -->
2018-07-20 17:25:14 -04:00
nupurbaghel
c881c2a0fb implement step 5 of select_image_source 2018-07-21 01:44:20 +05:30
Bastien Orivel
ba9cbd87fb Update parking_lot to 0.6 2018-07-20 00:44:08 +02:00
Simon Sapin
48f6e168d4 Fix a webdriver timeout during server start up
When sending a webdriver load URL command soon enough after starting Servo,
that command could time out with a logged warning:

```
constellation: Webdriver load for closed browsing context (0,2).
```

When `closed` in this case really meant not opened yet.
2018-07-19 18:07:33 +02:00
Simon Sapin
4acdb81197 WebDriver timeout settings are not optional.
Not setting one of them in a SetTimeouts requests should not remove it.
This fixes a panicking `unwrap()`.
2018-07-19 18:07:33 +02:00
bors-servo
48db1ed65e
Auto merge of #21207 - servo:webgl, r=emilio
Some WebGL drive-by fixes

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21207)
<!-- Reviewable:end -->
2018-07-19 09:38:21 -04:00
bors-servo
e57187305f
Auto merge of #21181 - nupurbaghel:update_source_set, r=jdm
Implement update source set & select image source

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11416 (github issue number if applicable).

- [x] These changes require tests but cannot be written until implementation of responsive images is complete

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21181)
<!-- Reviewable:end -->
2018-07-19 08:18:12 -04:00
Anthony Ramine
b64232d77b Invalidate all WebGLUniformLocation values on program relink 2018-07-19 11:34:04 +02:00
Anthony Ramine
8fabc6660a Correctly reset active uniforms on link 2018-07-19 11:34:04 +02:00
nupurbaghel
8d06da8afd implement update_source_set, select_image_source 2018-07-19 09:20:46 +05:30
Anthony Ramine
3e8c2d659a Implement gl.getUniform() 2018-07-18 21:37:41 +02:00
Anthony Ramine
20714bd08c Update to gleam 0.6 2018-07-18 18:31:51 +02:00
bors-servo
c45192614c
Auto merge of #21195 - servo:rustup, r=nox
Upgrade to rustc 1.29.0-nightly (1ecf6929d 2018-07-16)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21195)
<!-- Reviewable:end -->
2018-07-18 05:37:08 -04:00
Simon Sapin
3509bcb531 Upgrade to rustc 1.29.0-nightly (1ecf6929d 2018-07-16) 2018-07-18 11:25:30 +02:00
Simon Sapin
e397ca06d8 Avoid use of deprecated (and buggy) std::env::home_dir 2018-07-18 11:25:30 +02:00
Bastien Orivel
9e446971a8 Update euclid to 0.18 2018-07-18 09:27:24 +02:00
bors-servo
a69c117da2
Auto merge of #21187 - tigercosmos:fetch, r=jdm
Make fetch() API use same-origin credentials by default

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21146 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21187)
<!-- Reviewable:end -->
2018-07-16 22:46:30 -04:00
tigercosmos
af3741ab26 Make fetch() API use same-origin credentials by default 2018-07-17 10:28:24 +08:00
bors-servo
3003e6f897
Auto merge of #21184 - servo:webgl, r=jdm
Use active uniforms data to implement gl.uniform* checks

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21184)
<!-- Reviewable:end -->
2018-07-16 19:46:05 -04:00
Anthony Ramine
476640c3ab Use active uniforms data to implement gl.uniform* checks 2018-07-17 01:26:44 +02:00
Emilio Cobos Álvarez
5227c7572e
style: Gecko build fix for Servo PR #21156.
MozReview-Commit-ID: FbN0hiUGzYa
2018-07-16 19:44:31 +02:00