Commit graph

3143 commits

Author SHA1 Message Date
Keith Yeung
19294db6e5 Split ConstellationMsg into ScriptMsg and CompositorMsg 2015-11-16 23:10:53 -08:00
bors-servo
afe03870ce Auto merge of #8151 - jgraham:webdriver_sendkeys, r=jgraham
Implement support for WebDriver send keys command.

Supports sending keys to an element. The specification here is still
rather unfinished so the error handling and so on in this code will
need iteration as it becomes clearer what the expected behaviour is.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8151)
<!-- Reviewable:end -->
2015-11-17 11:02:50 +05:30
James Graham
09b9293b09 Implement support for WebDriver send keys command.
Supports sending keys to an element. The specification here is still
rather unfinished so the error handling and so on in this code will
need iteration as it becomes clearer what the expected behaviour is.
2015-11-16 22:48:26 +00:00
bors-servo
20d26853e1 Auto merge of #8548 - Ms2ger:unused-tna, r=pcwalton
Remove the unused arguments to hit_test and mouse_over.

I don't think this code is called when there is no document element, but I
added assertions to make sure we notice in case I was wrong.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8548)
<!-- Reviewable:end -->
2015-11-17 02:05:52 +05:30
bors-servo
db94fda10e Auto merge of #8545 - Ms2ger:AutoJoinScriptTask, r=pcwalton
Remove AutoJoinScriptTask.

I don't believe there is a case where it would make sense to drop the
ScriptReflow struct without joining the script thread. This approach should
be somewhat more robust, and avoids the code smell of a RAII guard in an
otherwise unused variable.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8545)
<!-- Reviewable:end -->
2015-11-17 01:18:45 +05:30
bors-servo
c1e6bc0714 Auto merge of #8538 - notriddle:github_resize, r=mbrubeck
Ignore `<meta name=viewport>` if `@viewport` is ignored

Fixes #8373

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8538)
<!-- Reviewable:end -->
2015-11-17 00:31:49 +05:30
Ms2ger
4e60412c6d Remove the unused arguments to hit_test and mouse_over.
I don't think this code is called when there is no document element, but I
added assertions to make sure we notice in case I was wrong.
2015-11-16 15:53:49 +01:00
Ms2ger
a2c08413dd Remove AutoJoinScriptTask.
I don't believe there is a case where it would make sense to drop the
ScriptReflow struct without joining the script thread. This approach should
be somewhat more robust, and avoids the code smell of a RAII guard in an
otherwise unused variable.
2015-11-16 12:41:25 +01:00
Michael Howell
987c9e63aa Ignore <meta name=viewport> if @viewport is.
Fixes #8373
2015-11-15 20:35:13 -07:00
bors-servo
b6f519cd0a Auto merge of #8533 - Ms2ger:legacy, r=nox
Remove the `legacy` module.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8533)
<!-- Reviewable:end -->
2015-11-15 19:13:13 +05:30
Ms2ger
f2be9eb735 Move the from_declaration to its only caller and remove the empty legacy module. 2015-11-15 13:57:22 +01:00
bors-servo
c722e0e6f4 Auto merge of #8527 - romankl:atom-slices, r=Ms2ger
Replace Atom::from_slice("sizes") with atom!("sizes")

This PR replaces all occurrences of Atom::from_slice("sizes") with atom!("sizes"). It also updates string_cache to v0.1.17 from 0.1.16.

Right now I've split the crate update and the replace in different commits - should I squash them?

Fixes #8488.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8527)
<!-- Reviewable:end -->
2015-11-15 18:26:33 +05:30
Ms2ger
9c1d678b1b Remove get_unsigned_integer_attribute. 2015-11-15 11:24:03 +01:00
Ms2ger
5417df6397 Introduce a get_colspan method on LayoutJS<Element>. 2015-11-15 11:16:17 +01:00
bors-servo
3ef0a9a79d Auto merge of #8526 - frewsxcv:parse-length, r=eefriedman
Fix parse_length 0 values, implement <hr> 'width'

Follow-up to https://github.com/servo/servo/issues/8424

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8526)
<!-- Reviewable:end -->
2015-11-15 03:30:46 +05:30
Corey Farwell
02a8e8dd16 Implement <hr> element 'width' attribute 2015-11-14 16:46:59 -05:00
Roman Klauke
0813ee7257 replace Atom::from_slice("sizes") with atom!(sizes")
Closes: #8488
2015-11-14 20:58:57 +01:00
bors-servo
7f076c628b Auto merge of #8449 - paulrouget:favicon, r=jdm
mozbrowsericonchange event (Browser API)

fixes #8347

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8449)
<!-- Reviewable:end -->
2015-11-14 19:54:03 +05:30
Paul Rouget
5263a4c4c9 [Browser API] implement mozbrowsericonchange event 2015-11-14 09:59:50 +01:00
Greg Guthe
e49d592fba Add DOM-related performance timing properties 2015-11-13 17:51:34 -05:00
bors-servo
f078f8fdf4 Auto merge of #8505 - frewsxcv:html-table-cell-element-bgcolor-idl-attribute, r=Ms2ger
Implement 'bgcolor' IDL attribute for 'HTMLTableCellElement'

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8505)
<!-- Reviewable:end -->
2015-11-13 15:07:53 +05:30
Corey Farwell
765ade6892 Implement 'bgcolor' IDL attribute for 'HTMLTableCellElement' 2015-11-13 00:47:20 -05:00
Corey Farwell
7b8d5bbb97 Prefer atoms over strs for string comparisons 2015-11-12 23:46:48 -05:00
bors-servo
ef74bf5d42 Auto merge of #8500 - frewsxcv:subpage, r=jdm
Consolidate 'subpage finding' script_task logic

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8500)
<!-- Reviewable:end -->
2015-11-13 08:52:18 +05:30
bors-servo
62acdd303b Auto merge of #8477 - asajeffrey:opaque-domstring, r=asajeffrey
Opaque DOMString

This patch makes DOMString an opaque wrapper round String (currently it's a transparent wrapper).

The changes are:

* Replacing DOMString(foo) by DOMString::from(foo).
* Replacing foo.0 by String::from(foo).
* Adding functions clear, push_str and extend for in-place mutation of DOMStrings.
* Replacing DOMString by String in other threads (devtools, storage and filereader).
* Making DOMString implement !Send.
* Removing the pub attribute from the contents of DOMString.

This enables experimenting with other string representations in the DOM.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8477)
<!-- Reviewable:end -->
2015-11-13 07:17:30 +05:30
bors-servo
e63b1e83d4 Auto merge of #8147 - nox:weakref, r=Ms2ger
Implement weak-referenceable JS-managed objects

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8147)
<!-- Reviewable:end -->
2015-11-13 06:22:40 +05:30
Alan Jeffrey
5db67b5981 Added in-place mutation to DOMString.
The methods which are currently implemented are the ones on String that are currently being used:
string.push_str(...), string.clear() and string.extend(...). We may want to revisit this API.
2015-11-12 17:53:01 -06:00
Alan Jeffrey
034769f280 Code generation uses DOMString::from("...") rather than DOMString("...".to_owned()). 2015-11-12 17:53:00 -06:00
Alan Jeffrey
84bde75b42 Replaced DOMString constructor by conversion functions.
Replaced DOMString(...) by DOMString::from(...).
Replaced ....0 by String::from(...).
Removed any uses of .to_owner() in DOMString::from("...").
2015-11-12 17:52:59 -06:00
Alan Jeffrey
cf340be758 Replaced DOMString by String in storage APIs. 2015-11-12 17:52:59 -06:00
Alan Jeffrey
582273eb07 Replaced DOMString by String in filereader. 2015-11-12 17:52:58 -06:00
Alan Jeffrey
5101506089 Replaced DOMString by String in devtools. 2015-11-12 17:52:58 -06:00
bors-servo
9eaa8e7b1f Auto merge of #8492 - jdm:e10s-timer-events, r=jdm
script: Make timer events e10s-safe.

Closes #8235.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8492)
<!-- Reviewable:end -->
2015-11-13 05:19:48 +05:30
bors-servo
1720595a85 Auto merge of #8479 - frewsxcv:domstring-default, r=Ms2ger
Implement Default trait for DOMString

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8479)
<!-- Reviewable:end -->
2015-11-13 04:51:32 +05:30
bors-servo
c44c73aa00 Auto merge of #8498 - nox:fix-variadic-and-default-arguments, r=jdm
Properly handle variadic arguments preceded by default values

I broke that in #8197.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8498)
<!-- Reviewable:end -->
2015-11-13 04:22:11 +05:30
Corey Farwell
607cb0eeb7 Consolidate 'subpage finding' script_task logic 2015-11-12 17:32:37 -05:00
Josh Matthews
2340583e56 Differentiate between error and non-error event handlers per the spec. 2015-11-12 16:21:24 -05:00
Anthony Ramine
d4ce25d07c Properly handle variadic arguments preceded by default values
I broke that in #8197.
2015-11-12 21:10:45 +01:00
bors-servo
b40882093a Auto merge of #8428 - Ms2ger:conversions, r=Manishearth
Update js.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8428)
<!-- Reviewable:end -->
2015-11-13 01:13:52 +05:30
Patrick Walton
1dc0d61c3c script: Make timer events e10s-safe.
Closes #8235.
2015-11-12 14:30:25 -05:00
bors-servo
4848e37e2e Auto merge of #7844 - Wafflespeanut:requests, r=jdm
Cancelable network requests!

fixes #4974

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7844)
<!-- Reviewable:end -->
2015-11-12 18:59:58 +05:30
bors-servo
743ca24819 Auto merge of #8481 - frewsxcv:iterablepage-iter, r=Ms2ger
Simplify IterablePage::find

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8481)
<!-- Reviewable:end -->
2015-11-12 18:29:12 +05:30
Anthony Ramine
72c67efe96 Introduce trait WeakReferenceable
This allows to take weak references of JS-managed DOM objects.
2015-11-12 12:51:50 +01:00
bors-servo
448c7fb2e6 Auto merge of #8482 - frewsxcv:no-mut, r=Ms2ger
Remove unnecessary '*_mut' methods

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8482)
<!-- Reviewable:end -->
2015-11-12 16:44:09 +05:30
Ms2ger
6d2ae85c1f Use the conversion traits from js. 2015-11-12 10:48:58 +01:00
Ms2ger
acb24e80b8 Use throw_type_error and throw_range_error from js. 2015-11-12 10:20:19 +01:00
Ravi Shankar
10f5584f78 Implement cancellation listener for cancelling network requests 2015-11-12 14:02:59 +05:30
Corey Farwell
bfc4ed4cac Cleanup PageIterator::next 2015-11-12 00:24:19 -05:00
Corey Farwell
1e6d95f750 Remove unnecessary '*_mut' methods 2015-11-12 00:12:39 -05:00
Corey Farwell
94f0478f51 Simplify IterablePage::find 2015-11-12 00:03:53 -05:00