Commit graph

208 commits

Author SHA1 Message Date
Corey Farwell
0ec2375cab Remove tidy blacklist for 'script/dom/bindings/*'
Recently, I found myself reading through the Python codegen scripts that
live in 'components/script/dom/bindings/*' and noticed that there were
many tidy violations: unnecessary semicolons, weird spacing, unused
variables, lack of license headers, etc. Considering these files are now
living in our tree and mostly maintained directly by contributors of
Servo (as opposed to being from upstream), I feel these files should not
be excluded from our normal tidy process. This commit removes the
blacklist on these files and fixes all tidy violations.

I added these subdirectories to the blacklist because they appear to be
maintained upstream somewhere else:

* "components/script/dom/bindings/codegen/parser/*",
* "components/script/dom/bindings/codegen/ply/*",

Also, I added a '# noqa' comment which tells us to ignore the
flake8 errors for that line. I chose to ignore this (instead of fixing
it) to make the work for this commit simpler for me.
2015-07-09 19:42:31 +09:00
James Graham
6797ac6b58 Improve |mach test|.
Make mach test work with wpt tests.
Allow specifying specific testsuites on the command line
Allow specifying paths to CSS tests on the command line
2015-07-01 12:14:23 +01:00
James Graham
f1641fde8f Update mach from gecko tree 2015-07-01 10:55:50 +01:00
Michael Tremel
bb426d3575 notify_darwin should trap import errors and provide the useful package name for the user to install. 2015-06-27 17:13:36 -07:00
Jesse Ruderman
e6dc0d06d6 Add space between sentences 2015-06-26 13:17:15 -07:00
Michael Wu
675267b782 Upgrade to SM 39 2015-06-19 18:42:48 -04:00
bors-servo
d6263c9b6e Auto merge of #6306 - metajack:shared-target-dir, r=mbrubeck
This speeds up `./mach build --dev` followed by `./mach build-cef` by
25%. When rust-lang/cargo#497 is fixed, this speedup will increase
dramatically.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6306)
<!-- Reviewable:end -->
2015-06-15 13:08:14 -06:00
Jack Moffitt
a0237085c6 Use Cargo's target directory sharing.
This speeds up `./mach build --dev` followed by `./mach build-cef` by a
large amount, and also speeds up other build combos found in our CI.
2015-06-15 11:48:47 -06:00
Francesc Bautista
c99f65c4dc Set 'mach test-ref' default render mode to cpu and added a cli argument to 'mach test' to be able to select the render-mode. 2015-06-13 23:16:29 +02:00
Matt Brubeck
4b5c43835b Handle non-zero return codes in mach run 2015-06-04 13:52:23 -07:00
Corey Farwell
848c57653c Add flake8 to the tidy process for Python files
Fixes #6236

Also included in this commit are the changes need to make flake8 pass
for the existing python file
2015-06-04 11:17:34 -04:00
Corey Farwell
ddc99190bb Pass release/dev arguments to command function for jQuery update 2015-06-03 18:45:08 -04:00
Corey Farwell
6c8c039409 Run tidy everything in the tree, remove directory whitelist
After #6268 merged, I found out that everything in the tree currently
passes the tidy checker.
2015-06-03 12:03:13 -04:00
bors-servo
9aa1d93282 Auto merge of #6268 - frewsxcv:tidy-python, r=jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6268)
<!-- Reviewable:end -->
2015-06-03 08:04:11 -05:00
bors-servo
2e93ae7f76 Auto merge of #6267 - brson:system-rust, r=SimonSapin
The existing code for setting up the environment assumes that
the directory layout containing rust and cargo conforms to the
one used by rust-installer's tarballs. This makes overriding
the system root awkward for simple cases where I want to test
my own build directly from the rust build directory. This
patch just adds a second path to PATH and LD_LIBRARY_PATH
to accomodate both disk layouts.

Conflicts:
	python/servo/command_base.py

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6267)
<!-- Reviewable:end -->
2015-06-03 01:54:00 -05:00
Corey Farwell
e3b71c65bf Fix tidy issues with Python files in python/ 2015-06-02 19:51:41 -04:00
Corey Farwell
c639a0cf49 Tidy files in the python/ directory 2015-06-02 19:30:44 -04:00
Brian Anderson
68d977c5f0 Support a system root with correct on-disk directory layout
The existing code for setting up the environment assumes that
the directory layout containing rust and cargo conforms to the
one used by rust-installer's tarballs. This makes overriding
the system root awkward for simple cases where I want to test
my own build directly from the rust build directory. This
patch just adds a second path to PATH and LD_LIBRARY_PATH
to accomodate both disk layouts.

Conflicts:
	python/servo/command_base.py
2015-06-02 16:11:02 -07:00
Corey Farwell
7137b0610c Remove trailing whitespace on Python files
Trailing whitespace was found using flake8

This is working towards making flake8 part of the tidy process: #6236
2015-06-02 11:29:54 -04:00
ringmaster101
c4b73e703a Ensure installed git version is above 1.8.1 [Bug #5637]
Versions of git before 1.8.1 do not support git submodule --recursive sync
This commit makes update_submodules() exit with an error message if the version is <1.8.1

https://github.com/servo/servo/issues/5637
2015-06-01 18:37:37 -04:00
bors-servo
713f18a58d Auto merge of #6201 - glennw:jquery-runner, r=metajack
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6201)
<!-- Reviewable:end -->
2015-05-31 21:20:57 -05:00
bors-servo
1d19338a93 Auto merge of #6232 - frewsxcv:update-submodules-dry, r=jdm
This might allow us to merge #5648

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6232)
<!-- Reviewable:end -->
2015-05-31 20:40:21 -05:00
bors-servo
ce3debbc82 Auto merge of #6234 - frewsxcv:patch-2, r=metajack
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6234)
<!-- Reviewable:end -->
2015-05-31 19:08:45 -05:00
Glenn Watson
be7ae0c732 Add jQuery test runner and mach integration. 2015-06-01 09:36:24 +10:00
Corey Farwell
7bddb1185f Remove unused imports in the Python files
Found using flake8
2015-05-31 19:15:32 -04:00
Corey Farwell
372ef7cd5b Clarify Python version checking conditional 2015-05-31 18:34:52 -04:00
Corey Farwell
9708a386fc DRY submodule updating by utilizing existing update-submodules command
This might allow us to merge #5648
2015-05-31 17:25:26 -04:00
Corey Farwell
8e3f4bba85 Reduce max line length from 150 to 120 characters
Part of https://github.com/servo/servo/issues/6041
2015-05-24 00:01:49 -04:00
r0e
3e10adfa01 corrected help text for cargo-update 2015-05-19 11:16:05 -07:00
r0e
b1f5fb0a6d forces user to update cargo packages individually 2015-05-18 17:28:15 -07:00
Matt Brubeck
4f65720f19 Make "mach run -d" an alias for "mach run --dev"
(And the same for `rr-record`.) For consistency with `mach build`.
2015-05-15 07:59:45 -07:00
Jinank Jain
8af4e10086 Fixed #6048 2015-05-14 21:52:23 +02:00
bors-servo
c0d8488b71 Auto merge of #6038 - mbrubeck:jinankjain-Bug#5933, r=mbrubeck
Require either `--dev` or `--release`, unless a default build.mode is set in `.servobuild`.  This is @jinankjain's patch from #5965, rebased onto master.  It is already reviewed, and only waiting for servo/saltfs#28 to be deployed.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6038)
<!-- Reviewable:end -->
2015-05-14 11:26:18 -05:00
Ms2ger
d84c3e7a30 Fix some overlong lines. 2015-05-14 13:26:13 +02:00
Andreas Tolfsen
b1d03dc460 build: native notifications on Mac OS
Also refactors the notification function to introduce some single
responsibility.
2015-05-13 18:11:31 +01:00
Jinank Jain
c98d55fe28 Add --dev option to mach build
Require either --dev or --release, unless a default build.mode is set
in .servobuild.  Fixes #5933.
2015-05-13 09:25:43 -07:00
andars
c160248717 Add mac support for build notifications
Closes #5582
2015-05-12 18:38:47 -07:00
bors-servo
3e69bf8cd2 Auto merge of #6023 - mbrubeck:dev-nop, r=larsbergstrom
This is part of #5965.  It needs to land before the rest of that PR, so we can land servo/saltfs#28 without breaking automated builds for other PRs. r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6023)
<!-- Reviewable:end -->
2015-05-12 15:39:11 -05:00
Matt Brubeck
2dc048116e Add a no-op --dev option to the mach build command.
This is part of #5965.  It needs to land before the rest of that PR, so we can
land servo/saltfs#28 without breaking automated builds for other PRs.
2015-05-12 11:32:08 -07:00
Matt Brubeck
041d527335 Fail the build if openssl.makefile fails 2015-05-06 09:59:18 -07:00
Duncan
007295de4a Suggest how to fix unstable WHATWG links in tidy.py
Fixes #5929
2015-05-05 19:37:27 +12:00
Manish Goregaokar
88d180cc8a fix typo 2015-04-30 19:35:21 +05:30
Dhananjay Nakrani
bed9fc101b Add more directories into './mach grep' command. 2015-04-25 10:47:41 -07:00
Dhananjay Nakrani
27943c0ea5 Add a './mach grep' command. [Issue #5838] 2015-04-25 10:06:49 -07:00
Matt Brubeck
79894f7ec5 Show a notification for all builds > 30 sec.
The 300 second threshold was originally from the Gecko/Firefox build system.
It doesn't fit Servo builds, which are shorter, and often hover right around
the 300 second mark (making the notification unpredictable).
2015-04-23 11:42:09 -07:00
bors-servo
5502b5147f Auto merge of #5784 - mbrubeck:ssl-static, r=larsbergstrom
Required by the latest version of the openssl-sys build script. Fixes #5145.

r? @larsbergstrom or @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5784)
<!-- Reviewable:end -->
2015-04-21 19:35:44 -05:00
Matt Brubeck
b4b828260c Set the OPENSSL_STATIC env var for Android builds
Required by the latest version of the openssl-sys build script. Fixes #5145.
2015-04-21 17:22:21 -07:00
bors-servo
f795440ee3 Auto merge of #5776 - servo:split-unit-tests, r=mbrubeck
Closes #5707. (Includes a rebase of it.)
Fixes #5688.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5776)
<!-- Reviewable:end -->
2015-04-21 14:06:22 -05:00
Simon Sapin
ce1f2bab7b Fix up the splitting of the unit tests crate.
Closes #5707. (Includes a rebase of it.)
Fixes #5688.
2015-04-21 20:22:10 +02:00
Prabhjyot Singh Sodhi
7b9c9e1453 Split up the unit tests crate 2015-04-21 20:05:53 +02:00