Commit graph

17187 commits

Author SHA1 Message Date
edunham
711bfe2860 start Tidy move 2016-04-13 15:56:16 -07:00
bors-servo
84f01d1d7b Auto merge of #10579 - notriddle:overflow_premature_clip, r=pcwalton
Propogate transformed clipping regions to nested flows.

Fixes #10559

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10579)
<!-- Reviewable:end -->
2016-04-14 03:32:33 +05:30
bors-servo
697300bb16 Auto merge of #10566 - xudifsd:error-result, r=Ms2ger
replace Fallible<()> with ErrorResult

Fixes #10541

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10566)
<!-- Reviewable:end -->
2016-04-14 02:51:48 +05:30
Alan Jeffrey
8c0fa01884 Added panic message to failures. 2016-04-13 16:09:48 -05:00
bors-servo
4f6331953e Auto merge of #10573 - jdm:xhrintermittent, r=Manishearth
Do not support XHR.responseXML in worker globals. Fixes #8931.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10573)
<!-- Reviewable:end -->
2016-04-14 02:11:26 +05:30
bors-servo
628c54948a Auto merge of #10489 - timvandermeij:constellation-debug-warn, r=jdm
Replace use of `debug!` by `warn!` in `constellation.rs`

Fixes #10483.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10489)
<!-- Reviewable:end -->
2016-04-14 00:50:05 +05:30
Michael Howell
3c2210c5fc Propogate transformed clipping regions to nested flows.
Fixes #10559
2016-04-13 11:50:50 -07:00
bors-servo
66c20b2ced Auto merge of #10557 - emilio:inline-block-max-width, r=pcwalton
layout: Take in account max and min inline size for inline fragments

Improves MDN.

r? @mbrubeck or @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10557)
<!-- Reviewable:end -->
2016-04-14 00:09:52 +05:30
Tim van der Meij
29e564b1f7 Replace use of debug! by warn! in constellation.rs
Fixes #10483.
2016-04-13 20:31:59 +02:00
bors-servo
efd6723442 Auto merge of #10563 - mskrzypkows:tidy_tests, r=mbrubeck
Test for check_spec function, for tidy.py  #9152

Additional test for tidy.py

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10563)
<!-- Reviewable:end -->
2016-04-13 23:28:41 +05:30
Josh Matthews
dd5e28e0e6 Do not support XHR.responseXML in worker globals. Fixes #8931. 2016-04-13 13:56:07 -04:00
bors-servo
d21ff2fa13 Auto merge of #10189 - KiChjang:cors-preflight-fetch, r=jdm
Implement CORS preflight fetch

Fixes #10145.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10189)
<!-- Reviewable:end -->
2016-04-13 21:28:25 +05:30
Keith Yeung
e42481d0e7 Implement CORS preflight fetch 2016-04-13 11:28:14 -04:00
bors-servo
d566f1c143 Auto merge of #10565 - saurvs:master, r=Ms2ger
Update to byteorder 0.5

Finishes https://github.com/servo/servo/issues/10437.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10565)
<!-- Reviewable:end -->
2016-04-13 20:27:50 +05:30
bors-servo
9053721a32 Auto merge of #10558 - frewsxcv:tr-SectionRowIndex, r=KiChjang
Implement `sectionRowIndex` property on `<tr>`.

Fixes https://github.com/servo/servo/issues/10509.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10558)
<!-- Reviewable:end -->
2016-04-13 19:33:26 +05:30
bors-servo
3ad1b9134f Auto merge of #10512 - KiChjang:base-element-attr, r=Ms2ger
Implement HTMLBaseElement attributes

The remaining test failure in `base_multiple.html` looks like there's a problem with the test itself (it does not have a `<base>` tag at all).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10512)
<!-- Reviewable:end -->
2016-04-13 18:51:42 +05:30
Keith Yeung
4a1eb47937 Implement HTMLBaseElement attributes 2016-04-13 08:57:17 -04:00
bors-servo
9954ee1334 Auto merge of #10564 - Ms2ger:url-clone, r=Manishearth
Remove a pointless Url clone.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10564)
<!-- Reviewable:end -->
2016-04-13 18:11:11 +05:30
bors-servo
0e953618d1 Auto merge of #10524 - mauricioc:keyword_values, r=SimonSapin
Add some Gecko-supported CSS keyword properties

I have added all properties that are marked with (exactly) PARSE_VALUES and H | K in [0] to properties.mako.rs, as part of #10408. A few questions and remarks:

* I created a SVG style struct. Should those properties be somewhere else instead?
* I did not know what to do with ime-mode (which lives in nsStyleUIReset), so I did not include it.
* Servo already has a -servo-overflow-clip-box property, while Gecko has overflow-clip-box. Should those be consolidated?
* There is a code comment (marked with XXX) about scroll-snap-type-y. Should I add a <%self:longhand> template tag for that, similar to the one in overflow-y?

I am getting error E0053 while trying to run "./mach build-geckolib -r" on master, and the bholley/stylo branch doesn't support the products keyword argument yet, so I haven't exactly checked this compiles properly. It doesn't add any new compilation errors before the E0053 one, though.

Let me know if some extra information (say, a table saying where each property went) would be useful in the review process. r? @bholley

[0] https://docs.google.com/spreadsheets/d/1pSw2SjNxXZAQ19SAuNKcs5u4S7Zkc1ebEOkSP4oITUQ/edit?pref=2&pli=1

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10524)
<!-- Reviewable:end -->
2016-04-13 17:31:12 +05:30
Di Xu
76f57efb58 replace Fallible<()> with ErrorResult 2016-04-13 19:56:52 +08:00
bors-servo
650e3502f6 Auto merge of #10562 - servo:gcc, r=Manishearth
Update gcc.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10562)
<!-- Reviewable:end -->
2016-04-13 16:49:59 +05:30
Saurav Sachidanand
647d9874c2 Update to byteorder 0.5 2016-04-13 16:36:02 +05:30
Ms2ger
b032a7894a Remove a pointless Url clone. 2016-04-13 12:45:21 +02:00
bors-servo
9b57d8d686 Auto merge of #8658 - jdm:origin2, r=Ms2ger+jdm
Implement origin concept and browsing contextless documents.

These pave the way for implementing other parts of specifications more thoroughly.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8658)
<!-- Reviewable:end -->
2016-04-13 16:09:38 +05:30
Maciej Skrzypkowski
13847a1131 Test for check_spec function, for tidy.py #9152 2016-04-13 12:18:13 +02:00
Josh Matthews
90454c279d Use origin when manipulating cookies. 2016-04-13 12:07:05 +02:00
Josh Matthews
fa42b452a0 Use origin for document.domain. 2016-04-13 12:07:04 +02:00
bors-servo
aec297565b Auto merge of #10554 - asajeffrey:fast-fail-handle-script-loaded-url-in-iframe, r=Ms2ger
Fast fail_handle_script_loaded_url_in_iframe_msg

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10554)
<!-- Reviewable:end -->
2016-04-13 15:23:51 +05:30
Ms2ger
73def51221 Update gcc. 2016-04-13 11:11:40 +02:00
Josh Matthews
a8233a135e Implement origin concept. 2016-04-13 10:37:55 +02:00
Emilio Cobos Álvarez
7712affd2c
layout: Minimal refactor in style_specified_intrinsic_inline_size to improve legibility. 2016-04-13 05:44:40 +02:00
Emilio Cobos Álvarez
3d4aa46bcf
layout: tests: Add tests for max/min inline block size
And update existing expectations
2016-04-13 05:44:27 +02:00
Corey Farwell
0ee9521848 Implement sectionRowIndex property on <tr>.
Fixes https://github.com/servo/servo/issues/10509.
2016-04-12 23:17:20 -04:00
Emilio Cobos Álvarez
3c105082b8
layout: take into account max and min inline size for canvas and images 2016-04-13 04:47:14 +02:00
Emilio Cobos Álvarez
8abefd7e5e
layout: Take in account max inline size for inline fragments 2016-04-13 04:47:14 +02:00
bors-servo
e8e354d5d3 Auto merge of #10497 - kaksmet:multiprocess-prefs, r=pcwalton
Share prefs to content processes

Without this `./mach run -b -- -M` would start fine but navigating to a site would fail with:

`thread 'ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }' panicked at 'assertion failed: mozbrowser_enabled()', /Users/ulf/Documents/Code/servo/components/script/dom/htmliframeelement.rs:163`

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10497)
<!-- Reviewable:end -->
2016-04-13 07:51:54 +05:30
bors-servo
7e63c1be63 Auto merge of #10486 - notriddle:overflow_premature_clip, r=pcwalton
Take transform:translate into account when computing clipping regions.

Note that this only works for translation; a more general fix would
require major changes to how display lists work.

Closes #10431?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10486)
<!-- Reviewable:end -->
2016-04-13 07:12:38 +05:30
bors-servo
bbcbd35095 Auto merge of #10546 - stjepang:fix-typo-in-jsrs, r=Ms2ger
Fix typo: `cannot not outlive` -> `cannot outlive`

A `Root` cannot outlive the `RootCollection` it is recorded in.
The docs were saying otherwise.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10546)
<!-- Reviewable:end -->
2016-04-13 06:30:59 +05:30
bors-servo
9fb5703c6d Auto merge of #10510 - frewsxcv:rowindex, r=KiChjang
Implement `rowIndex` property on `<tr>`.

Part of https://github.com/servo/servo/issues/10509.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10510)
<!-- Reviewable:end -->
2016-04-13 04:25:20 +05:30
Mauricio Collares
002b4af8b9 Add some Gecko-supported CSS keyword properties 2016-04-12 18:52:44 -03:00
Alan Jeffrey
6c5b2167f5 Fast-fail handle_script_loaded_url_in_iframe_msg (fixes #10416) 2016-04-12 16:43:28 -05:00
Michael Howell
6c9efbf383 Take transform:translate into account when computing clipping regions.
Note that this only works for translation; a more general fix would
require major changes to how display lists work.

Closes #10431?
2016-04-12 14:39:13 -07:00
bors-servo
155e4052d1 Auto merge of #10545 - amarant:unreachable-codegen, r=Ms2ger
remove unreachable code in codegen

code is unreachable after return, and identical to the upper block

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10545)
<!-- Reviewable:end -->
2016-04-13 03:05:33 +05:30
bors-servo
a4991f536c Auto merge of #10488 - perlun:remove-t-prefix-on-style-structs, r=SimonSapin
Removed the T prefix for the style traits

More work as described in #10185.

I am getting _extremely_ weird compile-time errors with this one, when it's trying to expand the `lazy_static!` macro. I think I'll need help getting that part sorted out. The rest should be pretty OK.

Anyone has ideas on how to resolve it?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10488)
<!-- Reviewable:end -->
2016-04-13 02:24:25 +05:30
bors-servo
421dcc92f0 Auto merge of #10538 - izgzhen:performance_timing, r=Ms2ger
Improve PerformanceTiming Interface

Solving https://github.com/servo/servo/issues/10428

- Fix timing precision in old `update_with_current_time`
- Correct time unit in `navigation_start`
- Add `LoadEventStart` and `LoadEventEnd` timing properties

There are still many properties left unimplemented. I tend to leave the for future PRs.

Welcome comments!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10538)
<!-- Reviewable:end -->
2016-04-13 01:45:10 +05:30
Per Lundberg
c7758a8ad8 Removed the T prefix for the style traits
More work as described in #10185.

The reason I upgraded lazy_static to 0.1.16 is because it fixes an issue with the Box name (std::boxed::Box was used in an unqualified name, which can cause name clashes when there is another type that exists with the same name).
2016-04-12 23:02:02 +03:00
bors-servo
85f4e58285 Auto merge of #10543 - jdm:imageload, r=jdm
Implement image request concept for HTMLImageElement. Implement HTMLI…

…mageElement.currentSrc.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10543)
<!-- Reviewable:end -->
2016-04-13 01:04:28 +05:30
Corey Farwell
23eb15c820 Implement rowIndex property on <tr>.
Part of https://github.com/servo/servo/issues/10509.
2016-04-12 14:58:17 -04:00
akhan7
90359b1cba Implement image request concept for HTMLImageElement. Implement HTMLImageElement.currentSrc. 2016-04-12 14:11:31 -04:00
bors-servo
ea97c89055 Auto merge of #9980 - yoava333:master, r=nox
Implement the table section IDL attributes for HTML tables

a pull request that solves #9769.
I fixed on review note, and couldn't reproduce the second one.

Fixes #10506.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9980)
<!-- Reviewable:end -->
2016-04-12 23:30:15 +05:30