Commit graph

10152 commits

Author SHA1 Message Date
Anthony Ramine
e8e7357e99 Fix CanvasGradient.addColorStop()
The argument should be a double.
2015-04-27 19:42:48 +02:00
bors-servo
8a4555cc53 Auto merge of #5870 - SimonSapin:border-collapse, r=SimonSapin
Fixes #5300, which it is a rebase of.

Known issues:

* Collapsed borders do not correctly affect the border-box of the table
  itself.

* The content widths of all cells in a column and the content height of
  all cells in a row is the same in this patch, but not in Gecko and
  WebKit.

* Corners are not painted well. The spec does not say what to do here.

* Column spans are not handled well. The spec does not say what to do
  here either.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5870)
<!-- Reviewable:end -->
2015-04-27 12:29:15 -05:00
bors-servo
5773b0bcdf Auto merge of #5866 - Ms2ger:wpt_20150427, r=jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5866)
<!-- Reviewable:end -->
2015-04-27 11:51:27 -05:00
Ms2ger
93b883e1db Update web-platform-tests to revision acdb8bf3e4714528b6b5f9ff038dc80ee4fb7dcf 2015-04-27 18:48:44 +02:00
Simon Sapin
11b3e3b775 Remove some usage of .as_slice(). 2015-04-27 17:38:37 +02:00
Patrick Walton
0b6f84e6a1 Tidy fix 2015-04-27 17:12:08 +02:00
Patrick Walton
4d46d257cd Address review comments 2015-04-27 17:12:08 +02:00
Patrick Walton
48299a53cb layout: Implement most of border-collapse per CSS 2.1 § 17.6.2.
Known issues:

* Collapsed borders do not correctly affect the border-box of the table
  itself.

* The content widths of all cells in a column and the content height of
  all cells in a row is the same in this patch, but not in Gecko and
  WebKit.

* Corners are not painted well. The spec does not say what to do here.

* Column spans are not handled well. The spec does not say what to do
  here either.
2015-04-27 17:12:07 +02:00
Peter
a270f3e39b Switched Element::Get_attributes to use a RootedVec instead of returning a Vec<Temporary>, fixes #5684 2015-04-27 10:04:54 -04:00
bors-servo
92359c7b9a Auto merge of #5850 - nox:nullary-callbacks, r=jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5850)
<!-- Reviewable:end -->
2015-04-27 08:42:42 -05:00
Anthony Ramine
16973624c8 Implement Body.bgColor and Document.bgColor 2015-04-27 15:28:37 +02:00
bors-servo
56105e9f2f Auto merge of #5865 - gfxmonk:implicit-submit, r=Manishearth
With submission-blocking rules from https://html.spec.whatwg.org/multipage/forms.html#implicit-submission.

I wasn't sure if/where it would be relevant to add new tests (I couldn't find any existing tests in wpt to enable), so just let me know if this needs tests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5865)
<!-- Reviewable:end -->
2015-04-27 08:05:25 -05:00
bors-servo
0cd0abb718 Auto merge of #5867 - Ms2ger:load-end, r=jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5867)
<!-- Reviewable:end -->
2015-04-27 07:28:33 -05:00
Ms2ger
5fd753fda2 Factor out a handle_parsing_complete function from ScriptTask::Load. 2015-04-27 13:18:56 +02:00
Anthony Ramine
34070b1348 Complete Document WebIDL interface 2015-04-27 13:05:56 +02:00
Tim Cuthbertson
69110297c9 Implement implicit form submission from input elements 2015-04-27 19:46:41 +10:00
bors-servo
b0ddd8149b Auto merge of #5862 - nox:mutnullableheap, r=jdm
This is useful for union types, in cases where we need MutNullableHeap&lt;NodeOrString&gt;.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5862)
<!-- Reviewable:end -->
2015-04-27 03:50:08 -05:00
Anthony Ramine
afafde5191 Change MutNullableJS<T> to MutNullableHeap<JS<T>> 2015-04-27 10:45:38 +02:00
bors-servo
21c38d0de8 Auto merge of #5424 - bdero:bdero/accept-header, r=jdm
The value of the header is: `text/html;q=0.9,*/*;q=0.8`

Closes #5399

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5424)
<!-- Reviewable:end -->
2015-04-26 22:13:30 -05:00
Brandon DeRosier
0a7a853a01 Add Accept header to HTTP loader
The value of the header is the same as that of Firefox 35.0.1:
`text/html, application/xhtml+xml, application/xml; q=0.9, */*; q=0.8`

Closes #5399
2015-04-26 22:39:23 -04:00
bors-servo
9f2ad9376e Auto merge of #5863 - ecoal95:webgl-refactor, r=jdm
GitHub doesn't allow me to reopen #5769, so I created this.

Sorry about the merge fail, my bad :/

cc/ @jdm @dmarcos

---

This PR uses customized GL context creation code, right now only working under Linux, so I expect the clearcolor test to fail on other platforms.

It addresses some other problems:

* Propagates context creation error to the top, returning null if not found.
* Uses GLContextAttributes, which will allow us to write WebGLContextAttributes easily.
* Doesn't allow a 2d context and a WebGL context coexist.
* Panics when resizing the context to larger dimensions (to be fixed soon, but better than blindly allowing it).
    Removes some unused dependencies

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5863)
<!-- Reviewable:end -->
2015-04-26 21:28:35 -05:00
ecoal95
79a5dae170 WebGL context hardware acceleration + error detection 2015-04-27 04:16:47 +02:00
bors-servo
ea00e949a4 Auto merge of #5860 - GlassAndOneHalf:remove-jstraceable, r=jdm
This PR solves Issue #5849.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5860)
<!-- Reviewable:end -->
2015-04-26 19:00:06 -05:00
Jacob Taylor-Hindle
be876b2124 Remove #[jstraceable] annotation for the RootedVec type [Issue #5849] 2015-04-27 00:19:22 +01:00
Ms2ger
e3440c8a59 Move bgcolor over to the new infrastructure.
Note that I call is_htmltabledatacellelement in
synthesize_presentational_hints_for_legacy_attributes, rather than
is_htmltablecellelement (which was used in
get_simple_color_attribute_for_layout), because that function was never called
for th elements.
2015-04-26 22:25:11 +02:00
bors-servo
56a7981c9c Auto merge of #5852 - nox:rm-unsafe-transmute, r=Ms2ger
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5852)
<!-- Reviewable:end -->
2015-04-26 14:40:31 -05:00
Anthony Ramine
4e7b9d319c Remove useless unsafe methods on LayoutJS<T> 2015-04-26 21:39:11 +02:00
Anthony Ramine
9369b616ce Remove useless unsafe methods on JS<T> 2015-04-26 21:39:09 +02:00
Ms2ger
582ee1c2b3 Create a new infrastructure for presentational hints. 2015-04-26 21:25:06 +02:00
Ms2ger
852d973a70 Sort imports in element.rs. 2015-04-26 19:28:09 +02:00
Anthony Ramine
d4f809f95e Fix generation of nullary callbacks 2015-04-26 16:49:43 +02:00
bors-servo
1389be3782 Auto merge of #5847 - Ms2ger:slice, r=SimonSapin
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5847)
<!-- Reviewable:end -->
2015-04-26 05:30:28 -05:00
Ms2ger
9185c3de79 Remove as_mut_slice() calls. 2015-04-26 11:09:03 +02:00
Ms2ger
a862479ca8 Remove as_slice() calls from script. 2015-04-26 10:52:55 +02:00
bors-servo
aef48baeb4 Auto merge of #5844 - pgonda:removing-poping-dispatch_event, r=Ms2ger
fixes for #5843 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5844)
<!-- Reviewable:end -->
2015-04-26 02:53:45 -05:00
Peter
d0f451c2e1 Removed unessary poping in dispatch_event, fixes #5843 2015-04-25 20:22:04 -04:00
bors-servo
ef536372cd Auto merge of #5842 - dhananjay92:i5838, r=Manishearth
Solves Issue #5838.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5842)
<!-- Reviewable:end -->
2015-04-25 12:50:19 -05:00
Dhananjay Nakrani
bed9fc101b Add more directories into './mach grep' command. 2015-04-25 10:47:41 -07:00
Dhananjay Nakrani
27943c0ea5 Add a './mach grep' command. [Issue #5838] 2015-04-25 10:06:49 -07:00
bors-servo
50eb08bcf7 Auto merge of #5841 - jdm:compositeopflaky, r=Ms2ger
...further investigation.

#5803 has been frustrating recently.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5841)
<!-- Reviewable:end -->
2015-04-25 09:45:04 -05:00
Josh Matthews
43ec47fa6e Disable canvas_compositing_globalcompositeoperation_001-ref.htm pending further investigation. 2015-04-25 10:34:09 -04:00
bors-servo
b22a6c8095 Auto merge of #5840 - Ms2ger:attrvalue-slice, r=SimonSapin
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5840)
<!-- Reviewable:end -->
2015-04-25 08:59:26 -05:00
Ms2ger
41cc0a939e Replace the Str implementation for AttrValue by a Deref implementation. 2015-04-25 15:24:27 +02:00
Ms2ger
4108af0c11 Introduce AttrValue::atom(). 2015-04-25 15:13:03 +02:00
bors-servo
1f9de5ee2c Auto merge of #5779 - nox:css-escape, r=Ms2ger
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5779)
<!-- Reviewable:end -->
2015-04-25 05:42:41 -05:00
Anthony Ramine
31a26fa384 Implement the CSS interface 2015-04-25 12:36:38 +02:00
Anthony Ramine
7e7b421db9 Fix generation of static JS methods
They now take a global argument.
2015-04-25 12:23:39 +02:00
bors-servo
f010c83313 Auto merge of #5836 - pcwalton:input-size, r=mbrubeck
HTML5 § 4.10.5.3.2 doesn't explicitly say to do this, but all other
browser engines seem to do it.

Improves the Google home page.

r? @mbrubeck
2015-04-24 20:06:41 -05:00
Patrick Walton
79336d21b5 style: Disregard the size attribute for input elements other than text
or password fields.

HTML5 § 4.10.5.3.2 doesn't explicitly say to do this, but all other
browser engines seem to do it.

Improves the Google home page.
2015-04-24 17:33:53 -07:00
bors-servo
211ee668fa Auto merge of #5816 - pcwalton:more-jumpiness, r=mbrubeck
Fixes the "jumpiness" seen on the Google home page, Wikipedia, and many
other places.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5816)
<!-- Reviewable:end -->
2015-04-24 15:17:07 -05:00