Commit graph

5232 commits

Author SHA1 Message Date
bors-servo
08f53acd09 auto merge of #2068 : mbrubeck/servo/1187-buffer-destroy, r=larsbergstrom
This fixes a potential pixmap leak and task failure when the LayerBuffer is dropped (#1187).

I wasn't able to reproduce the failure using the steps from #1187, but based on the stack trace I think this is the correct fix.  Alternately, would it make sense to `impl Drop for LayerBuffer`?
2014-04-10 09:55:38 -04:00
Ms2ger
6c32a7f05f Remove getWrapTemplateForType and simplify wrapForType. 2014-04-10 13:08:54 +02:00
Ms2ger
8c4a3aa387 Use ToJSValConvertible for all conversions to JSVal. 2014-04-10 12:09:18 +02:00
Ms2ger
a3d13c35a2 Remove the IElement trait. 2014-04-10 10:27:32 +02:00
Josh Matthews
6388dec996 Add overridable tree binding/unbinding behaviour. 2014-04-10 10:27:32 +02:00
Josh Matthews
f5d1907195 Integrate Element's after_set/remove behaviour into the virtual method hierarchy. 2014-04-10 10:27:32 +02:00
Josh Matthews
ca6cfb5bca Add support for trait-based virtual methods on Nodes, and use it for before_remove_attr and after_set_attr. 2014-04-10 10:27:28 +02:00
Ms2ger
0dfbfa0b07 Fix HTMLElementDerived::is_htmlelement to take non-HTML elements into account. 2014-04-10 10:06:14 +02:00
Matt Brubeck
3231f12708 Don't reuse an old pipeline for a new root layer
When navigating to a new URL, we need to make sure compositor messages go to
the new page's pipeline, not the previous one.
2014-04-09 20:09:08 -07:00
Matt Brubeck
9c3875ead5 Remove unused create_layer_group_for_pipeline 2014-04-09 20:09:08 -07:00
Ms2ger
ea2560ef20 Rename before_remove_attr and after_set_attr to allow reusing those names in the next commit. 2014-04-09 23:55:45 +02:00
Matt Brubeck
d6dec803fd Clear tiles before dropping CompositorLayer
This fixes a pixmap leak and task failure (#2069).
2014-04-09 11:43:35 -07:00
bors-servo
d7f450dbd7 auto merge of #2045 : Manishearth/servo/pub-struct-2044, r=SimonSapin
See #2044
2014-04-09 10:40:26 -04:00
bors-servo
69fbbbdf33 auto merge of #2076 : Ms2ger/servo/find_fragment_node, r=Ms2ger
This was part of @jdm's vtable branch, but I think it makes sense regardless of how we deal with that branch.
2014-04-09 09:28:19 -04:00
Josh Matthews
14b85e0e60 Make find_fragment_node a method of Page. 2014-04-09 15:20:17 +02:00
hyunjunekim
5c15f24308 inline pseudo element 2014-04-09 09:00:32 +09:00
Matt Brubeck
efb1ccb07e Destroy LayerBuffers before dropping them
This should fix a potential pixmap leak and task failure when the LayerBuffer
is dropped (#1187).
2014-04-08 14:34:36 -07:00
bors-servo
b9a7949ce4 auto merge of #2067 : saneyuki/servo/id, r=Ms2ger
Follow up #1917
(Derived from #2066)
2014-04-08 14:55:01 -04:00
bors-servo
165950d021 auto merge of #2060 : Ms2ger/servo/attributes-rewrite, r=jdm
There's more that I'd like to do, but this can land already.
2014-04-08 14:25:03 -04:00
Tetsuharu OHZEKI
25e6366efc Remove the needless comment for document.getElementById. 2014-04-09 03:20:47 +09:00
Ms2ger
ed18e4c948 Merge Attr::new_ns and Attr::new. 2014-04-08 20:17:15 +02:00
Ms2ger
d665ad5a17 Reimplement SetAttributeNS. 2014-04-08 20:17:15 +02:00
Ms2ger
bf73a47ce0 Reimplement SetAttribute. 2014-04-08 20:17:15 +02:00
Ms2ger
883d67882a Move SetAttributeNS onto JS<Element>. 2014-04-08 20:16:55 +02:00
Ms2ger
b19165e9e1 Move SetAttribute onto JS<Element>. 2014-04-08 20:16:55 +02:00
Ms2ger
3347c3ef80 Split out a do_set_attribute method. 2014-04-08 20:16:55 +02:00
bors-servo
6b1799caa3 auto merge of #2063 : lpy/servo/issue2059, r=Ms2ger
see #2059
2014-04-08 11:37:09 -04:00
bors-servo
aa36ae62cd auto merge of #2058 : jdm/servo/rmcrust, r=Ms2ger 2014-04-08 11:13:12 -04:00
bors-servo
51ff762bc5 auto merge of #1917 : lpy/servo/issue1822, r=jdm
see #1822
2014-04-08 10:49:14 -04:00
bors-servo
384183a31f auto merge of #2040 : SimonSapin/servo/fontconfig-compile, r=jdm
This of course depends on https://github.com/mozilla-servo/fontconfig/pull/1 being merged.
2014-04-08 10:25:18 -04:00
Josh Matthews
b87d351fee Remove all traces of C wrappers for SpiderMonkey class stubs. 2014-04-08 10:15:12 -04:00
lpy
77941dc996 Move Node.namespaceURI to Element.(fixes #2059) 2014-04-08 22:13:28 +08:00
bors-servo
c02328bea1 auto merge of #2062 : j3parker/servo/issue346-reftest, r=jdm
ref-test for #346
2014-04-08 10:01:24 -04:00
lpy
50aea70f98 Make sure getElementById always returns the first element with the given ID in tree order.(fixes #1822) 2014-04-08 12:21:58 +08:00
Jacob Parker
62227009b0 Add reftest for setAttribute restyling 2014-04-07 23:18:13 -04:00
Sankha Narayan Guria
58e5feca9f HTMLImageElement attribute getters and setters 2014-04-08 08:44:38 +05:30
bors-servo
7541b57526 auto merge of #2051 : Ms2ger/servo/more-xray, r=jdm
On top of #2050
2014-04-07 13:01:16 -04:00
bors-servo
a65ff6089a auto merge of #2048 : Ms2ger/servo/set_uint_attribute, r=jdm 2014-04-07 12:34:18 -04:00
bors-servo
f9c9e62340 auto merge of #2053 : Ms2ger/servo/createElementNS, r=jdm
#1391 rebased
2014-04-07 11:43:22 -04:00
bors-servo
3d1a4324b7 auto merge of #2057 : Ms2ger/servo/evaluate_script, r=jdm 2014-04-07 11:19:26 -04:00
Ms2ger
9ada80e4c0 Handle an exception from cx.evaluate_script more gracefully. 2014-04-07 17:05:59 +02:00
bors-servo
bf405ac81f auto merge of #2055 : Ms2ger/servo/trws, r=jdm
Done with `git ls-tree --name-only -r HEAD . | grep "\.rs" | xargs sed -i 's/\s\+$//g'`
2014-04-07 10:52:26 -04:00
Ms2ger
4e34fcd264 Remove trailing whitespace. 2014-04-07 11:41:58 +02:00
Daniel Glazman
4b0da08573 Implement Document.createElementNS. 2014-04-07 10:20:10 +02:00
Ms2ger
2e2a39b8d5 Remove some more xray code. 2014-04-06 23:08:54 +02:00
bors-servo
86c83f7bfc auto merge of #2050 : sankha93/servo/rmxray, r=Ms2ger 2014-04-06 17:04:26 -04:00
Sankha Narayan Guria
9a4bec304f Remove XRay related stuff from codegen (fixes #1936) 2014-04-07 02:27:53 +05:30
bors-servo
68385dfde6 auto merge of #2049 : Ms2ger/servo/enum-jsval, r=jdm 2014-04-06 15:31:30 -04:00
Ms2ger
a52cffebeb Use ToJSValConvertible to convert nullable enums to JSVal. 2014-04-06 19:51:12 +02:00
Ms2ger
ccaa46e4a3 Use ToJSValConvertible to convert enums to JSVal. 2014-04-06 19:42:39 +02:00