Commit graph

5232 commits

Author SHA1 Message Date
bors-servo
d99e69e244 auto merge of #1012 : deokjinkim/servo/glyph_advance_cache, r=ILyoan
#1008 has unnecessary code change. So I want to revert this code.
2013-10-06 21:16:05 -07:00
bors-servo
f353150bca auto merge of #1020 : SimonSapin/servo/external-UA-css, r=jdm
Oops, I broke the UA stylesheet in #1017. The fact that our tests still passed is not a good sign :/
2013-10-06 20:37:07 -07:00
Simon Sapin
e45482b825 Fix UA stylesheet: remove Rust string escaping 2013-10-06 15:01:40 +02:00
Ms2ger
179582d939 Remove unnecessary mutability. 2013-10-06 09:15:38 +02:00
Ms2ger
17796725f4 Address review comments. 2013-10-06 09:02:12 +02:00
bors-servo
6832f4feec auto merge of #1017 : SimonSapin/servo/external-UA-css, r=jdm
… as suggested in https://github.com/mozilla/servo/pull/1015#issuecomment-25755957

Also add a comment on the `border-width` work-around.
2013-10-05 16:46:04 -07:00
Simon Sapin
8df49c1c1d Move the User-Agent styleesheet to a CSS file instead of a Rust string.
… as suggested in
https://github.com/mozilla/servo/pull/1015#issuecomment-25755957

Also add a comment on the `border-width` work-around.
2013-10-05 23:56:43 +02:00
Ms2ger
c93d13b0da Don't require passing a root element to Document::new (needed for issue #888). 2013-10-05 21:42:13 +02:00
Huon Wilson
451519b6ff Use str.char_offset_iter instead of manually calling str.char_range_at. 2013-10-04 22:26:36 +10:00
bors-servo
f13438d012 auto merge of #1011 : metajack/servo/summit-demos, r=larsbergstrom
summit2.html is a two pane demo of rust logo and matrix math.

summit3.html is a three pane demo adding longcat.

summit-fail.html is thw two pane demo with failing page on the right.
2013-10-03 23:24:47 -07:00
Jack Moffitt
4f04efa380 Add summit demos.
summit2.html is a two pane demo of rust logo and matrix math.

summit3.html is a three pane demo adding longcat.

summit-fail.html is thw two pane demo with failing page on the right.
2013-10-04 00:16:48 -06:00
Deokjin Kim
6aa9104907 Revert unnecessary code change 2013-10-04 14:49:28 +09:00
bors-servo
5d59c00575 auto merge of #1008 : deokjinkim/servo/glyph_advance_cache, r=jdm
To reduce number of FT_Load_Glyph call, use glyph advance cache.
2013-10-03 02:45:49 -07:00
Deokjin Kim
70578e6350 Remove cast::transmute 2013-10-03 14:39:57 +09:00
Deokjin Kim
7716c2bc2f Fix strange indentation 2013-10-03 11:47:04 +09:00
Deokjin Kim
46776e1974 Add glyph advance cache to enhance speed of layout 2013-10-03 09:23:55 +09:00
bors-servo
d6d2534b56 auto merge of #1001 : SimonSapin/servo/newnewcss, r=kmcallister
Add selector matching, style structs, cascading. The matching is quite naive and has many low hanging fruits for optimization. No pseudo-class (except `:not()`) is implemented yet, but those are easy to add as needed.

Next step is to update the layout code to use this and drop netsurf-css.

(Most of the +7066 lines stat is for bootstrap.css, added as a test.)
2013-10-02 12:21:53 -07:00
bors-servo
096af85834 auto merge of #1005 : jdm/servo/failfixes, r=metajack
Fixes #1004. I haven't seen the other ones be reported, but I saw often saw `task <unnamed> failed at 'RenderChan.send: render port closed', /home/jdm/sdb/servo/src/components/gfx/render_task.rs:76`, `task <unnamed> failed at 'receiving on closed channel', /home/jdm/sdb/servo/src/compiler/rust/src/libstd/rt/comm.rs:487`, and failed assertions due to layout running after we had begun tearing down the window.
2013-10-01 23:54:50 -07:00
Josh Matthews
499935b77e Silence occasional task failure that occurs from sending to the render task after it's shut down. 2013-10-02 01:43:21 -04:00
Josh Matthews
bc81716c30 Make proxy finalizers retrieve the DOM object from the right slot. 2013-10-02 01:43:14 -04:00
Josh Matthews
92f6599854 Wait for any layout tasks to complete in a page tree before a handling a pipeline's exit message. 2013-10-02 01:43:08 -04:00
Simon Sapin
284770aa02 Selector matching: tweak variable naming, add comments. 2013-10-02 01:37:03 +01:00
Simon Sapin
02364d7db7 Sorting on specificity needs to be stable for correctness of the cascade. 2013-10-02 01:19:36 +01:00
Simon Sapin
a04e96b7c6 Fix missing license header. 2013-10-02 00:31:57 +01:00
Simon Sapin
20089e4bea New style sytsem: add selector matching
Also make scribt::dom::element::Element::get_attr ASCII case-insensitive
on attribute names, per spec:
http://dom.spec.whatwg.org/#dom-element-getattribute
2013-10-02 00:28:14 +01:00
bors-servo
be5deb2a68 auto merge of #1002 : brson/servo/scriptthread, r=jdm
This appears to fix the problem with the Rust logo stopping during the demo.

Though this is the right way to spawn a SpiderMonkey thread, I'm not entirely sure why this fixes the problem in all scenarios. With enough threads (i.e. `RUST_THREADS=32`), and running with some Rust patches that are available on master (which I applied during testing), I would expect work stealing to not allow starvation here. In my tests though I see the problem even with lots of threads, so this may yet indicate a scheduler bug. Still, SpiderMonkey should get its own thread.
2013-10-01 15:52:41 -07:00
Brian Anderson
38ea00074c Run script in its own thread to avoid starving other tasks 2013-10-01 15:43:45 -07:00
bors-servo
5fc5542590 auto merge of #998 : jdm/servo/tracehook, r=metajack
Needs https://github.com/mozilla-servo/rust-mozjs/pull/38 and https://github.com/mozilla-servo/mozjs/pull/6. Fixes #819. Fixes #962.
2013-09-30 23:27:47 -07:00
Josh Matthews
cb826f9920 Make proxy bindings generate trace and finalization hooks. 2013-09-30 22:14:27 -04:00
bors-servo
74c3859548 auto merge of #996 : kmcallister/servo/azure-skia-fixes, r=larsbergstrom
Fixes #979.
2013-09-30 12:30:10 -07:00
Keegan McAllister
0f758b3d80 Fix crashes and leaks in Azure and Skia
Fixes #979.
2013-09-30 11:57:39 -07:00
bors-servo
1e4e8d5224 auto merge of #995 : jdm/servo/demoborders, r=larsbergstrom
Fixes #993.
2013-09-30 11:53:19 -07:00
Josh Matthews
2a0ec06bf3 Make borders show up on summit.html 2013-09-30 14:45:44 -04:00
Simon Sapin
226ccf7e72 Merge commit '25d6448f28' 2013-09-30 19:21:27 +01:00
Simon Sapin
25d6448f28 Fix SimonSapin/servo-style#2: failed assertion in selector parsing.
Add a test: "parse bootstrap.css without failing"
2013-09-30 17:46:18 +01:00
bors-servo
a3bad43e8a auto merge of #978 : ryanhc/servo/renderbox-cache, r=metajack 2013-09-25 20:06:42 -07:00
Ryan Choi
9fa389938c Update submodule 2013-09-26 11:42:15 +09:00
Ryan Choi
9a3a6f2829 Cache font-style and text-decoration to speed up can_merge_with_box() 2013-09-25 15:50:38 +09:00
bors-servo
c246188605 auto merge of #826 : metajack/servo/android-darwin, r=jdm
This cleans up configure and Makefile.in so that things build correctly on Darwin.

This needs https://github.com/mozilla-servo/nss/pull/6 before it can be merged. Please hold any r+ until that lands and I push the submodule update.
2013-09-24 13:09:40 -07:00
bors-servo
b7d186dec2 auto merge of #977 : kmcallister/servo/redirect, r=jdm 2013-09-24 12:45:44 -07:00
bors-servo
401176b72d auto merge of #966 : tikue/servo/master, r=metajack
Fixes #967 and #965 

This has been wrong for a long time. Previously, only the pipeline associated with the root frame evicted would be shut down. 1) It shouldn't necessarily be closed, because there could be references to it still in the navigation context, and 2) Presumably none of the children pipelines of the root frame were ever exiting.

It's hard to test this right now because #965 covers up other pipeline exiting issues, but when that's fixed, a pathological case in which things would have broken down would be:

1) Load a page with an iframe that contains a link
2) Click the link
3) Press backspace to navigate back
4) Navigate to any new page, at which point the forward page would be evicted from the navigation context, and the outer frame's pipeline would be shut down improperly.
5) Press backspace, at which point there is no longer a pipeline for the old page, because it was shut down prematurely. Presumably this would cause a crash.

I also changed the FrameTree function ```find_mut``` to ```find``` because find_mut implies it's doing something to cause mutability, but the mutability is caused by the type of object being iterated over, nothing else.

Additionally, script was exiting completely when receiving an exit message. Instead, it needs to handle exit messages according to who sent it. It should only close the subframes of the frame whose pipeline sent the exit message. This is now fixed.

Inexplicably, script was also closing the compositor upon receiving an exit message. This doesn't seem like it'd ever be the right thing to do. *Edit: this is _only_ the right thing to do when received from the window.* I've fixed that. I don't think anyone shuts down the compositor now. *Edit: the script shuts down the compositor only when receiving an exit from the window.*
2013-09-23 21:24:42 -07:00
Tim Kuehn
103cd6255d split script_task::ExitMsg into WindowExitMsg and PipelineExitMsg 2013-09-24 00:15:35 -04:00
Tim Kuehn
99f125bb64 script task only exits when the root pipeline exits 2013-09-24 00:03:52 -04:00
Tim Kuehn
c56b015623 find_mut ==> find. it's only mut because of the data type iterated over 2013-09-24 00:03:51 -04:00
Tim Kuehn
d77a07388f exit the correct evicted pipelines 2013-09-24 00:03:51 -04:00
Keegan McAllister
1c6de361b7 Handle HTTP 3xx redirects
Fixes #973.
2013-09-23 14:50:50 -07:00
Keegan McAllister
9bd0e2a3ac Remove an unneeded helper function 2013-09-23 14:50:50 -07:00
Keegan McAllister
69473b6c9c Make some debug prints more useful 2013-09-23 14:50:50 -07:00
bors-servo
d6769de467 auto merge of #972 : metajack/servo/parbuild-bugs, r=kmcallister
This fixes several makefile issues around parallel builds as well as some general cleanup.
2013-09-23 11:27:43 -07:00
Jack Moffitt
7ee000f613 Make rust submodules depend on rust. 2013-09-23 10:40:34 -06:00