Commit graph

4748 commits

Author SHA1 Message Date
Prabhjyot Singh Sodhi
849ee8fbdf removing unnecessary clones 2015-09-01 08:38:42 +05:30
bors-servo
dee6283483 Auto merge of #7474 - notriddle:master, r=pcwalton
Inline constraint resolver for absolutely positioned tables.

Fixes #7425.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7474)
<!-- Reviewable:end -->
2015-08-31 20:35:06 -06:00
bors-servo
a4d5c8ce4a Auto merge of #7448 - meh:servo-reexport, r=jdm
Re-export crates needed to use the Servo Rust API

This helps out on using the Servo API from a Rust project.

Right now I have to explicitly declare all the crates contained in `components` to use them.

Unsure about re-exporting `euclid`, `url` and `layers`, but they are required to use the API and it helps out avoiding version-collisions if you happen to use the wrong version in your own project.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7448)
<!-- Reviewable:end -->
2015-08-31 19:45:20 -06:00
Eli Friedman
5215b51b55 Simplify reflection usage in Actor code.
The fixed version is shorter, and doesn't use unstable features.
2015-08-31 18:45:07 -07:00
Corey Farwell
3a1d140ab5 Enforce linking to spec for method implementations via macros 2015-08-31 21:02:23 -04:00
bors-servo
23d1416cc2 Auto merge of #7470 - psdh:flexflow, r=pcwalton
implemented a pass-through mark_as_root for FlexFlow

Fixes #7467

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7470)
<!-- Reviewable:end -->
2015-08-31 18:28:14 -06:00
Patrick Walton
e835fb6514 gfx: Make some minor formatting cleanups. 2015-08-31 16:50:57 -07:00
Patrick Walton
b66f17a445 layout: Make overflow calculation take relative percentages into
account.

This necessitated changing overflow to be calculated by the parent flow
if relatively positioned children are present. That is because the
overflow regions cannot be calculated without knowing relative offsets,
which themselves cannot be calculated without knowing the parent size
(because of percentages). To accomplish this without sacrificing
parallelism in the non-relative case, this patch splits overflow into
"early" and "late" computation. Late overflow computation cannot be
parallelized across children, while early overflow computation can.

Makes the "Apple Music" text show up over the full-bleed promotional
background on apple.com.
2015-08-31 16:50:56 -07:00
Michael Howell
36759338c7 Inline constraint resolver for absolutely positioned tables.
Fixes #7425.
2015-08-31 16:45:17 -07:00
Glenn Watson
f1aed3b231 Update glutin to get android build fix 2015-09-01 08:46:10 +10:00
bors-servo
afc2c381db Auto merge of #7370 - bjwbell:bugfix-unequal-borders, r=pcwalton
gfx: Border radius support for asymmetric sized borders

When the border-top/right/bottom/left-widths are not equal, the angle on the border corner arc separating the borders isn't PI/4. 

For instance if the top border width is much larger than the left border width then most of the border corner should be drawn using the top border color.

This change adds support for calculating the correct angle in the border
corner arc for switching from one border to another e.g. the left border
to the top border.

It supports elliptical border radii for when elliptical border radii are
added.

A ref test is also included.

r? @Ms2ger 

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7370)
<!-- Reviewable:end -->
2015-08-31 14:58:33 -06:00
Bryan Bell
d539b9b2e6 gfx: Border radius support for asymmetric borders
This change adds support for calculating the correct angle in the border
corner arc when switching from one border to another e.g. the left border
to the top border.

When the border-top/right/bottom/left-widths are not the same, the angle on
the border corner arc separating the borders isn't pi/4.

For example, if the top border width is much larger than the left border
width then most of the border corner should be drawn using the top
border color.

Elliptical border radii are supported for when elliptical border radii are
added.

The common case where borders have the same width sets the angle to
pi/4 directly.

A ref test is also included.
2015-08-31 13:02:05 -07:00
bors-servo
60c72f601c Auto merge of #7475 - wilmoz:checkBracesSpaces, r=jdm
Make test-tidy check that braces have spaces before or after them

https://github.com/servo/servo/issues/7413
Posible future/past bug fixed in components/script/timers.rs

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7475)
<!-- Reviewable:end -->
2015-08-31 13:18:23 -06:00
bors-servo
108251bece Auto merge of #7434 - mbrubeck:drop-table, r=pcwalton
Remove unused font shaping code and flags

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7434)
<!-- Reviewable:end -->
2015-08-31 12:20:49 -06:00
wilmoz
64ac4f175f Make test-tidy check that braces have spaces before or after them 2015-08-31 12:30:55 -05:00
Avi Weinstock
fd4147fe7c Prevent ClipboardContext::new from panicing on OSX if NSPasteboard#generalPasteboard fails (https://github.com/servo/servo/issues/7380). 2015-08-31 08:29:43 -04:00
bors-servo
fea36ceb9a Auto merge of #7466 - nox:rootedvec-from-iter, r=Ms2ger
Implement FromIterator<Root<A>> for RootedVec<JS<A>> (fixes #5117)



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7466)
<!-- Reviewable:end -->
2015-08-31 03:02:05 -06:00
bors-servo
1093f6bdcf Auto merge of #7463 - nox:css-ch, r=SimonSapin
Implement the ch unit as 0.5em



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7463)
<!-- Reviewable:end -->
2015-08-31 02:19:55 -06:00
Anthony Ramine
5cc36f0b91 Implement FromIterator<Root<A>> for RootedVec<JS<A>> (fixes #5117) 2015-08-31 10:11:29 +02:00
Prabhjyot Singh Sodhi
976c7e0411 implemented a pass-through mark_as_root for FlexFlow 2015-08-31 12:56:29 +05:30
bors-servo
7dda183022 Auto merge of #7139 - samfoo:testable-net-load, r=jdm
Testable net load...

*The goal of this PR is to get early feedback on this before I go too far down the rabbit hole. This new code path is working, and there's several tests I've written as a proof of concept. There are still some regressions that I'll be fixing in the coming days.*

I've abstracted out the request/response cycle so that it's no longer dependent on the Hyper request/response structs. Since request/response @ hyper are structs, not traits, it made mocking them for tests impossible.

Current issues/concerns:

* This relies on boxing the `HttpResponse` that gets returned from the `HttpRequester` because `HttpResponse` is unsized. I don't know if there's a more idiomatic rust-y way of doing this?
* This relies on boxing the `Read` that is now returned from `load` for the same reason.
* The devtools and resource manager channels are still passed into `load`. It might be easier to inject these as trait dependencies instead of chans as well?
* Needs more tests.

🎩 

#6727

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7139)
<!-- Reviewable:end -->
2015-08-30 20:07:40 -06:00
Sam Gibson
43e0c4ac89 Prevents unwrapping invalid location url domains 2015-08-31 13:47:35 +12:00
meh
bfcaf7ef1a Re-export crates needed to use the Servo Rust API 2015-08-31 00:15:29 +02:00
Sam Gibson
9d0f418ee0 Resolves merge conflict without wonky cloning 2015-08-31 08:54:12 +12:00
Anthony Ramine
8ab6bea0f3 Implement the ch unit as 0.5em 2015-08-30 22:39:12 +02:00
bors-servo
86da67bb1e Auto merge of #7407 - nox:childnodes-replace, r=jdm
Optimise most basic case of .replaceChild() when updating childNodes



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7407)
<!-- Reviewable:end -->
2015-08-30 13:22:41 -06:00
bors-servo
347e9b6ef4 Auto merge of #7228 - nox:urlutils-setters, r=jdm
Implement setters in URLUtils

This fixes #6145 and takes care of most of #4250.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7228)
<!-- Reviewable:end -->
2015-08-30 12:40:53 -06:00
Anthony Ramine
9c4766bb0d Implement setters in URLUtils 2015-08-30 19:47:33 +02:00
bors-servo
a855669d4f Auto merge of #7455 - nox:rm-unused-warnings, r=jdm
Do not allow some warnings in codegen anymore

This fixes #395.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7455)
<!-- Reviewable:end -->
2015-08-30 11:37:04 -06:00
bors-servo
3062e0c7b1 Auto merge of #7445 - JoshTheGoldfish:Issue6934, r=Manishearth
Issue #6934 - Implement onerror event handler for AbstractWorker

Please review.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7445)
<!-- Reviewable:end -->
2015-08-30 10:19:15 -06:00
erneyja
8d4ed7292d Implemented onerror event handler for AbstractWorker 2015-08-30 11:37:16 -04:00
bors-servo
79328c11e3 Auto merge of #7442 - ecoal95:shader-validation, r=jdm
Add WebGL shader validation and translation

r? @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7442)
<!-- Reviewable:end -->
2015-08-30 09:29:42 -06:00
Anthony Ramine
cf6975f2a3 Do not allow unreachable_code in codegen anymore 2015-08-30 17:25:05 +02:00
Anthony Ramine
3c1c315838 Do not allow dead_code in codegen anymore 2015-08-30 17:19:42 +02:00
Anthony Ramine
2c8638ea9e Do not allow unused_parens in codegen anymore 2015-08-30 17:16:15 +02:00
Anthony Ramine
1064e7decc Do not allow unused_mut in codegen anymore 2015-08-30 16:53:35 +02:00
Anthony Ramine
aaa7a86381 Do not allow unused_unsafe in codegen anymore 2015-08-30 16:53:20 +02:00
bors-servo
940bcadc13 Auto merge of #7432 - jdm:dashedprops, r=nox
Add dashed CSS properties in CSSStyleDeclaration



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7432)
<!-- Reviewable:end -->
2015-08-30 08:20:57 -06:00
Anthony Ramine
51418fc348 Replace many uses of Attr::Value() by Attr::value()
The later only borrows the attribute, without copying its value as a string.
2015-08-30 15:30:01 +02:00
Anthony Ramine
105d990845 Replace many uses of to_ascii_lowercase() by make_ascii_lowercase() 2015-08-30 15:30:00 +02:00
bors-servo
89a5e2b3d0 Auto merge of #7433 - frewsxcv:formdata-get, r=nox
Cleanup, refactor FormDataMethods::Get



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7433)
<!-- Reviewable:end -->
2015-08-30 07:00:33 -06:00
ecoal95
167885707d webgl: Add shader validation and translation
This commit adds angle-based validation and translation to WebGL
shaders.

The changes to the tex_image_2d test is neccessary (it was not valid
GLES 2.0 shader language).
2015-08-30 14:23:14 +02:00
Simon Martin
5301e59965 Issue #7393: Properly sniff mislabeled feeds. 2015-08-30 13:03:20 +02:00
Sam Gibson
4b6f07cbe6 Resolves strange borrow/type checking issues from new thread naming 2015-08-30 12:23:50 +10:00
Sam Gibson
f257b5fcef Adds content-length to empty-bodied non-GET/HEAD requests 2015-08-30 12:14:15 +10:00
Sam Gibson
667b563f2e Renames LoadResponse 2015-08-30 12:14:13 +10:00
Sam Gibson
a1fd235347 Moves devtools request msg logic to where the request is sent 2015-08-30 12:14:12 +10:00
Sam Gibson
3b8bada5a1 Fixes code review nits 2015-08-30 12:14:12 +10:00
Sam Gibson
04c012dfbf Binds name instead of inlining value for readability 2015-08-30 12:14:11 +10:00
Sam Gibson
918f8a7760 Removes unnecessary clone 2015-08-30 12:14:11 +10:00