Commit graph

17922 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
e50d4b7624
codegen: Throw on an invalid enum value when appropiate 2016-05-13 11:44:38 +02:00
Emilio Cobos Álvarez
093f5c01e4
codegen: add tests for non-nullable non-required values 2016-05-13 09:42:59 +02:00
Emilio Cobos Álvarez
92ba0b9c39
codegen: Don't unconditionally set non-required dictionary attributes 2016-05-13 09:42:51 +02:00
David Zbarsky
2bf016ff14 Implement GetVertexAttrib 2016-05-12 23:56:10 -07:00
David Zbarsky
2f416baa11 Implement ReadPixels 2016-05-12 23:50:36 -07:00
bors-servo
03465ad8c7 Auto merge of #11079 - Zaggy1024:label-cursor, r=pcwalton
Changed cursor for labels to "default" so their text doesn't use the text cursor.

The cursor in Firefox and Chrome for labels is always the default cursor rather than changing to the text cursor on text. In Edge, however, this only applies to the text of the actual label element.

This PR changes Servo to match Firefox and Chrome.

A convenient example of an element that this style applies to (and has different behavior between Firefox and Edge) is the "This repository" label for the search input at the top on Github.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11079)
<!-- Reviewable:end -->
2016-05-12 19:45:38 -07:00
bors-servo
2e049a8533 Auto merge of #11166 - emilio:fontcache-exit, r=mbrubeck
gfx: Add expect messages to FontCacheThread::exit()

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they only add debug info.

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

One of these two unwraps is the one that is causing most occurrences
of #8815.

I'd go with removing the second unwrap entirely, but let's get some
debug info first, since it might probably be a race.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11166)
<!-- Reviewable:end -->
2016-05-12 16:39:03 -07:00
Emilio Cobos Álvarez
f6434a9790
gfx: Add expect messages to FontCacheThread::exit()
One of these two unwraps is the one that is causing most occurrences
of #8815.

I'd go with removing the second unwrap entirely, but let's get some
debug info first, since it might probably be a race.
2016-05-13 01:15:35 +02:00
bors-servo
1e8ddba3e8 Auto merge of #11159 - mbrubeck:test-warnings, r=emilio
Fix warnings in unit tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11159)
<!-- Reviewable:end -->
2016-05-12 13:12:44 -07:00
Matt Brubeck
96c69f852c Fix warnings in unit tests 2016-05-12 12:22:00 -07:00
Emilio Cobos Álvarez
f893a2eaac
bindings: Add test for keywords in dictionaries 2016-05-12 20:39:31 +02:00
bors-servo
c2beb55c0f Auto merge of #11160 - bholley:zero_gecko_struct, r=mbrubeck
Only use zeroed memory for gecko style structs, not the wrapper servo struct.

So that we don't clobber the drop flags.

This is a regression from #11121.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11160)
<!-- Reviewable:end -->
2016-05-12 11:36:42 -07:00
bors-servo
e927057478 Auto merge of #11157 - mbrubeck:cef-warnings, r=metajack
Fix unused extern crate warnings in build-cef

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11157)
<!-- Reviewable:end -->
2016-05-12 10:53:10 -07:00
Bobby Holley
f68cdd3679 Only use zeroed memory for gecko style structs, not the wrapper servo struct, so that we don't clobber the drop flags.
This is a regression from #11121.
2016-05-12 10:35:49 -07:00
bors-servo
fe3821ff14 Auto merge of #11154 - nox:zealot, r=Ms2ger
Support GC zeal

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11154)
<!-- Reviewable:end -->
2016-05-12 09:42:21 -07:00
Matt Brubeck
83a4658cb4 Fix unused extern crate warnings in build-cef 2016-05-12 09:03:52 -07:00
bors-servo
42141870e7 Auto merge of #10714 - KiChjang:user-interaction-task, r=Ms2ger
Implement user interaction task source

Part of #7959.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10714)
<!-- Reviewable:end -->
2016-05-12 09:00:14 -07:00
bors-servo
9189b9ee63 Auto merge of #11156 - larsbergstrom:more_codegen_units_removal, r=mbrubeck
Remove codegen-units from cef

r? @mbrubeck @metajack

Should fix regression in #11123 that caused build-cef to rebuild again.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11156)
<!-- Reviewable:end -->
2016-05-12 08:18:03 -07:00
Anthony Ramine
afd29b7c1e Support GC zeal 2016-05-12 16:44:40 +02:00
Lars Bergstrom
e5f42776a7 Remove codegen-units from cef 2016-05-12 09:44:09 -05:00
Keith Yeung
f60de52aae Fire 'select' event in SetSelectionRange 2016-05-12 10:44:04 -04:00
bors-servo
bca625bd8e Auto merge of #11006 - ConnorGBrewster:history_events, r=asajeffrey
Implement navigation events

fixes #11005

Events:
 * `PopStateEvent`
 * `HashChangeEvent`
 * `PageTransitionEvent`

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11006)
<!-- Reviewable:end -->
2016-05-12 07:27:12 -07:00
Emilio Cobos Álvarez
203898c941
codegen: Use the non-mangled name in set_dictionary_property
Fixes #11152
2016-05-12 15:39:54 +02:00
bors-servo
d55884d73e Auto merge of #11148 - mbrubeck:warnings, r=metajack
Fix some warnings

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11148)
<!-- Reviewable:end -->
2016-05-12 06:19:10 -07:00
bors-servo
9eb7162b8a Auto merge of #11146 - mbrubeck:always-be-updating, r=metajack
Update image, hyper, gleam, flate2, threadpool, string_cache, num_cpus

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11146)
<!-- Reviewable:end -->
2016-05-12 05:28:12 -07:00
bors-servo
ef3c4102cf Auto merge of #11141 - asajeffrey:reword-pr-template, r=jdm
Reworded some of PULL_REQUEST_TEMPLATE.md

Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are just the PR template

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11141)
<!-- Reviewable:end -->
2016-05-12 04:37:39 -07:00
bors-servo
1a834b5b83 Auto merge of #11140 - asajeffrey:webdriver-pipeline-wait-for-document-ready, r=jgraham
When webdriver is getting a pipeline id, it should wait for the pipeline document to be ready

Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11117 (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only impact webdriver

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11140)
<!-- Reviewable:end -->
2016-05-12 03:46:59 -07:00
bors-servo
4a274cf580 Auto merge of #11142 - kaksmet:another-justify-fix, r=mbrubeck
Fix inline size adjustment when stripping trailing whitespace from fragments

The whitespace range was not properly shifted which caused us to adjust the fragment's inline size by the advance of a different set of characters.
This was causing justified text lines to be too long or too short.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11142)
<!-- Reviewable:end -->
2016-05-12 02:56:21 -07:00
bors-servo
695a2559a8 Auto merge of #11132 - mbrubeck:workqueue-panic, r=larsbergstrom
Fix integer overflow in next_power_of_two

This causes a panic (debug) or incorrect results (release) when initializing a work queue with thread_count = 1.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11132)
<!-- Reviewable:end -->
2016-05-12 00:35:05 -07:00
bors-servo
e2a5b1cb71 Auto merge of #11129 - KiChjang:fetch-read-block, r=jdm
Use read_block in http_network_fetch

Previously the commented out code was not working because there was a deadlock situation where `res_body` is being locked and borrowed to read the inner `body` if it is a `ResponseBody::Receiving` variant, and then locked and borrowed mutably to change `res_body` to `ResponseBody::Done`.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11129)
<!-- Reviewable:end -->
2016-05-11 23:44:15 -07:00
bors-servo
f12869d2a7 Auto merge of #11127 - heycam:text-align, r=bholley
Support text-align in geckolib.

We don't yet support the 'unsafe' keyword, which isn't in a spec yet, and which would require slightly more complex parsing.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11127)
<!-- Reviewable:end -->
2016-05-11 22:53:56 -07:00
bors-servo
cf2b9401ef Auto merge of #11123 - larsbergstrom:disable_codgen_units, r=pcwalton
Disable codegen-units due to performance regressions

r? @pcwalton

Fixes #11102.

CC @alexcrichton, @nmatsakis - basically, `codegen-units` is nice for local compilation speedups but results in too many perf regressions to keep it for release builds.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11123)
<!-- Reviewable:end -->
2016-05-11 22:03:36 -07:00
Connor Brewster
11dd0d7c46 add popstateevent, hashchangeevent, pagetransitionevent 2016-05-11 22:11:46 -06:00
Matt Brubeck
d560ae79b4 Fix some warnings 2016-05-11 21:03:12 -07:00
bors-servo
685dc99e3e Auto merge of #11044 - ConnorGBrewster:page_to_browsing_context, r=jdm
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
2016-05-11 20:53:02 -07:00
Matt Brubeck
d54f489c33 Update image, hyper, gleam, flate2, threadpool, string_cache, num_cpus 2016-05-11 20:37:27 -07:00
bors-servo
641b374f0b Auto merge of #10953 - KiChjang:text-plain-encoding, r=jdm
Implement text/plain form encoding

Fixes #3649.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10953)
<!-- Reviewable:end -->
2016-05-11 19:43:37 -07:00
Keith Yeung
5e078870a2 Add test for encoding text/plain in forms 2016-05-11 22:06:43 -04:00
bors-servo
545da3844a Auto merge of #10903 - broesamle:issue10877-HTMLAnchorElement-setter-panic, r=jdm
Avoid panics when using HTMLAnchorElement attribute setters

`expected: OK` still explicitly mentioned in .ini file. Shall I remove it?

Fixes #10877.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10903)
<!-- Reviewable:end -->
2016-05-11 19:03:56 -07:00
bors-servo
f8b7e1c6ae Auto merge of #11143 - metajack:ccache-skia-azure, r=mbrubeck
Update skia and azure to get ccache support

Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they change only compilation

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11143)
<!-- Reviewable:end -->
2016-05-11 18:22:46 -07:00
Keith Yeung
d1c0af9ae7 Implement text/plain form encoding 2016-05-11 21:17:31 -04:00
Keith Yeung
0f172491d3 Add picking of encoding for url encoded data 2016-05-11 21:17:31 -04:00
Keith Yeung
9be649f8ed Rename encode_form_data to encode_multipart_form_data 2016-05-11 21:17:31 -04:00
bors-servo
d4315855aa Auto merge of #10995 - rzambre:master, r=larsbergstrom
Interval + CSV time-profiling

This PR fixes #10886. The -p option can be followed by either an interval number or a CSV filename.
* In the interval profiling, the profiler output would be spitted out to the terminal periodically.
Example usage: **./mach run -p 1 http://www.google.com** will print the time-profiling output to the terminal every second.

* In the CSV file profiling, a CSV file will be generate upon termination of servo.
Example usage: **./mach run -x -o out.png -p out.csv http://www.google.com** will generate out.csv upon termination of Servo.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10995)
<!-- Reviewable:end -->
2016-05-11 17:19:53 -07:00
bors-servo
8c2c0bd964 Auto merge of #10713 - aeischeid:master, r=jdm
add tidy test for space after ":" in stucts

Addresses issue #10702

the tidy self-test doesn't seem to catch the `member_name:"Foo"` line like it should. the regex follows similar pattern in the file and works in my regex tester tool, so not really sure what is going on there.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10713)
<!-- Reviewable:end -->
2016-05-11 16:27:37 -07:00
Cameron McCormack
b3a1f5f071 Support text-align in geckolib.
We don't yet support the 'unsafe' keyword, which isn't in a spec yet, and which
would require slightly more complex parsing.
2016-05-12 09:17:27 +10:00
Jack Moffitt
0a7bd57d7b Update skia and azure to get ccache support 2016-05-11 16:10:18 -06:00
bors-servo
49fd06089d Auto merge of #11121 - bholley:hoist_bindings, r=mbrubeck
Hoist gecko bindings into their own crate

This will be helpful for leveraging the bindings with our nsIAtom-backed
string_cache replacement.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11121)
<!-- Reviewable:end -->
2016-05-11 14:59:04 -07:00
Ulf Nilsson
c8db7da36a Fix inline size adjustment when stripping trailing whitespace from fragments
The whitespace range was not properly shifted which caused us to adjust the fragment's inline size by the advance of a different set of characters.
This was causing justified text lines to be too long or too short.
2016-05-11 23:52:33 +02:00
Bobby Holley
d6a6f2c7e0 Hoist gecko bindings into their own crate.
This will be helpful for leveraging the bindings with our nsIAtom-backed
string_cache replacement.
2016-05-11 14:32:26 -07:00