Changed cursor for labels to "default" so their text doesn't use the text cursor.
The cursor in Firefox and Chrome for labels is always the default cursor rather than changing to the text cursor on text. In Edge, however, this only applies to the text of the actual label element.
This PR changes Servo to match Firefox and Chrome.
A convenient example of an element that this style applies to (and has different behavior between Firefox and Edge) is the "This repository" label for the search input at the top on Github.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11079)
<!-- Reviewable:end -->
gfx: Add expect messages to FontCacheThread::exit()
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they only add debug info.
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
One of these two unwraps is the one that is causing most occurrences
of #8815.
I'd go with removing the second unwrap entirely, but let's get some
debug info first, since it might probably be a race.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11166)
<!-- Reviewable:end -->
One of these two unwraps is the one that is causing most occurrences
of #8815.
I'd go with removing the second unwrap entirely, but let's get some
debug info first, since it might probably be a race.
Only use zeroed memory for gecko style structs, not the wrapper servo struct.
So that we don't clobber the drop flags.
This is a regression from #11121.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11160)
<!-- Reviewable:end -->
Reworded some of PULL_REQUEST_TEMPLATE.md
Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are just the PR template
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
r? @jdm
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11141)
<!-- Reviewable:end -->
When webdriver is getting a pipeline id, it should wait for the pipeline document to be ready
Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix#11117 (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only impact webdriver
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11140)
<!-- Reviewable:end -->
Fix inline size adjustment when stripping trailing whitespace from fragments
The whitespace range was not properly shifted which caused us to adjust the fragment's inline size by the advance of a different set of characters.
This was causing justified text lines to be too long or too short.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11142)
<!-- Reviewable:end -->
Fix integer overflow in next_power_of_two
This causes a panic (debug) or incorrect results (release) when initializing a work queue with thread_count = 1.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11132)
<!-- Reviewable:end -->
Use read_block in http_network_fetch
Previously the commented out code was not working because there was a deadlock situation where `res_body` is being locked and borrowed to read the inner `body` if it is a `ResponseBody::Receiving` variant, and then locked and borrowed mutably to change `res_body` to `ResponseBody::Done`.
r? @jdm
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11129)
<!-- Reviewable:end -->
Support text-align in geckolib.
We don't yet support the 'unsafe' keyword, which isn't in a spec yet, and which would require slightly more complex parsing.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11127)
<!-- Reviewable:end -->
Disable codegen-units due to performance regressions
r? @pcwalton
Fixes#11102.
CC @alexcrichton, @nmatsakis - basically, `codegen-units` is nice for local compilation speedups but results in too many perf regressions to keep it for release builds.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11123)
<!-- Reviewable:end -->
Combine Page into BrowsingContext
Fixes#11031.
`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.
This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.
r? @jdm
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
Update skia and azure to get ccache support
Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they change only compilation
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11143)
<!-- Reviewable:end -->
Interval + CSV time-profiling
This PR fixes#10886. The -p option can be followed by either an interval number or a CSV filename.
* In the interval profiling, the profiler output would be spitted out to the terminal periodically.
Example usage: **./mach run -p 1 http://www.google.com** will print the time-profiling output to the terminal every second.
* In the CSV file profiling, a CSV file will be generate upon termination of servo.
Example usage: **./mach run -x -o out.png -p out.csv http://www.google.com** will generate out.csv upon termination of Servo.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10995)
<!-- Reviewable:end -->
add tidy test for space after ":" in stucts
Addresses issue #10702
the tidy self-test doesn't seem to catch the `member_name:"Foo"` line like it should. the regex follows similar pattern in the file and works in my regex tester tool, so not really sure what is going on there.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10713)
<!-- Reviewable:end -->
Hoist gecko bindings into their own crate
This will be helpful for leveraging the bindings with our nsIAtom-backed
string_cache replacement.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11121)
<!-- Reviewable:end -->
The whitespace range was not properly shifted which caused us to adjust the fragment's inline size by the advance of a different set of characters.
This was causing justified text lines to be too long or too short.