Commit graph

17569 commits

Author SHA1 Message Date
Simon Sapin
4e71b215b8 Add font-size absolute size keywords. Fix #3417.
Relative size keywords are still missing:
https://github.com/servo/servo/issues/3423
2014-09-19 19:04:31 +01:00
Josh Matthews
6d6726178a Merge pull request #3253 from ChrisParis/TreeWalker
Implement TreeWalker
2014-09-19 10:54:26 -04:00
Josh Matthews
f139eb5176 Merge pull request #3401 from pcwalton/refactor-layout
layout: Remove `layout/extra.rs`.
2014-09-19 10:51:02 -04:00
Josh Matthews
b82c0dced0 Merge pull request #3172 from jdm/devtools
Dump initial prototype of devtools server into the build. Expect lies if...
2014-09-19 09:15:03 -04:00
Simon Sapin
010d87b93e Remove min/max functions from util::geometry. Use std::cmp instead. 2014-09-19 13:56:35 +01:00
Simon Sapin
415bbaeb2e Fix dimensionality of Au
Previously, we implemented:

Au * Au -> Au
Au / Au -> Au
Au % Au -> Au

... which are inconsistent. It should be:

Au * Au -> SquaredAu
Au / Au -> i32
Au % Au -> i32

or:

Au * i32 -> Au
Au / i32 -> Au
Au % i32 -> Au

I picked the latter.

Also, the multiplicative identity does not make sense
when multiplication take two different types.
2014-09-19 13:54:57 +01:00
Glenn Watson
818f70e319 Fix img with display: block. Fixes text/image overflow on wikipedia.
Ref: #2554
2014-09-19 17:59:48 +10:00
glennw
a3b20d8179 Merge pull request #3421 from glennw/table-padding
Fix padding on tables. This fixes the TOC on wikipedia pages.
2014-09-19 17:50:50 +10:00
Cameron Zwarich
d7ffe7a198 Merge pull request #3416 from zwarich/remove-jsref-mut
Remove uses of &mut JSRef
2014-09-18 22:25:48 -07:00
Glenn Watson
fd176d5387 Fix padding on tables. This fixes the TOC on wikipedia pages.
Ref: #2554
2014-09-19 14:58:24 +10:00
Glenn Watson
0d0d2365aa Adds support for table layout trace and updates viewer for tables. 2014-09-19 14:48:53 +10:00
Cameron Zwarich
176b3f7698 Remove uses of &mut JSRef
Since everything with JSRef happens with interior mutability, it doesn't
make any sense to use an &mut JSRef.
2014-09-18 15:30:38 -07:00
Matt Brubeck
f35941d91d Fix line splitting in white-space: pre flows
The newline position from one line was getting used repeatedly, causing extra
"phantom" newlines in the following lines.  Fixes #3413.
2014-09-18 14:25:12 -07:00
Chris Paris
92638a6fe6 Implement TreeWalker 2014-09-18 11:13:33 -10:00
Josh Matthews
fae7ce3c1d Retrieve some basic layout properties for nodes to make the box model somewhat useful. 2014-09-18 15:07:11 -04:00
Josh Matthews
fa57fe890b Enable real DOM inspector support. 2014-09-18 15:06:40 -04:00
Josh Matthews
e9c4aa534d Implement wire protocol support for DOM inspector. 2014-09-18 15:06:40 -04:00
Josh Matthews
c31e2f928d Avoid selecting on the devtools port if no devtools server exists. 2014-09-18 15:06:40 -04:00
Josh Matthews
bb9955c281 Split devtools implementation into sensible modules. 2014-09-18 15:06:40 -04:00
Josh Matthews
cdb4037ca2 Enable executing JS snippets in the context of the main Servo window and viewing the responses from the Firefox remote console. 2014-09-18 15:06:40 -04:00
Josh Matthews
f0f7e98dfa Dump initial prototype of devtools server into the build. Expect lies if you try to use it for anything real. 2014-09-18 15:06:40 -04:00
Patrick Walton
f5c0124363 layout: Remove layout/extra.rs.
Also, rename a few methods in layout that arguably had confusing names.
2014-09-18 11:33:04 -07:00
Patrick Walton
5e5f77a354 Try to unbreak the build by removing unused import 2014-09-18 10:56:58 -07:00
Clark Gaebel
670ca9894e Fixed #3386. 2014-09-18 09:20:23 -07:00
Clark Gaebel
1b251db732 Merge pull request #3379 from cgaebel/bucketed-timing
Added more complex profiling metadata.
2014-09-18 09:12:34 -07:00
Patrick Walton
22bca83509 Merge pull request #3404 from glennw/inline-block-fix
Include margin in inline block intrinsic width. Fixes [edit] links on wikipedia. Also improves google homepage.
2014-09-18 07:51:11 -07:00
Josh Matthews
9607b468bc Revert "script: Use atom comparison in more places, especially for attributes." for persistent test failures.
This reverts commit 874db26104.
2014-09-18 09:20:19 -04:00
Glenn Watson
6bc65f3b07 Include margin in inline block intrinsic width. Fixes [edit] links on wikipedia. 2014-09-18 16:07:28 +10:00
Matt Brubeck
8aeb90e8c3 Merge pull request #3395 from mbrubeck/doctest
Fix unit test failures. r=jdm
2014-09-17 17:05:29 -07:00
Josh Matthews
75caade828 Merge pull request #3358 from jdm/thespicemustnotreflow
Delay initiating layout operations for as long as possible.
2014-09-17 19:09:31 -04:00
Clark Gaebel
6bc63d47cd Added more complex profiling metadata. 2014-09-17 15:41:27 -07:00
Matt Brubeck
140b0007fd Update style unit tests to use atoms
Fixes test bustage from #3316.
2014-09-17 14:49:04 -07:00
Matt Brubeck
a939cc50bb Fix doctest errors in rustdoc comments
Mostly this disables doctest for comments that are not actually tests.
2014-09-17 14:46:37 -07:00
Patrick Walton
874db26104 script: Use atom comparison in more places, especially for attributes.
75% improvement in style recalc for Guardians of the Galaxy.
2014-09-17 13:17:12 -07:00
Josh Matthews
61642d64b5 Merge pull request #3387 from prasoon2211/base64_methods_for_worker
Implement atob and btoa methods for worker
2014-09-17 11:46:20 -04:00
Patrick Walton
ee2b4e208f build: Update string-cache to fix a nasty race 2014-09-17 08:20:54 -07:00
Manish Goregaokar
11ba79894a Merge pull request #3374 from Manishearth/lint_unrooted_jsmanaged
Add lint for ensuring proper rooting of JS<T>; r=jdm
2014-09-17 18:17:19 +05:30
Prasoon Shukla
e0f2c9edc1 Fix for issue #3238
Moved the Atob and Btoa methods ouside the impl for WorkerMethod trait
and made them publicly accessible from WorkerGlobalScopeMethods via
proxy methods.
2014-09-17 12:27:01 +05:30
Josh Matthews
4a1d51b982 Merge pull request #3367 from jdm/breakpoint
Add breakpoint utility function.
2014-09-17 02:33:27 -04:00
Jack Moffitt
1544db8bb9 Merge pull request #3373 from ProgramFOX/issue3366
Removed unused BlobMethods and CommentMethods traits, fixes #3366
2014-09-16 18:39:06 -06:00
Keegan McAllister
ffd126a0ff Merge pull request #3318 from mrobinson/scrolling
Store content offset in unscaled pixels
2014-09-16 13:00:44 -07:00
Manish Goregaokar
f5087e1490 Use #[must_root] for HTMLElements 2014-09-17 01:02:44 +05:30
Manish Goregaokar
30014c3919 Make Reflector #[must_root], propagate to non-HTMLElements 2014-09-17 01:02:41 +05:30
Manish Goregaokar
f0b8391762 Address review comments 2014-09-17 00:33:36 +05:30
Manish Goregaokar
d241826987 Unwrap pointers and miscellany for unrooted_must_root check 2014-09-16 23:31:40 +05:30
Matt Brubeck
6c9524b687 Implement background-position keyword values
Also fixes calculation of background-position percentages:

Rather than multiplying the container size by a percent and aligning the top
left of the image at the resulting width, we also need to subtract a
corresponding percent of the image size, per
http://dev.w3.org/csswg/css2/colors.html#propdef-background-position

"A value pair of '100% 100%' places the lower right corner of the image in the
lower right corner of the padding box. With a value pair of '14% 84%', the
point 14% across and 84% down the image is to be placed at the point 14%
across and 84% down the padding box."
2014-09-16 10:24:31 -07:00
Manish Goregaokar
bded5c3703 Add unrooted_must_root lint for usages of JS<T> in let/for bindings 2014-09-16 22:54:24 +05:30
ProgramFOX
457f1876b9 Removed unused BlobMethods and CommentMethods traits, fixes #3366 2014-09-16 19:03:04 +02:00
Manish Goregaokar
12dc54d238 Add unrooted_must_root lint for enums and structs containing JS<T>, as well as functions with JS<T> in their parameter list
For safe wrappers over JS<T> (eg Temporary<T>) use #[allow(unrooted_must_root)].
For all other types containing a #[must_root] value, annotate the type with #[must_root] to ensure that it is never used unrooted
2014-09-16 22:11:27 +05:30
Matt Brubeck
c7e30f87c4 Implement percentage heights for block flows
Fixes #2029
2014-09-16 09:02:01 -07:00