Commit graph

30673 commits

Author SHA1 Message Date
bors-servo
2377d60fa1 Auto merge of #19371 - emilio:doc-colors, r=whoops
style: Don't insert into the `seen` set before ignoring document colors.

Otherwise we may stop honoring other colors in other cascade levels.

Fixes: #19370

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19371)
<!-- Reviewable:end -->
2017-11-24 19:10:00 -06:00
Emilio Cobos Álvarez
4c02ad00ef
style: Don't insert into the seen set before ignoring document colors.
Otherwise we may stop honoring other colors in other cascade levels.

Fixes: #19370
2017-11-25 02:08:48 +01:00
bors-servo
6158a4bf91 Auto merge of #19368 - theres-waldo:bug951793, r=emilio
Bug 951793 - Add support for the 'overscroll-behavior' CSS property (Servo changes)

Servo changes for [bug 951793](https://bugzilla.mozilla.org/show_bug.cgi?id=951793).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19368)
<!-- Reviewable:end -->
2017-11-24 17:02:56 -06:00
Botond Ballo
efa61f0248 Bug 951793 - Regenerate bindings for Stylo. r=emilio 2017-11-24 17:02:49 -05:00
bors-servo
9900584757 Auto merge of #19370 - emilio:not-so-many-vars, r=xidorn
style: Perform variable substitution less often.

We're wasting a bunch of work unneedlessly.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19370)
<!-- Reviewable:end -->
2017-11-24 15:59:00 -06:00
Emilio Cobos Álvarez
90ba75ab44
style: Perform variable substitution less often.
We're wasting a bunch of work unneedlessly.
2017-11-24 22:53:44 +01:00
Botond Ballo
5e2622f259 Bug 951793 - Style support for overscroll-behavior in Stylo. r=emilio 2017-11-24 16:48:04 -05:00
bors-servo
8349be1b3e Auto merge of #19367 - emilio:gecko-assert, r=upsuper
style: Make a Servo-only assertion apply to Gecko too.

Gecko passes it now, and we want to know if that ever changes.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19367)
<!-- Reviewable:end -->
2017-11-24 14:51:46 -06:00
Emilio Cobos Álvarez
09c11d49d5
style: Make a Servo-only assertion apply to Gecko too.
MozReview-Commit-ID: CWhSfDQ8naE
2017-11-24 20:50:18 +01:00
bors-servo
b5b2455925 Auto merge of #19362 - SWW13:pip_log, r=jdm
Enable pip error output in mach_bootstrap.py

When `pip` encounters an error during mach bootstrapping in `mach_bootstrap.py` there is no error log because of `-q`. The output will only be read when an error was encountered, so this looks like an unintended mistake.

---

This gives error outputs like:
```
D:\Code\moz\servo>mach.bat -h
Pip failed to execute properly:
Output: Collecting marionette_driver>=2.4 (from -r D:\Code\moz\servo\tests\wpt\web-platform-tests\tools\wptrunner\requirements_firefox.txt (line 1))
  Using cached marionette_driver-2.4.0.tar.gz
Collecting mozprofile>=0.21 (from -r D:\Code\moz\servo\tests\wpt\web-platform-tests\tools\wptrunner\requirements_firefox.txt (line 2))
  Using cached mozprofile-0.28.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\$USER\AppData\Local\Temp\pip-build-zqivz5en\mozprofile\setup.py", line 12, in <module>
        assert sys.version_info[0] == 2
    AssertionError

    ----------------------------------------

Error: Command "python setup.py egg_info" failed with error code 1 in C:\Users\$USER\AppData\Local\Temp\pip-build-zqivz5en\mozprofile\
```

instead of:

```
D:\Code\moz\servo>mach.bat -h
Pip failed to execute properly:
Output:
Error: Command "python setup.py egg_info" failed with error code 1 in C:\Users\$USER\AppData\Local\Temp\pip-build-htd5no9k\mozprofile\
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19362)
<!-- Reviewable:end -->
2017-11-24 13:48:19 -06:00
Simon Wörner
663d6bc0c5 Enable pip output in mach_bootstrap.py 2017-11-24 20:47:11 +01:00
Simon Wörner
f08b473c50 Redirect stdout and stderr to file to avoid deadlock 2017-11-24 20:47:00 +01:00
bors-servo
3907953d80 Auto merge of #19363 - nox:canplaytype-warning, r=ferjm
Use GeckoMedia and only that on platforms that support it

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19363)
<!-- Reviewable:end -->
2017-11-24 08:47:31 -06:00
bors-servo
56b5a4d8cb Auto merge of #19364 - nox:cookie, r=KiChjang
Update cookie to 0.10

Except in webdriver, which source is in m-c.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19364)
<!-- Reviewable:end -->
2017-11-24 03:50:37 -06:00
Anthony Ramine
ae20da6a80 Update cookie to 0.10
Except in webdriver, which source is in m-c.
2017-11-24 10:49:14 +01:00
Anthony Ramine
8e75c4d30e Use GeckoMedia and only that on platforms that support it 2017-11-24 10:18:36 +01:00
bors-servo
2374224cdf Auto merge of #19359 - mstange:bug1417709-try2, r=emilio
Bug 1417709, round two

<!-- Please describe your changes on the following line: -->

These are the servo changes that need to go with [bug 1417709](https://bugzilla.mozilla.org/show_bug.cgi?id=1417709).

r? @emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because without these changes Firefox doesn't build.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19359)
<!-- Reviewable:end -->
2017-11-23 15:21:06 -06:00
bors-servo
964b9b42cb Auto merge of #19360 - kvark:wr-fix, r=jdm
WR update to 4595561c49939cb21be9554c1b85c244508bde73

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19347

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because: no new logic

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

cc @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19360)
<!-- Reviewable:end -->
2017-11-23 14:03:19 -06:00
Dzmitry Malyshau
8922280b91 WR update to 4595561c49939cb21be9554c1b85c244508bde73 2017-11-23 14:51:11 -05:00
Markus Stange
2c466658a6 Regenerate structs.rs. 2017-11-23 14:24:46 -05:00
Markus Stange
a0716e3545 Servo changes for system colors-moz-mac-vibrant-titlebar-light/dark 2017-11-23 14:24:25 -05:00
Markus Stange
4d64a6d973 Servo changes for -moz-appearance values-moz-mac-vibrant-titlebar-light/dark 2017-11-23 14:24:08 -05:00
bors-servo
177285ad4a Auto merge of #19357 - MortimerGoro:glutin_131, r=jdm
Update glutin to 0.13.1

<!-- Please describe your changes on the following line: -->

Includes https://github.com/servo/glutin/pull/133

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19357)
<!-- Reviewable:end -->
2017-11-23 12:35:10 -06:00
bors-servo
55049c2a67 Auto merge of #19352 - MortimerGoro:xhr_arraybuffer, r=jdm
Handle arraybuffer responseType in XHR

<!-- Please describe your changes on the following line: -->

Handle arraybuffer responseType in XHR

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19352)
<!-- Reviewable:end -->
2017-11-23 11:14:11 -06:00
Imanol Fernandez
27d5183ac1 Update glutin to 0.13.1 2017-11-23 17:22:02 +01:00
Imanol Fernandez
a39f1fe1bf Handle arraybuffer responseType in XHR 2017-11-23 17:19:57 +01:00
bors-servo
6009441f5e Auto merge of #19356 - tigercosmos:r1, r=jdm
update readme for ubuntu build

<!-- Please describe your changes on the following line: -->

Fix Ubuntu build

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #19351 (github issue number if applicable).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19356)
<!-- Reviewable:end -->
2017-11-23 10:14:30 -06:00
tigercosmos
4e8a96c65a update readme for ubuntu 2017-11-23 23:24:38 +08:00
bors-servo
7ac376eed6 Auto merge of #19349 - heycam:media-feature-range, r=emilio
style: Stop using nsMediaExpression_Range.

Servo part of https://bugzilla.mozilla.org/show_bug.cgi?id=1420071, reviewed there by Emilio.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19349)
<!-- Reviewable:end -->
2017-11-23 09:23:25 -06:00
bors-servo
7029e07ab9 Auto merge of #19185 - KiChjang:cookie-prefixes, r=avadacatavra
Implement secure and host cookie prefixes

Part of #8700.

I modified the algorithm so that it accurately checks for the presence of the `Path` attribute of the cookie, before checking whether it has a value of `/`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19185)
<!-- Reviewable:end -->
2017-11-23 08:26:03 -06:00
Josh Matthews
1d2456e076
Add clang packages for non-debian linuxes. 2017-11-23 09:13:25 -05:00
bors-servo
c5b446a573 Auto merge of #19337 - philn:gecko-canPlayType, r=nox
Implement HTMLMediaElement::canPlayType using gecko-media

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19337)
<!-- Reviewable:end -->
2017-11-23 06:52:27 -06:00
bors-servo
cd70a01d32 Auto merge of #19341 - emilio:traversal-new-faster, r=heycam
stylo: Make TraverseSubtree cheaper in the initial styling case.

This helps with bug 1419694.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19341)
<!-- Reviewable:end -->
2017-11-23 05:44:09 -06:00
Philippe Normand
24454c33b2 Implement HTMLMediaElement::canPlayType using gecko-media 2017-11-23 11:27:28 +00:00
bors-servo
ac576910d2 Auto merge of #19339 - CYBAI:moz-script-size-multiplier-out-of-mako, r=emilio
style: Move -moz-script-size-multiplier outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19333
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19339)
<!-- Reviewable:end -->
2017-11-23 04:28:18 -06:00
Cameron McCormack
4a3fea1bd1 style: Stop using nsMediaExpression_Range. 2017-11-23 17:48:43 +08:00
bors-servo
ca15c10003 Auto merge of #19346 - servo:SimonSapin-patch-1, r=asajeffrey
Remove compiletest from Travis script

This should have been in https://github.com/servo/servo/pull/19338

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19346)
<!-- Reviewable:end -->
2017-11-22 21:05:07 -06:00
CYBAI
20cfefbbbd style: Move -moz-script-size-multiplier outside of mako 2017-11-23 10:26:50 +08:00
bors-servo
72e7f6095e Auto merge of #19330 - Eijebong:sanitize_color, r=KiChjang
Add a sanitize_value implementation for the color input

I had to change the test a little bit to avoid some failures due to
color and text both having a sanitizedValue which was making the test
use the first assertion instead of the second one in some cases.

The sanitize_value implementation is pretty simple, we iterate over the
content and checks that the content is 7 characters long, that the first
character is a `#` and then that all the following characters are
hexadecimal. If all those requirements are met, we lowercase the
content, otherwise we put `#000000` in it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19330)
<!-- Reviewable:end -->
2017-11-22 19:42:58 -06:00
Simon Sapin
754341895d
Remove compiletest from Travis script
This should have been in https://github.com/servo/servo/pull/19338
2017-11-23 01:35:44 +01:00
bors-servo
976f9e3d13 Auto merge of #19329 - Manishearth:fetchcanceller, r=jdm
Add RAII guard for cancelling fetch when the consumer no longer cares about it

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19329)
<!-- Reviewable:end -->
2017-11-22 18:30:57 -06:00
bors-servo
369ae1d7e7 Auto merge of #19345 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Backed out changeset 2e20100d8f59 (bug 1417709) for error in toolkit/library/rust/target r=backout on a CLOSED TREE

Backed out changeset 2e20100d8f59 (bug 1417709) for error in toolkit/library/rust/target r=backout on a CLOSED TREE

Backs out https://github.com/servo/servo/pull/19255

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19345)
<!-- Reviewable:end -->
2017-11-22 17:26:52 -06:00
Gecko Backout
a06a80b5da Backed out changeset 2e20100d8f59 (bug 1417709) for error in toolkit/library/rust/target r=backout on a CLOSED TREE
Backs out https://github.com/servo/servo/pull/19255
2017-11-22 23:20:51 +00:00
Manish Goregaokar
3900f5e616
Use FetchCanceller for document loads 2017-11-22 14:06:27 -08:00
Bastien Orivel
05c4e08d58 Add a sanitize_value implementation for the color input
I had to change the test a little bit to avoid some failures due to
color and text both having a sanitizedValue which was making the test
use the first assertion instead of the second one in some cases.

The sanitize_value implementation is pretty simple, we iterate over the
content and checks that the content is 7 characters long, that the first
character is a `#` and then that all the following characters are
hexadecimal. If all those requirements are met, we lowercase the
content, otherwise we put `#000000` in it.
2017-11-22 22:36:21 +01:00
Emilio Cobos Álvarez
269077f317
stylo: Also tidy Servo_AnimationValue_DeepEqual while here. 2017-11-22 21:16:38 +01:00
Emilio Cobos Álvarez
663794fe2d
stylo: Tidy up create_shared_context. 2017-11-22 21:09:37 +01:00
Emilio Cobos Álvarez
b13f62714a
stylo: Make TraverseSubtree cheaper in the initial styling case.
We assert against the display: none / unstyled parent already, so there's no
need to check it here as well.
2017-11-22 21:07:57 +01:00
bors-servo
9ac05a5bee Auto merge of #19255 - mstange:bug1417709, r=emilio
Bug 1417709 - Add -moz-appearance: -moz-mac-vibrant-titlebar-light/dark and system colors with the same name.

<!-- Please describe your changes on the following line: -->

These are the servo changes that need to go with [bug 1417709](https://bugzilla.mozilla.org/show_bug.cgi?id=1417709).

r? emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because without these changes Firefox doesn't build.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19255)
<!-- Reviewable:end -->
2017-11-22 13:32:38 -06:00
Markus Stange
7be33e3a45 Regenerate structs.rs. 2017-11-22 14:09:55 -05:00