Commit graph

3214 commits

Author SHA1 Message Date
Manish Goregaokar
23e7dfa57b Relayout text input elements on blur 2016-01-03 13:18:24 +05:30
bors-servo
1b0053f8b1 Auto merge of #9136 - frewsxcv:htmlbodyelement-background, r=nox
HTMLBodyElement 'background' attribute improvements

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9136)
<!-- Reviewable:end -->
2016-01-03 11:00:49 +05:30
bors-servo
7f156b8c12 Auto merge of #9072 - Manishearth:password-placeholder, r=eefriedman
Fix placeholders for password inputs

currently they show dots instead of the placeholder text

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9072)
<!-- Reviewable:end -->
2016-01-03 10:21:26 +05:30
Manish Goregaokar
cc5844a373 Move placeholder logic out of get_raw_textinput_value 2016-01-03 09:47:30 +05:30
bors-servo
9da739acef Auto merge of #9123 - karyon:clippy_cleanup, r=Manishearth
Fix a bunch of clippy lints

This fixes about 130 clippy lints. Let me know if i should split up the commit.

I wasn't sure about some of the changes, especially map_or instead of map(...).unwrap_or(...) and if let instead of single arm match were not always a strict improvement in my opinion, but i'll leave that decision to the reviewer :)

There are about 150 lints left which i thought were clippy bugs or i didn't know how to fix.

cc @Manishearth

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9123)
<!-- Reviewable:end -->
2016-01-03 09:16:34 +05:30
bors-servo
6844adbe2d Auto merge of #9082 - nikkisquared:websocket_bufferedamount, r=eefriedman
Updated WebSocket buffered_amount to match change to html specification

The size of WebSocket's buffered_amount was changed[1] after an issue I opened, which I found while working on WebSocket previously[2]. @jdm suggested I make a PR updating Servo reflecting this, and so I have! As always, I'd like to hear any feedback on anything I can do to improve this.

[1] https://github.com/whatwg/html/issues/296
[2] https://github.com/servo/servo/pull/8218#issuecomment-152021737 point 5)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9082)
<!-- Reviewable:end -->
2016-01-03 08:43:55 +05:30
bors-servo
06d84e6e4b Auto merge of #9134 - iszak:issue-9132, r=nox
Fixes https://github.com/servo/servo/issues/9132

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9134)
<!-- Reviewable:end -->
2016-01-03 07:32:09 +05:30
bors-servo
1ac330837f Auto merge of #9130 - iszak:issue-9081, r=nox
Fixes https://github.com/servo/servo/issues/9081

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9130)
<!-- Reviewable:end -->
2016-01-03 06:27:54 +05:30
Corey Farwell
1a808219a8 Remove parsed attribute 'background' field on HTMLBodyElement
https://github.com/servo/servo/issues/7863
2016-01-02 16:54:38 -08:00
Iszak Bryan
603d0a54ea Use atom's for matching to gain performance benefits 2016-01-03 00:13:52 +00:00
Corey Farwell
9a1fd472ab Implement 'background' IDL attribute on <body> 2016-01-02 15:42:25 -08:00
Iszak Bryan
1fa3d36167 Store state of fill or style for canvas pattern 2016-01-02 23:35:04 +00:00
Johannes Linke
6b215f38ee Fix a bunch of clippy lints 2016-01-02 23:27:15 +01:00
bors-servo
c0835ec336 Auto merge of #9122 - ckimes89:inputevent, r=nox
Add 'input' event for HTMLInputElement

Fixes #8613

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9122)
<!-- Reviewable:end -->
2016-01-03 00:31:55 +05:30
Chad Kimes
0e663e0f2f De-duplicate input event send code 2016-01-02 11:31:22 -05:00
Chad Kimes
12a0884f51 Add 'input' event for HTMLInputElement 2016-01-02 11:07:12 -05:00
bors-servo
b1ca3d1cdf Auto merge of #9111 - frewsxcv:rm-parsed-attr, r=nox
Remove parsed attribute 'bgcolor' field HTMLTableElement

https://github.com/servo/servo/issues/7863

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9111)
<!-- Reviewable:end -->
2016-01-02 18:20:10 +05:30
bors-servo
7a5522a263 Auto merge of #9049 - KiChjang:form-data-refactor, r=eefriedman
Refactor FormData code to match updated spec

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9049)
<!-- Reviewable:end -->
2016-01-01 21:37:09 +05:30
bors-servo
11d160fc73 Auto merge of #9109 - nerith:createpattern, r=jdm
Support empty strings as the repeat argument (CreatePattern)

According to the third step in the specification [1], createPattern
should let the repetition argument be "repeat" when it is the empty
string.

The code in CanvasRenderingContext2D::CreatePattern did not implement
this step and instead threw a SyntaxError exception when an empty
string was supplied as the repetition argument.

Fixes #9079.

[1] https://html.spec.whatwg.org/multipage/#dom-context-2d-createpattern

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9109)
<!-- Reviewable:end -->
2016-01-01 21:04:51 +05:30
Keith Yeung
7001583047 Refactor FormData code to match updated spec
Use Atoms instead of Strings as keys
2016-01-01 05:38:10 -08:00
bors-servo
b8e7cd71d6 Auto merge of #8871 - KiChjang:task-source-channels, r=KiChjang
Add 5 different task source channels

This is **not** complete. I really need feedback right away since I felt that the direction I'm heading is very wrong.

Partial #7959.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8871)
<!-- Reviewable:end -->
2016-01-01 14:31:51 +05:30
Corey Farwell
7649748b83 Remove parsed attribute 'bgcolor' field HTMLTableElement
https://github.com/servo/servo/issues/7863
2015-12-31 14:15:54 -08:00
bors-servo
5e497cf311 Auto merge of #9099 - frewsxcv:rm-parsed-attr, r=nox
Remove fields with parsed attribute values on HTMLTextAreaElement

https://github.com/servo/servo/issues/7863

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9099)
<!-- Reviewable:end -->
2016-01-01 01:15:13 +05:30
Brandon Fairchild
1ccab328f9 Support empty strings as the repeat argument (CreatePattern)
According to the third step in the specification [1], createPattern
should let the repetition argument be "repeat" when it is the empty
string.

The code in CanvasRenderingContext2D::CreatePattern did not implement
this step and instead threw a SyntaxError exception when an empty
string was supplied as the repetition argument.

Fixes #9079.

[1] https://html.spec.whatwg.org/multipage/#dom-context-2d-createpattern
2015-12-31 11:48:15 -05:00
David Rajchenbach-Teller
1e81b8c133 Resolves #4183 - Implemementing context-based MIME type sniffing
The version of the standard is not finalized at the time of this writing.
Specifications may be found here: https://mimesniff.spec.whatwg.org/#context-specific-sniffing .
2015-12-31 07:45:03 -05:00
bors-servo
66c8aa8cda Auto merge of #8420 - craftytrickster:8371/generic-font-family, r=glennw
Enabled use of FontFamily enum type

https://github.com/servo/servo/issues/8371

In addition to replacing loose strings with the FontFamily enum in `font_cache_task.rs`, I also centralized the add_generic_font calls into one single function. If centralizing into one function is not desired or if anything else needs to be changed, please let me know.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8420)
<!-- Reviewable:end -->
2015-12-31 16:49:48 +05:30
bors-servo
77b23d1bb9 Auto merge of #9105 - jdm:buttoneventsintermittent, r=nox
Implement support for modifying the type attribute of <button>

https://github.com/servo/servo/pull/9100

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9105)
<!-- Reviewable:end -->
2015-12-31 15:56:16 +05:30
David Raifaizen
d942bfb474 Enabled use of FontFamily enum type and replaced plain string parameters with enum 2015-12-30 18:21:37 -05:00
Josh Matthews
3ef39e1a30 Implement the onreset event handler. 2015-12-30 16:04:16 -05:00
Josh Matthews
ffc1c777fe Implement support for modifying the type attribute of button elements. Fixes #9091. 2015-12-30 16:04:05 -05:00
Corey Farwell
3eb585f547 Remove fields with parsed attribute values on HTMLTextAreaElement
https://github.com/servo/servo/issues/7863
2015-12-30 12:27:13 -08:00
bors-servo
3d969e429d Auto merge of #7919 - 6112:master, r=nox
form submission for <textarea> and <select>

Fixes #7849.
Fixes #7850.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7919)
<!-- Reviewable:end -->
2015-12-30 23:58:40 +05:30
Nikki
b95af756ad now panics on integer overflow 2015-12-30 10:38:53 -07:00
bors-servo
80135a70ce Auto merge of #9080 - jdm:canvaspattern, r=Ms2ger
Enable Pattern variant of CanvasFillOrStrokeStyle

This is a rebase of #8104, with a test added that exposes pre-existing problems in the canvas code for dealing with patterns.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9080)
<!-- Reviewable:end -->
2015-12-30 13:56:43 +05:30
bors-servo
3f407ea3d6 Auto merge of #9077 - bholley:split_layout_context_etc, r=SimonSapin
Split the style-related bits out of LayoutContext and hoist more stuff into style/

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9077)
<!-- Reviewable:end -->
2015-12-30 11:01:23 +05:30
Nicolas
1f234af2ac form submission for <textarea> and <select>
small changes from code review

!child.get_disabled_state() becomes child.get_enabled_state()
2015-12-30 00:27:35 -05:00
bors-servo
0f5c614609 Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=SimonSapin
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
2015-12-30 10:04:14 +05:30
Nikki
773a15d28a added a check for buffer overflow 2015-12-29 17:08:46 -07:00
bors-servo
0d52170f35 Auto merge of #9054 - frewsxcv:parse-non-zero-dimension, r=eefriedman
Implement non-zero dimension attribute parsing

Fixes #8445

The only attributes I found that we have implemented that uses non-zero
dimenion attributes:

* `width` for `<td>` and `<th>` (table cells)
* `width` for `<table>`

I updated these implementations to use the new non-zero dimension
attribute parsing and added associated regression tests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9054)
<!-- Reviewable:end -->
2015-12-30 05:26:56 +05:30
Nikki
20edf21352 updated websocket buffered_amount to be u64 instead of u32 2015-12-29 13:30:35 -07:00
Bobby Holley
a05d7f1dfd Hoist style-related context bits into style/.
We do a few things-here:
* Hoist non-layout-dependent fields in SharedLayoutData and LocalLayoutData into style/.
* Hoist parts of css/matching.rs into style/.
* Hoist parts of layout/animation.rs into style/animation.rs.
* Remove the duplicated-but-slightly-different definition of OpaqueNode.
2015-12-29 12:07:07 -08:00
Bobby Holley
47059d2d26 Separate style+layout and layout-specific wrapper functionality.
This patch does a number of things, unfortunately all at once:
* Hoists a large subset of the layout wrapper functionality into the style system.
* Merges TElementAttributes into the newly-created TElement.
* Reorganizes LayoutData by style vs layout, and removes LayoutDataShared.
* Simplifies the API for borrowing style/layout data.

There's still more to do to make the style system usable standalone, but
this is a good start.
2015-12-29 11:50:03 -08:00
Josh Matthews
7693b03468 Make button elements activatable. Fixes #4837. Fixes #8101. 2015-12-29 10:45:04 -05:00
Alberto Corona
e6a3c16e9a Enable Pattern variant of CanvasFillOrStrokeStyle
Closes #7608
2015-12-29 10:38:00 -05:00
bors-servo
c1cb9403a7 Auto merge of #8948 - simartin:issue_8738, r=ecoal95
Issue #8738: bufferSubData and texImage2D argument sanity checks.

Fixes https://github.com/servo/servo/issues/8738

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8948)
<!-- Reviewable:end -->
2015-12-29 17:27:27 +05:30
Dongie Agnir
12afd837a0 Ask for reset when option is removed. 2015-12-27 21:47:13 -10:00
Manish Goregaokar
6a0ec85d43 Fix placeholders for password inputs
currently they show dots
2015-12-27 00:18:06 +05:30
Simon Martin
f2fe401d7d Issue #8738: bufferSubData and texImage2D argument sanity checks. 2015-12-26 18:56:48 +01:00
Joe Kachmar
655268d111 Separate script and layout messages, issue #8843 2015-12-26 12:24:51 -05:00
bors-servo
89ab368258 Auto merge of #8506 - nox:finish-ranges, r=dzbarsky
Properly propagate changes when range or trees are mutated

Does the same thing as #6817, but storing Range instances directly in their start and end containers.

Cc @dzbarsky

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8506)
<!-- Reviewable:end -->
2015-12-26 04:08:15 +05:30