Commit graph

729 commits

Author SHA1 Message Date
yoyo930021
2767a7b860 Need better description for mach subcommands #12402 4 2016-08-28 20:46:34 +08:00
yoyo930021
856b85ad95 Need better description for mach subcommands #12402 3 2016-08-28 20:32:48 +08:00
yoyo930021
326cd670d4 Need better description for mach subcommands #12402 2 2016-08-28 19:36:20 +08:00
yoyo930021
b39d4a6542 Need better description for mach subcommands #12402 2016-08-28 14:38:06 +08:00
UK992
0f07517049 Check for license only in Cargo.toml 2016-08-25 06:50:23 +02:00
bors-servo
eec56ca50e Auto merge of #12976 - Wafflespeanut:tidy_fixes, r=nox
A few minor cleanups in tidy

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because it's just a cleanup

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12976)
<!-- Reviewable:end -->
2016-08-23 03:29:05 -05:00
Ravi Shankar
33d7b3967e Some cleanups in tidy 2016-08-23 00:53:09 +05:30
tp6vup54
55af3e3c27 Change the separator used in rust path into os.path.join 2016-08-22 23:32:02 +08:00
bors-servo
1c9650cc90 Auto merge of #12877 - UK992:tidy-toml, r=Wafflespeanut
Tidy config file

This is wip workaround for https://github.com/servo/servo/issues/10841
Adds ``servo-tidy.toml`` with configs and ignored dirs, files and packages.
This will allow to set custom configuration per repo.
It's an example how could config file looks like.
I want opinion on that, if this is right approaches and how to improve it.

cc @edunham

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12877)
<!-- Reviewable:end -->
2016-08-20 22:27:06 -05:00
UK992
74dba5cbdd Check for errors in tidy config file 2016-08-20 22:51:46 +02:00
UK992
0ad905ae42 Tidy config file 2016-08-20 22:50:56 +02:00
bors-servo
5a5c16776c Auto merge of #12250 - ConnorGBrewster:mac_about_version, r=larsbergstrom
Add servo version to mac about servo window.

<!-- Please describe your changes on the following line: -->
<img width="396" alt="screen shot 2016-07-04 at 8 43 44 pm" src="30a6dd6c-4228-11e6-9098-68c49900b14e.png">

cc @aneeshusa

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes are a temporary solution for #12052 (github issue number if applicable).

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12250)
<!-- Reviewable:end -->
2016-08-19 19:45:00 -05:00
Connor Brewster
fe61124c15 Add servo version to mac about servo window. 2016-08-19 18:55:27 -05:00
Xidorn Quan
0510b4a198 Check PLATFORM for proper toolchain when use msvc 2016-08-18 21:19:27 +10:00
Vladimir Vukicevic
a25c3da27a Set up PATH to find DLLs for tests 2016-08-17 09:51:45 -04:00
Vladimir Vukicevic
ab007315c2 Copy in DLLs to servo.exe dir 2016-08-17 09:51:42 -04:00
Vladimir Vukicevic
e7dd579ebf Ignore TOML failing to parse Cargo.lock, due to a bug 2016-08-17 09:51:38 -04:00
Vladimir Vukicevic
59da96def1 Use mingw windows subsystem syntax for gcc only 2016-08-17 09:51:14 -04:00
Vladimir Vukicevic
5ab760e698 Fix unicode env issues for call() 2016-08-17 09:51:09 -04:00
Vladimir Vukicevic
0aa5ad4197 Don't enforce line length in Cargo.toml files 2016-08-17 09:51:02 -04:00
Vladimir Vukicevic
0e32871591 Add proper Win32 notification for builds 2016-08-17 09:50:58 -04:00
Vladimir Vukicevic
82df8e9399 Set windows subsystem on MSVC builds with editbin 2016-08-17 09:50:54 -04:00
S
f5c5fdebe1 Add error message for connectivity issues during bootstrap 2016-08-17 01:13:18 +00:00
bors-servo
75f6cf47c4 Auto merge of #12870 - pathway27:master, r=Wafflespeanut
./mach has a formatting error

<!-- Please describe your changes on the following line: -->

Fix for #12766. Couldn't reproduce the exact error.

I explicitly raised urllib2.URLError to get to the print and then tried using many different variable types for e.reason and src but it still didn't throw a coercion error.

So, as @Wafflespeanut said,
> Instead of appending, we can format the values, which (I'm pretty sure) will fix this error.

which is what i've done.

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12766, hopefully.

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests they execute before the test runner is installed. Can't test the bootstraping code.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12870)
<!-- Reviewable:end -->
2016-08-15 23:59:07 -05:00
S
8e12e3ce68 Fix overriding url with Request obj. when resuming download 2016-08-16 04:09:10 +00:00
S
c3d118a45e Fix error-prone message while bootstrapping 2016-08-15 04:36:41 +00:00
Paul Rouget
c40a658e9c Revert "Enable multiprocess and sandbox"
This reverts commit 663f8530cf.
2016-08-15 03:44:46 +02:00
bors-servo
a2ce4aa852 Auto merge of #12688 - paulrouget:brew, r=larsbergstrom
brew package

Addressed #12600

This is just a WIP PR to see if this approach is right.

The same way night builds are uploaded every day, we'd like to offer a brew binary package as well.

Step 1 is to package a tarball along the dmg. This is done in `package_commands.py`.
Step 2 is to upload the package. Done is `update_brew.sh`.
Step 3 is to update the brew Formula. [servo-bin.rb](https://github.com/paulrouget/homebrew-servo/blob/master/servo-bin.rb.in) is updated in `update_brew.sh`.
Step 4 is to trigger `update_brew.sh` along `update_nightly.sh`. https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/steps.yml

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12688)
<!-- Reviewable:end -->
2016-08-14 15:25:25 -05:00
bors-servo
8419f96dc0 Auto merge of #12781 - UK992:tidycheck-rebased, r=Wafflespeanut
Improve tidy's license validation logic

Rebased and fixed https://github.com/servo/servo/pull/10721, which is inactive for months.
Fixes https://github.com/servo/servo/issues/10716

r? @larsbergstrom or @edunham

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12781)
<!-- Reviewable:end -->
2016-08-14 09:17:34 -05:00
UK992
fed0e94ec6 Add support colored text in Windows Console 2016-08-13 03:20:47 +02:00
bors-servo
b4695541ae Auto merge of #12821 - UK992:mach-update, r=aneeshusa
Create `mach fetch` command

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12775.

r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12821)
<!-- Reviewable:end -->
2016-08-12 17:18:43 -05:00
UK992
d805e855a9 Create mach fetch command 2016-08-12 16:13:39 +02:00
UK992
9a3b61abe1 Check for blank line after shebang and grab actual comment block instead of hard-coded one 2016-08-12 13:34:38 +02:00
edunham
48ace17b54 Improve tidy's license validation logic
fixes https://github.com/servo/servo/issues/10716

I took the lazy way out and hardcoded the size of block we examine for
licenses.

fixes https://github.com/servo/servo/issues/10719

Includes tests for new functionality.
2016-08-12 13:32:09 +02:00
Ms2ger
e99cb474f0 Update ordered-float. 2016-08-11 09:13:22 +02:00
Simon Martin
1e60c915f9 Issue #12421: tidy should also check .html files 2016-08-09 22:04:57 +02:00
Ravi Shankar
a04028eede Prefer length and percentage for word spacing 2016-08-09 17:53:40 +05:30
Paul Rouget
79812971f1 brew package 2016-08-09 05:48:27 +02:00
bors-servo
aa900b91aa Auto merge of #12736 - aneeshusa:prohibit-backticks-in-shell-scripts, r=Wafflespeanut
Add more shell script lints

<!-- Please describe your changes on the following line: -->

The "$(some_command arg1 arg2)" form is preferred to the
`some_command arg1 arg2` form because it nests unambiguously.
Add a lint for this to tidy.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12736)
<!-- Reviewable:end -->
2016-08-06 21:57:31 -05:00
tsawada
eba39ab98a Fix flag compose in runservo.sh
s/-S--pref/-S --pref/
2016-08-06 10:15:41 -04:00
UK992
6548325bd2 Run git command only with mach build commands 2016-08-05 22:47:27 +02:00
Aneesh Agrawal
f07d8f188a Add lint for [ instead of [[ in shells scripts 2016-08-05 09:42:04 -04:00
Aneesh Agrawal
9231ca1c69 Add lint to ensure substitutions use the full form
Check that any variable substitutions use the full ${VAR} form,
not just $VAR (but don't check for quoting yet).
2016-08-05 09:29:10 -04:00
Aneesh Agrawal
79ef9b4efc Add lint for backticks in shell scripts
The "$(some_command arg1 arg2)" form is preferred to the
`some_command arg1 arg2` form because it nests unambiguously.
Add a lint for this to tidy.
2016-08-05 09:29:09 -04:00
bors-servo
1086df67e0 Auto merge of #12244 - rev112:package-repro-pure, r=aneeshusa
Create .tar.gz package deterministically using Python's "tarfile"

<!-- Please describe your changes on the following line: -->
A development of #12108, creates a .tar.gz package using the `tarfile` and `gzip` modules, without external dependencies. Fixes #11981.
Also this fixes the issue when the existing `resources/` directory didn't allow to create a new package and failed with "File exists" error.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11981 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because "more general approach to reproducibility testing is needed"

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12244)
<!-- Reviewable:end -->
2016-08-04 18:15:49 -05:00
bors-servo
3dce4c62ca Auto merge of #12708 - paulrouget:multiprocessAndSandboxForBhtml, r=metajack
Enable multiprocess and sandbox

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12705 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Enable multiprocess and sandbox for Mac and Linux when running
browserhtml.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12708)
<!-- Reviewable:end -->
2016-08-04 16:13:45 -05:00
Anton Ovchinnikov
0a056a9b31 Create .tar.gz package deterministically
Fixes #11981.
2016-08-04 21:47:37 +02:00
bors-servo
4bc629b369 Auto merge of #12295 - jimberlage:12158/shell-linting, r=aneeshusa
Add linting for shell scripts

<!-- Please describe your changes on the following line: -->

This changes tidy to check shell scripts for the proper shebang and
options.  It does not check that variables are formatted correctly.  It
also adds a check for the MPL 2.0 license in shell scripts.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12158 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12295)
<!-- Reviewable:end -->
2016-08-04 12:31:17 -05:00
Emilio Cobos Álvarez
27b2bad256
stylo: Fix and ensure alignment of restyle hints. Test it on Travis.
Turns out eRestyle_LaterSiblings was not really matching, sigh...
2016-08-03 15:18:32 -07:00
Paul Rouget
663f8530cf Enable multiprocess and sandbox
Enable multiprocess and sandbox for Mac and Linux when running
browserhtml.
2016-08-03 06:19:59 +02:00