Commit graph

134 commits

Author SHA1 Message Date
Cameron Zwarich
2c8d51a37c More progress in the &JSRef -> JSRef conversion
Change all of the <Class>Methods traits to take `self` instead of
`&self`.
2014-09-20 11:54:10 -07:00
Adenilson Cavalcanti
7581335232 Move is_void() Element method together with the other struct methods,
it becomes part of ElementHelpers.
2014-09-20 10:24:57 -07:00
Gilles Leblanc
652d217961 Share code between Navigator and WorkerNavigator
Also shares code between Location and WorkerLocation. This has been done
by introducing NavigatorInfo and UrlHelper.

Fixes #3159
2014-09-20 08:51:35 -04:00
Tetsuharu OHZEKI
de0866ab42 Use Untraceable<T> to hold LayoutDataRef instead of manual Encodable implementation. 2014-09-20 15:19:01 +09:00
Tetsuharu OHZEKI
54d3a0b280 Reintroduce Untraceable<T>.deref_mut() to make mem::replace() possible to Untracebale<T> field.
Some compile errors caused by the compiler's misreading comes back again :(
We re-use `deref()`explicitly to hide these errors.
2014-09-20 15:19:00 +09:00
Patrick Walton
c51b8a07ac Merge pull request #3430 from pcwalton/inline-block-percentage-height
layout: Make percentage heights propagate through inline flows.
2014-09-19 23:05:55 -07:00
Patrick Walton
ccda8f204a Merge pull request #3420 from glennw/table-debug
Adds support for table layout trace and updates viewer for tables.
2014-09-19 19:50:47 -07:00
Cameron Zwarich
e9ad87e27e Merge pull request #3422 from zwarich/jsref
First steps of &JSRef -> JSRef conversion
2014-09-19 19:28:32 -07:00
Patrick Walton
0604d0c6b1 layout: Handle floated blocks with percentage heights correctly.
Improves the top menu in Wikipedia.
2014-09-19 17:56:07 -07:00
Patrick Walton
39d7bf93d6 layout: Make percentage heights propagate through inline flows.
I found this random bug during an attempt to improve Wikipedia.
2014-09-19 17:20:56 -07:00
Clark Gaebel
877de7f694 Merge pull request #3427 from cgaebel/add-license-to-tid
added valid license to tid.rs
2014-09-19 17:19:42 -07:00
Patrick Walton
08e004d106 Merge pull request #3424 from SimonSapin/font-size-absolute
Add font-size absolute size keywords. Fix #3417
2014-09-19 15:17:55 -07:00
Cameron Zwarich
4fa8725111 First steps of &JSRef -> JSRef conversion
Replace &JSRef with JSRef in the bulk of the generated code. This will
remove a level of indirection throughout all DOM code.

This patch doesn't change methods implemented on JSRef<T> to take `self`
rather than `&self`, and it leaves a few other uses of &JSRef, but those
changes can be made incrementally.
2014-09-19 13:39:17 -07:00
Patrick Walton
b4db9aeaeb Handle generated content with display: block correctly during flow
construction.

The iteration was incorrect here. Although it accidentally worked
before, it will cause problems when we have incremental style
recalculation.

The `after_block_iteration` reftest will become interesting once we have
incremental style recalc.
2014-09-19 12:25:37 -07:00
Clark Gaebel
3b280ac8b0 added valid license to tid.rs 2014-09-19 11:34:43 -07:00
Simon Sapin
4e71b215b8 Add font-size absolute size keywords. Fix #3417.
Relative size keywords are still missing:
https://github.com/servo/servo/issues/3423
2014-09-19 19:04:31 +01:00
Josh Matthews
6d6726178a Merge pull request #3253 from ChrisParis/TreeWalker
Implement TreeWalker
2014-09-19 10:54:26 -04:00
Josh Matthews
f139eb5176 Merge pull request #3401 from pcwalton/refactor-layout
layout: Remove `layout/extra.rs`.
2014-09-19 10:51:02 -04:00
Josh Matthews
b82c0dced0 Merge pull request #3172 from jdm/devtools
Dump initial prototype of devtools server into the build. Expect lies if...
2014-09-19 09:15:03 -04:00
Simon Sapin
010d87b93e Remove min/max functions from util::geometry. Use std::cmp instead. 2014-09-19 13:56:35 +01:00
Simon Sapin
415bbaeb2e Fix dimensionality of Au
Previously, we implemented:

Au * Au -> Au
Au / Au -> Au
Au % Au -> Au

... which are inconsistent. It should be:

Au * Au -> SquaredAu
Au / Au -> i32
Au % Au -> i32

or:

Au * i32 -> Au
Au / i32 -> Au
Au % i32 -> Au

I picked the latter.

Also, the multiplicative identity does not make sense
when multiplication take two different types.
2014-09-19 13:54:57 +01:00
Glenn Watson
818f70e319 Fix img with display: block. Fixes text/image overflow on wikipedia.
Ref: #2554
2014-09-19 17:59:48 +10:00
glennw
a3b20d8179 Merge pull request #3421 from glennw/table-padding
Fix padding on tables. This fixes the TOC on wikipedia pages.
2014-09-19 17:50:50 +10:00
Cameron Zwarich
d7ffe7a198 Merge pull request #3416 from zwarich/remove-jsref-mut
Remove uses of &mut JSRef
2014-09-18 22:25:48 -07:00
Glenn Watson
fd176d5387 Fix padding on tables. This fixes the TOC on wikipedia pages.
Ref: #2554
2014-09-19 14:58:24 +10:00
Glenn Watson
0d0d2365aa Adds support for table layout trace and updates viewer for tables. 2014-09-19 14:48:53 +10:00
Cameron Zwarich
176b3f7698 Remove uses of &mut JSRef
Since everything with JSRef happens with interior mutability, it doesn't
make any sense to use an &mut JSRef.
2014-09-18 15:30:38 -07:00
Matt Brubeck
f35941d91d Fix line splitting in white-space: pre flows
The newline position from one line was getting used repeatedly, causing extra
"phantom" newlines in the following lines.  Fixes #3413.
2014-09-18 14:25:12 -07:00
Chris Paris
92638a6fe6 Implement TreeWalker 2014-09-18 11:13:33 -10:00
Josh Matthews
fae7ce3c1d Retrieve some basic layout properties for nodes to make the box model somewhat useful. 2014-09-18 15:07:11 -04:00
Josh Matthews
fa57fe890b Enable real DOM inspector support. 2014-09-18 15:06:40 -04:00
Josh Matthews
e9c4aa534d Implement wire protocol support for DOM inspector. 2014-09-18 15:06:40 -04:00
Josh Matthews
c31e2f928d Avoid selecting on the devtools port if no devtools server exists. 2014-09-18 15:06:40 -04:00
Josh Matthews
bb9955c281 Split devtools implementation into sensible modules. 2014-09-18 15:06:40 -04:00
Josh Matthews
cdb4037ca2 Enable executing JS snippets in the context of the main Servo window and viewing the responses from the Firefox remote console. 2014-09-18 15:06:40 -04:00
Josh Matthews
f0f7e98dfa Dump initial prototype of devtools server into the build. Expect lies if you try to use it for anything real. 2014-09-18 15:06:40 -04:00
Patrick Walton
f5c0124363 layout: Remove layout/extra.rs.
Also, rename a few methods in layout that arguably had confusing names.
2014-09-18 11:33:04 -07:00
Patrick Walton
5e5f77a354 Try to unbreak the build by removing unused import 2014-09-18 10:56:58 -07:00
Clark Gaebel
670ca9894e Fixed #3386. 2014-09-18 09:20:23 -07:00
Clark Gaebel
1b251db732 Merge pull request #3379 from cgaebel/bucketed-timing
Added more complex profiling metadata.
2014-09-18 09:12:34 -07:00
Patrick Walton
22bca83509 Merge pull request #3404 from glennw/inline-block-fix
Include margin in inline block intrinsic width. Fixes [edit] links on wikipedia. Also improves google homepage.
2014-09-18 07:51:11 -07:00
Josh Matthews
9607b468bc Revert "script: Use atom comparison in more places, especially for attributes." for persistent test failures.
This reverts commit 874db26104.
2014-09-18 09:20:19 -04:00
Glenn Watson
6bc65f3b07 Include margin in inline block intrinsic width. Fixes [edit] links on wikipedia. 2014-09-18 16:07:28 +10:00
Matt Brubeck
8aeb90e8c3 Merge pull request #3395 from mbrubeck/doctest
Fix unit test failures. r=jdm
2014-09-17 17:05:29 -07:00
Josh Matthews
75caade828 Merge pull request #3358 from jdm/thespicemustnotreflow
Delay initiating layout operations for as long as possible.
2014-09-17 19:09:31 -04:00
Clark Gaebel
6bc63d47cd Added more complex profiling metadata. 2014-09-17 15:41:27 -07:00
Matt Brubeck
140b0007fd Update style unit tests to use atoms
Fixes test bustage from #3316.
2014-09-17 14:49:04 -07:00
Matt Brubeck
a939cc50bb Fix doctest errors in rustdoc comments
Mostly this disables doctest for comments that are not actually tests.
2014-09-17 14:46:37 -07:00
Patrick Walton
874db26104 script: Use atom comparison in more places, especially for attributes.
75% improvement in style recalc for Guardians of the Galaxy.
2014-09-17 13:17:12 -07:00
Josh Matthews
61642d64b5 Merge pull request #3387 from prasoon2211/base64_methods_for_worker
Implement atob and btoa methods for worker
2014-09-17 11:46:20 -04:00