Commit graph

18575 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
2f0df1b421
style: Add bindings for ShadowRoot.
This adds TShadowRoot to the `dom` module.

Right now it barely adds uses of it, but this is a prerequisite to fix a bunch
of Shadow DOM bugs and separate it from the XBL mess.
2018-03-03 23:52:49 +01:00
bors-servo
df079286c2
Auto merge of #20187 - emilio:font-optical-sizing, r=emilio
style: Add font-optical-sizing property.

Patch by Jonathan Kew <jkew@mozilla.com>.

Bug: 1435692
Reviewed-by: emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20187)
<!-- Reviewable:end -->
2018-03-03 15:10:30 -05:00
Emilio Cobos Álvarez
865a14cf0f
style: Update bindings. 2018-03-03 20:42:41 +01:00
Jonathan Kew
93b7d01324
style: Add font-optical-sizing property.
Bug: 1435692
Reviewed-by: emilio
2018-03-03 20:42:40 +01:00
bors-servo
95f81d0c39
Auto merge of #20183 - servo:computed-as-clone, r=emilio
Unconditionally derive ToComputedValue as Clone for non-generic types

We assume that types such as `<Self as ToComputedValue>::ToComputedValue == Self`
just construct a new value that is just a clone of the original one without any
additional code.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20183)
<!-- Reviewable:end -->
2018-03-03 14:15:17 -05:00
bors-servo
5bfd74e42d
Auto merge of #20180 - emilio:moar-refcount-hackery, r=jdm
style: Copy less urls for stylo.

Bug: 1442246
Reviewed-by: jdm
MozReview-Commit-ID: NmHue1mGDq

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20180)
<!-- Reviewable:end -->
2018-03-03 13:25:15 -05:00
Anthony Ramine
b517bcd42b Unconditionally derive ToComputedValue as Clone for non-generics
We assume that types such as `<Self as ToComputedValue>::ToComputedValue == Self`
just construct a new value that is just a clone of the original one without any
additional code.
2018-03-03 18:41:50 +01:00
Emilio Cobos Álvarez
569dde72d0
style: Fix text-emphasis-style conversion.
Was accidentally broken in #20178 and is causing orange.
2018-03-03 18:22:27 +01:00
Emilio Cobos Álvarez
98e4c08c64
style: Update bindings. 2018-03-03 18:18:22 +01:00
Emilio Cobos Álvarez
da94feb11a
style: Copy less URLs on stylo.
Bug: 1442246
Reviewed-by: jdm
MozReview-Commit-ID: NmHue1mGDq
2018-03-03 18:18:22 +01:00
Anthony Ramine
15dcd8a8ea Derive ToCss for ViewportLength 2018-03-03 16:15:24 +01:00
Anthony Ramine
6e19fe6a8f Derive ToCss for KeyframeSelector 2018-03-03 16:15:23 +01:00
Anthony Ramine
be820092ad Derive ToCss for VectorValues 2018-03-03 16:15:23 +01:00
Anthony Ramine
51a54e1a60 Derive ToCss for PairValues 2018-03-03 16:15:22 +01:00
Anthony Ramine
71c0c3a5d3 Derive ToCss for DocumentCondition 2018-03-03 16:15:21 +01:00
Anthony Ramine
7e1c23cb74 Replace a boolean with a new FillMode enum for text-emphasis-style
This allows us to derive some ToCss and Parse code.
2018-03-03 16:15:20 +01:00
Anthony Ramine
13c40f4fb8 Derive ToCss for TransitionProperty 2018-03-03 16:15:20 +01:00
Anthony Ramine
83a2312867 Derive ToCss for Symbol 2018-03-03 16:15:19 +01:00
Anthony Ramine
ad7adee882 Use CustomIdent in Symbol::Ident
The former code was not following the spec.
2018-03-03 16:15:13 +01:00
Anthony Ramine
a71b5d5e16 Derive ToCss for Symbols 2018-03-03 01:01:59 +01:00
Anthony Ramine
ba1d3d4b81 Derive ToCss for UrlMatchingFunction 2018-03-03 01:01:59 +01:00
Petre Tudor
e1f72f845e removed default_data_dir() and default_cache_dir() components/config/basedir.rs 2018-03-02 22:39:07 +02:00
bors-servo
48ff3965cc
Auto merge of #20175 - andreicristianpetcu:remove_optional_from_default_config_dir, r=jdm
#20174 removed the option and unwrap

I removed the useless option and the need for unwrap from default_config_dir

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20174 (github issue number if applicable).
- [X] These changes do not require tests because they are used at build time.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20175)
<!-- Reviewable:end -->
2018-03-02 14:39:37 -05:00
Andrei Cristian Petcu
415c43e226 #20174 removed the option and unwrap 2018-03-02 21:22:38 +02:00
bors-servo
7944bcbe8d
Auto merge of #20173 - emilio:formatted-style, r=nox
style: Update bindgen to 0.33.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20173)
<!-- Reviewable:end -->
2018-03-02 12:45:29 -05:00
Emilio Cobos Álvarez
31695bd58f
style: Update bindgen to 0.33. 2018-03-02 18:45:12 +01:00
bors-servo
476a0764f5
Auto merge of #20171 - servo:content-item-counters, r=emilio
Make ContentItem use a CustomIdent for counter names

See https://github.com/w3c/csswg-drafts/pull/2377.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20171)
<!-- Reviewable:end -->
2018-03-02 11:18:49 -05:00
Anthony Ramine
91ed0b0aa5 Derive ToCss for ContentItem 2018-03-02 16:07:02 +01:00
Anthony Ramine
a4d3a8d74a Make ContentItem use a CustomIdent for counter names
See https://github.com/w3c/csswg-drafts/pull/2377
2018-03-02 16:06:54 +01:00
Emilio Cobos Álvarez
e08e0704a2
Reland #20160 since it just needed a revendor that didn't happen automatically. 2018-03-02 14:42:45 +01:00
Gecko Backout
59cb14b71b Backed out changeset 39a71f4c9d94 for build bustages at make[4]: *** [force-cargo-library-build] Error 101 on a CLOSED TREE
Backs out https://github.com/servo/servo/pull/20160
2018-03-02 12:47:51 +00:00
bors-servo
0172989b6f
Auto merge of #20160 - emilio:formatted-style, r=xidorn
style: Rustfmt bindings on automation, and locally under an env variable.

Bug: 1432153
Reviewed-by: xidorn
MozReview-Commit-ID: HJ9J5NtYVk2

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20160)
<!-- Reviewable:end -->
2018-03-02 05:38:00 -05:00
bors-servo
e446897cf6
Auto merge of #20163 - Manishearth:rowspan-crash, r=mbrubeck
Don't panic on cells with both a rowspan and colspan in include_sizes_from_previous_rows

fixes #20162

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20163)
<!-- Reviewable:end -->
2018-03-01 20:36:50 -05:00
bors-servo
90b8410b05
Auto merge of #20150 - upsuper:text-is-significant, r=emilio
Remove text-is-significant param from Gecko_IsSignificantChild

This is Servo side change of [bug 1441729](https://bugzilla.mozilla.org/show_bug.cgi?id=1441729).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20150)
<!-- Reviewable:end -->
2018-03-01 18:52:07 -05:00
Manish Goregaokar
be12b90412 Don't panic on cells with both a rowspan and colspan in include_sizes_from_previous_rows
fixes #20162
2018-03-01 15:38:29 -08:00
bors-servo
6f2cd86b8e
Auto merge of #20152 - Manishearth:rowspan-zero, r=mbrubeck
Support zero rowspans

This makes rowspan=0 work by storing notes on which group of rows we're in
for tables containing both rowgroups and rows, and using that to respan
cells with overlarge or zero rowspans.

This also gets rid of the largest_leftover_incoming_size business, because
now spans will always be correct and we'll never have any left over.

Based on https://github.com/servo/servo/pull/20128

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20152)
<!-- Reviewable:end -->
2018-03-01 13:36:43 -05:00
Emilio Cobos Álvarez
c04fc0a269
style: Rustfmt bindings on automation, and locally under an env variable.
Bug: 1432153
Reviewed-by: xidorn
MozReview-Commit-ID: HJ9J5NtYVk2
2018-03-01 16:44:04 +01:00
Emilio Cobos Álvarez
8778b46d57
style: Update bindgen. 2018-03-01 16:23:51 +01:00
Anthony Ramine
3abc020744 Kill RUSTC_HAS_PR45225 🎉 2018-03-01 14:47:57 +01:00
Manish Goregaokar
54eb1eb780 Support rowspan=0; always fixup overflowing rowspans beforehand
This makes rowspan=0 work by storing notes on which group of rows we're
in for tables containing both rowgroups and rows, and using that to
respan cells with overlarge or zero rowspans.

This also gets rid of the largest_leftover_incoming_size business,
because now spans will always be correct and we'll never have any left
over.
2018-02-28 17:37:59 -08:00
Manish Goregaokar
19dba91e4d Fixup specified colspans and rowspans 2018-02-28 17:07:49 -08:00
bors-servo
e2f2814018
Auto merge of #20128 - Manishearth:rowspan, r=mbrubeck
Rowspan support for tables

fixes #20092

This just contains the first steps.

We apply a naive algorithm: Spanning cells apply a pressure equal to `block_size / rowspan` on each row they are in. We move table row block size computation into the tables, and make it two pass. In the first pass we compute the sizes of each row, and in the
second pass we assign them, adding them up for any involved cells.

This is missing:

 - [x] Accounting for border sizes
 - [x] Applying pressure to rows that are not the row containing the cell
 - [ ] Reducing pressure on future rows if the current row is able to accomodate more of the cell
 - [x] For tables containing both rows and rowgroups, reset the rowspan info when we hit a rowgroup
 - [x] Correctly handle overflowing rowspans

cc @mbrubeck @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20128)
<!-- Reviewable:end -->
2018-02-28 18:40:39 -05:00
Xidorn Quan
107d9d2072 Remove text-is-significant param from Gecko_IsSignificantChild 2018-03-01 09:48:32 +11:00
bors-servo
af92c06223
Auto merge of #20143 - Eijebong:bump, r=nox
Bump itertools, image, flate2 and caseless

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20143)
<!-- Reviewable:end -->
2018-02-28 13:10:59 -05:00
Bobby Holley
0236a6ce99 Stylo: Pass an explicit parent SheetLoadData for child stylesheet loads.
MozReview-Commit-ID: 7XNu42NtITm
2018-02-28 08:28:48 -08:00
Bastien Orivel
4ea60d3a2a Update caseless to 0.2 2018-02-28 16:55:39 +01:00
Bastien Orivel
c072829be0 Update flate2 to 1.0 2018-02-28 16:55:35 +01:00
Bastien Orivel
9ca18b510f Update image to 0.18 2018-02-28 16:25:35 +01:00
Bastien Orivel
22325df495 Update itertools to 0.7 2018-02-28 16:25:32 +01:00
bors-servo
a0be3a7fae
Auto merge of #20138 - emilio:longhand-iterator, r=nox
style: Only expose longhands to rust via iterators.

The key here is that we only filter longhands if the shorthand is accessible to
content and vice-versa. This prevents the bug that prevented me to land this
patch before, which was us not expanding properly chrome-only shorthands.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20138)
<!-- Reviewable:end -->
2018-02-28 06:28:41 -05:00