Bobby Holley
3330653dc8
Rip out the generic abstractions around ThreadLocalStyleContext.
...
MozReview-Commit-ID: 5WTLuk323Ac
2017-07-05 16:37:17 -07:00
bors-servo
296a215e54
Auto merge of #17603 - servo:derive-all-the-things, r=SimonSapin
...
Clean up vector_longhand a bit
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17603 )
<!-- Reviewable:end -->
2017-07-05 07:33:13 -07:00
Simon Sapin
7e0254b530
Drive-by fix "unused import" warning.
2017-07-05 13:58:06 +02:00
Simon Sapin
86293c3b39
Replace remaining usage of deprecated Range::step_by
...
… which is being removed in https://github.com/rust-lang/rust/pull/43012
2017-07-05 13:54:40 +02:00
Anthony Ramine
4a2ede9b3a
Kill delegate_animate from vector_longhand
...
The impl is now always generated if animation_value_type is ComputedValue.
2017-07-05 11:22:00 +02:00
Anthony Ramine
6c7c00f4c8
Kill gecko_only from vector_longhand
2017-07-05 11:21:59 +02:00
Daisuke Akatsuka
1b28d5e009
update auto generated files
2017-07-05 13:21:08 +09:00
Daisuke Akatsuka
d8dcc52c9a
implements nsStyleImageRequest type properties animatable
2017-07-05 13:11:58 +09:00
Daisuke Akatsuka
d885747a18
implements nsStyleImage type properties animatable
2017-07-05 13:10:58 +09:00
Daisuke Akatsuka
4924a4832f
implements URLValue type properties animatable
2017-07-05 13:08:12 +09:00
Daisuke Akatsuka
b3def4a84e
implements u8 and array type properties animatable
2017-07-05 13:07:22 +09:00
Daisuke Akatsuka
0107b3e019
rename macro from impl_gecko_keyword_from_trait to impl_gecko_keyword_conversions
2017-07-05 13:07:21 +09:00
Daisuke Akatsuka
961bdee6a3
implements nsFont type properties animatable
2017-07-05 13:07:20 +09:00
Daisuke Akatsuka
699ec02e8b
implements nsStyleBorder type properties animatable
2017-07-05 13:07:08 +09:00
Daisuke Akatsuka
0555977c66
implements nsStyleQuoteValues type properties animatable
2017-07-05 13:00:02 +09:00
Daisuke Akatsuka
7d1374e019
implements nsStyleTextOverflow type properties animatable
2017-07-05 12:59:12 +09:00
Daisuke Akatsuka
6316b7aeb8
implements nsStyleCounterData type properties animatable
2017-07-05 12:58:10 +09:00
Daisuke Akatsuka
a155a6341d
implements nsStyleSides type properties animatable
2017-07-05 12:57:30 +09:00
Daisuke Akatsuka
34980689a7
implements nsStyleGridLine type properties animatable
2017-07-05 12:55:51 +09:00
Daisuke Akatsuka
983361eb0f
implements nsStyleCoord type properties animatable
2017-07-05 12:54:45 +09:00
Bobby Holley
c742ed31da
Use GC machinery rather than recursion for post-rule-tree-teardown node dropping.
...
MozReview-Commit-ID: BPC6u4sBNPR
2017-07-04 13:43:41 -07:00
Fernando Jiménez Moreno
fc8d0eeae0
stylo: Implement ServoStyleRule::SelectorMatchesElement
2017-07-04 13:13:48 +02:00
bors-servo
f380d1cfc1
Auto merge of #17600 - Manishearth:revert-cv, r=heycam
...
Revert "style: Cleanup duplicated code in the definition of ComputedValues."
This reverts commit 1c2fcb16ca
.
We're completely redoing the ComputedValues stuff on the gecko side, this makes it easier to deal with
cc @emilio
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17600 )
<!-- Reviewable:end -->
2017-07-03 22:50:42 -07:00
bors-servo
d52a08a5c5
Auto merge of #17568 - upsuper:user-select, r=Manishearth
...
Handle prefixed value of -moz-user-select properly
This is supposed to fix [bug 1374996](https://bugzilla.mozilla.org/show_bug.cgi?id=1374996 ).
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17568 )
<!-- Reviewable:end -->
2017-07-03 21:56:19 -07:00
Manish Goregaokar
6c94ace6e5
Revert "style: Cleanup duplicated code in the definition of ComputedValues."
...
This reverts commit 1c2fcb16ca
.
2017-07-03 21:48:12 -07:00
bors-servo
7a71035793
Auto merge of #17268 - servo:grid, r=wafflespeanut,canaltinova
...
Add support for subgrids and fix some other grid properties
This covers the `subgrid <line-name-lists>?` for `grid-template` (for gecko, and hence, stylo).
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17268 )
<!-- Reviewable:end -->
2017-07-03 17:10:25 -07:00
Nazım Can Altınova
3e49a8c80a
Fix serialization of grid-template
...
If both columns and rows are 'none', shorthand should serialize it as 'none / none'
instead of just 'none'.
2017-07-03 17:08:14 -07:00
Nazım Can Altınova
ba6641de58
Fix parsing of 'subgrid' and 'none' keywords in grid-template
2017-07-03 17:08:12 -07:00
Nazım Can Altınova
f7aac8d225
Fix parsing logic of grid-template property
...
Fist line names are parsed on the top of the function already and it shouldn't be parsed again.
2017-07-03 17:08:11 -07:00
Nazım Can Altınova
8827cb1440
Fix 'grid' shorthand serialization
2017-07-03 17:08:09 -07:00
Nazım Can Altınova
af96e09c7f
Fix parsing of grid-template shorthand
...
It should accept 'grid-template-rows / grid-template-columns values' values not
'grid-template-rows grid-template-columns values'.
2017-07-03 17:08:08 -07:00
Nazım Can Altınova
fd3b99027a
Prevent parsing 'none' keyword in grid-template's columns part
2017-07-03 17:08:06 -07:00
Nazım Can Altınova
f4eccdae3f
Fall back to an older version of the spec in TrackRepeat for the parity with gecko
2017-07-03 17:08:05 -07:00
Nazım Can Altınova
5eb33bac8f
Fix the serialization of TrackRepeat
...
It was printing `repeat(n, <line-names>)` for number TrackRepeat.
But it should just print n times <line-names> instead.
MozReview-Commit-ID: FEmL8O2osVb
2017-07-03 17:08:02 -07:00
Ravi Shankar
9d9d99ec25
Switch to GridTemplateComponent for subgrid line names
2017-07-03 17:08:00 -07:00
Ravi Shankar
8af912200c
Add support for subgrid line name lists
2017-07-03 14:57:17 -07:00
Emilio Cobos Álvarez
e2bf7d037a
stylo: properly handle ::before/::after rules applying to replaced elements.
...
Bug: 1376352
Reviewed-By: heycam
MozReview-Commit-ID: FO0TyWsPPG7
2017-07-03 13:03:24 +02:00
Hiroyuki Ikezoe
4331112846
reduce
2017-07-03 15:11:42 +09:00
bors-servo
545a53ccad
Auto merge of #17590 - emilio:gecko-inner, r=heycam
...
stylo: Fix StyleSheetInner/Stylesheet mapping
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1372041 and all the dependent/related issues.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17590 )
<!-- Reviewable:end -->
2017-07-02 07:00:39 -07:00
Emilio Cobos Álvarez
1263075776
stylo: Fix StyleSheetInner/Stylesheet mapping
...
The key of this patch is the split between Stylesheet and StylesheetContents.
Gecko will use StylesheetContents, which maps to a ServoStyleSheetInner.
2017-07-02 15:49:40 +02:00
bors-servo
edb0dafefc
Auto merge of #17576 - servo:derive-all-the-things, r=SimonSapin
...
Merge BoxShadowList and TextShadowList into ShadowList<T>
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17576 )
<!-- Reviewable:end -->
2017-07-02 05:59:34 -07:00
bors-servo
be58b99b06
Auto merge of #17562 - emilio:less-revalidation-stuff, r=bzbarsky
...
style: Don't treat some document-state-related pseudo-classes as revalidation selectors.
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17562 )
<!-- Reviewable:end -->
2017-07-01 08:13:58 -07:00
Anthony Ramine
80bd11bb8c
Merge BoxShadowList and TextShadowList into ShadowList<T>
2017-07-01 13:18:40 +02:00
Bobby Holley
6ade9c11ec
Allow StrongRuleNode drops after RuleTree destruction.
2017-06-30 23:35:40 -07:00
Bobby Holley
67cd974636
Use a different sentinel value to lock the free list.
...
We're going to use null to indicate that the final GC has already
occurred.
2017-06-30 23:35:32 -07:00
Bobby Holley
654661df36
Hook into the Gecko leak checking machinery.
...
Since we're going to stop asserting that all RuleNodes have been
destroyed by the time the RuleTree is destroyed, we want reliable leak
checking.
2017-06-30 23:35:22 -07:00
Bobby Holley
31b1233a73
Stop GCing before dropping the root rule node.
...
We already gc before dropping the RuleTree.
2017-06-30 23:35:14 -07:00
bors-servo
ece35f9caa
Auto merge of #17581 - mbrubeck:incremental, r=pcwalton
...
Fix incremental layout bugs for absolute and cleared elements
Fixes #17307 . <del>There were two underlying bugs:</del>
* <del>Nodes were not marked dirty when their style attribute changed.</del>
* BaseFlow flags set during flow construction could get out of sync with the element's style if repair_style was called.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17307
- [x] There are tests for these changes
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17581 )
<!-- Reviewable:end -->
2017-06-30 22:15:26 -07:00
Matt Brubeck
2aef2af9b8
Update flags for absolutely positioned elements on style changes
...
Fixes #17307 .
2017-06-30 22:14:28 -07:00
Nazım Can Altınova
b33545ca3b
Move Position::parse_legacy logic to LegacyPosition type
2017-06-30 17:54:04 -07:00