Commit graph

7924 commits

Author SHA1 Message Date
Matt Brubeck
36699c5748 Support vertical-align in geckolib 2016-05-16 11:34:02 -07:00
bors-servo
66acb1039e Auto merge of #11199 - servo:icon, r=metajack
On desktop, use the same app icon we use on Android

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11199)
<!-- Reviewable:end -->
2016-05-16 07:33:10 -07:00
Anthony Ramine
4af3e9028d Use JS_NewStringCopyN for the representation of interface objects
This removes the need for the final null byte and we can make
NonCallbackInterfaceObjectClass::new safe again I guess.
2016-05-16 15:22:07 +02:00
Anthony Ramine
d0b7a9f533 Update servo-glutin to 0.4.17 2016-05-16 15:14:31 +02:00
Anthony Ramine
27b00c62d9 Update cocoa to 0.3.3 2016-05-16 15:14:07 +02:00
bors-servo
2c674d0397 Auto merge of #11192 - perlun:remove-unused-imports, r=Manishearth
Removed unused imports

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11185
- [X] These changes do not require tests because it only removes dead code.

----

This fixes #11185.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11192)
<!-- Reviewable:end -->
2016-05-15 15:41:16 -07:00
Per Lundberg
2f7ed1d73e Removed unused imports
This fixes #11185.
2016-05-15 22:24:26 +03:00
bors-servo
f8fb33be42 Auto merge of #11187 - aneeshusa:rename-inherited-svg, r=emilio
Rename SVGInherited to InheritedSVG

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they simply rename a struct

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

I saw this listed on https://public.etherpad-mozilla.org/p/aligning-style-structs.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11187)
<!-- Reviewable:end -->
2016-05-14 16:45:11 -07:00
Aneesh Agrawal
5457169871 Rename SVGInherited to InheritedSVG 2016-05-14 17:44:53 -04:00
bors-servo
7bede60272 Auto merge of #10668 - dzbarsky:read_pixels, r=emilio
Implement WebGLRenderingContextBase::readPixels().

@emilio
Anything obviously wrong stick out to you? Haven't had a chance to debug why tests/wpt/web-platform-tests/webgl/conformance-1.0.3/conformance/programs/gl-bind-attrib-location-long-names-test.html and co. get the wrong results from ReadPixels.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10668)
<!-- Reviewable:end -->
2016-05-14 14:13:44 -07:00
bors-servo
dfd0883663 Auto merge of #11183 - servo:rustup, r=emilio
Update to Rust 1.10.0-nightly (2b79e05a0 2016-05-13)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11183)
<!-- Reviewable:end -->
2016-05-14 12:52:07 -07:00
Anthony Ramine
78e3b1a326 Update to Rust 1.10.0-nightly (2b79e05a0 2016-05-13) 2016-05-14 21:16:48 +02:00
bors-servo
e2990766dc Auto merge of #11180 - mbrubeck:text-cleanup, r=pcwalton
Minor cleanup and optimizations in glyph/style caching

Gets rid of some unnecessary String and Arc clones during text shaping and style matching.

r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11180)
<!-- Reviewable:end -->
2016-05-14 09:06:53 -07:00
bors-servo
d6509dc4c6 Auto merge of #11178 - mrmiywj:use-doc-base-URL, r=nox
Make Node::BaseURI use the document's base URL

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11145  (github issue number if applicable).

Either:
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11178)
<!-- Reviewable:end -->
2016-05-14 01:12:32 -07:00
mrmiywj
6ade433196 Make Node::BaseURI use the document's base URL
update expectations
2016-05-14 14:44:06 +08:00
Matt Brubeck
dc6be7bba5 Remove unnecessary clone in LRUCache::touch 2016-05-13 18:20:59 -07:00
Matt Brubeck
d2717c4475 Eliminate unneeded clones in find_or_create
...and use it to eliminate duplicate hash lookups and string copies in shape_text.
2016-05-13 18:20:25 -07:00
Matt Brubeck
1c5ec6f3ec Make some Font fields private 2016-05-13 16:33:20 -07:00
Matt Brubeck
4361f92067 Remove unnecessary ServoFont type alias 2016-05-13 16:20:59 -07:00
Matt Brubeck
45dc587d42 Remove unnecessary pub 2016-05-13 16:18:47 -07:00
Connor Imes
88ea598211 Update hbs sys dependencies 2016-05-13 10:52:15 -05:00
Ms2ger
735480c184 Stop using JSAutoRequest. 2016-05-13 15:34:38 +02:00
bors-servo
221db56b08 Auto merge of #11155 - emilio:codegen-dict-keyword, r=Ms2ger
codegen: Fix dictionary handling and semantics

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11152 (github issue number if applicable).

Either:
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

Fixes #11152

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11155)
<!-- Reviewable:end -->
2016-05-13 02:47:08 -07:00
Emilio Cobos Álvarez
91101f6226
codegen: Throw a more descriptive invalid enum message 2016-05-13 11:44:39 +02:00
Emilio Cobos Álvarez
e50d4b7624
codegen: Throw on an invalid enum value when appropiate 2016-05-13 11:44:38 +02:00
Emilio Cobos Álvarez
093f5c01e4
codegen: add tests for non-nullable non-required values 2016-05-13 09:42:59 +02:00
Emilio Cobos Álvarez
92ba0b9c39
codegen: Don't unconditionally set non-required dictionary attributes 2016-05-13 09:42:51 +02:00
David Zbarsky
2f416baa11 Implement ReadPixels 2016-05-12 23:50:36 -07:00
Emilio Cobos Álvarez
f6434a9790
gfx: Add expect messages to FontCacheThread::exit()
One of these two unwraps is the one that is causing most occurrences
of #8815.

I'd go with removing the second unwrap entirely, but let's get some
debug info first, since it might probably be a race.
2016-05-13 01:15:35 +02:00
bors-servo
1e8ddba3e8 Auto merge of #11159 - mbrubeck:test-warnings, r=emilio
Fix warnings in unit tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11159)
<!-- Reviewable:end -->
2016-05-12 13:12:44 -07:00
Matt Brubeck
96c69f852c Fix warnings in unit tests 2016-05-12 12:22:00 -07:00
Emilio Cobos Álvarez
f893a2eaac
bindings: Add test for keywords in dictionaries 2016-05-12 20:39:31 +02:00
bors-servo
fe3821ff14 Auto merge of #11154 - nox:zealot, r=Ms2ger
Support GC zeal

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11154)
<!-- Reviewable:end -->
2016-05-12 09:42:21 -07:00
bors-servo
42141870e7 Auto merge of #10714 - KiChjang:user-interaction-task, r=Ms2ger
Implement user interaction task source

Part of #7959.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10714)
<!-- Reviewable:end -->
2016-05-12 09:00:14 -07:00
Anthony Ramine
afd29b7c1e Support GC zeal 2016-05-12 16:44:40 +02:00
Keith Yeung
f60de52aae Fire 'select' event in SetSelectionRange 2016-05-12 10:44:04 -04:00
bors-servo
bca625bd8e Auto merge of #11006 - ConnorGBrewster:history_events, r=asajeffrey
Implement navigation events

fixes #11005

Events:
 * `PopStateEvent`
 * `HashChangeEvent`
 * `PageTransitionEvent`

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11006)
<!-- Reviewable:end -->
2016-05-12 07:27:12 -07:00
Emilio Cobos Álvarez
203898c941
codegen: Use the non-mangled name in set_dictionary_property
Fixes #11152
2016-05-12 15:39:54 +02:00
bors-servo
d55884d73e Auto merge of #11148 - mbrubeck:warnings, r=metajack
Fix some warnings

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11148)
<!-- Reviewable:end -->
2016-05-12 06:19:10 -07:00
bors-servo
9eb7162b8a Auto merge of #11146 - mbrubeck:always-be-updating, r=metajack
Update image, hyper, gleam, flate2, threadpool, string_cache, num_cpus

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11146)
<!-- Reviewable:end -->
2016-05-12 05:28:12 -07:00
bors-servo
1a834b5b83 Auto merge of #11140 - asajeffrey:webdriver-pipeline-wait-for-document-ready, r=jgraham
When webdriver is getting a pipeline id, it should wait for the pipeline document to be ready

Thank you for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete, and replace `__` with appropriate data:
- [X] `./mach build` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11117 (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only impact webdriver

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11140)
<!-- Reviewable:end -->
2016-05-12 03:46:59 -07:00
bors-servo
4a274cf580 Auto merge of #11142 - kaksmet:another-justify-fix, r=mbrubeck
Fix inline size adjustment when stripping trailing whitespace from fragments

The whitespace range was not properly shifted which caused us to adjust the fragment's inline size by the advance of a different set of characters.
This was causing justified text lines to be too long or too short.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11142)
<!-- Reviewable:end -->
2016-05-12 02:56:21 -07:00
bors-servo
695a2559a8 Auto merge of #11132 - mbrubeck:workqueue-panic, r=larsbergstrom
Fix integer overflow in next_power_of_two

This causes a panic (debug) or incorrect results (release) when initializing a work queue with thread_count = 1.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11132)
<!-- Reviewable:end -->
2016-05-12 00:35:05 -07:00
bors-servo
e2a5b1cb71 Auto merge of #11129 - KiChjang:fetch-read-block, r=jdm
Use read_block in http_network_fetch

Previously the commented out code was not working because there was a deadlock situation where `res_body` is being locked and borrowed to read the inner `body` if it is a `ResponseBody::Receiving` variant, and then locked and borrowed mutably to change `res_body` to `ResponseBody::Done`.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11129)
<!-- Reviewable:end -->
2016-05-11 23:44:15 -07:00
bors-servo
f12869d2a7 Auto merge of #11127 - heycam:text-align, r=bholley
Support text-align in geckolib.

We don't yet support the 'unsafe' keyword, which isn't in a spec yet, and which would require slightly more complex parsing.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11127)
<!-- Reviewable:end -->
2016-05-11 22:53:56 -07:00
bors-servo
cf2b9401ef Auto merge of #11123 - larsbergstrom:disable_codgen_units, r=pcwalton
Disable codegen-units due to performance regressions

r? @pcwalton

Fixes #11102.

CC @alexcrichton, @nmatsakis - basically, `codegen-units` is nice for local compilation speedups but results in too many perf regressions to keep it for release builds.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11123)
<!-- Reviewable:end -->
2016-05-11 22:03:36 -07:00
Connor Brewster
11dd0d7c46 add popstateevent, hashchangeevent, pagetransitionevent 2016-05-11 22:11:46 -06:00
Matt Brubeck
d560ae79b4 Fix some warnings 2016-05-11 21:03:12 -07:00
bors-servo
685dc99e3e Auto merge of #11044 - ConnorGBrewster:page_to_browsing_context, r=jdm
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
2016-05-11 20:53:02 -07:00
Matt Brubeck
d54f489c33 Update image, hyper, gleam, flate2, threadpool, string_cache, num_cpus 2016-05-11 20:37:27 -07:00