Commit graph

32232 commits

Author SHA1 Message Date
bors-servo
4e2f8ec8e1
Auto merge of #20227 - upsuper:in-firefox-build, r=jdm
Fix `mach build` for Servo in Firefox tree

Running `mach build` in servo directory in Firefox tree currently doesn't work due to several errors when importing modules.

First error:
```text
Traceback (most recent call last):
  File "mach", line 93, in <module>
    main(sys.argv)
  File "mach", line 23, in main
    mach = mach_bootstrap.bootstrap(topdir)
  File "servo/python/mach_bootstrap.py", line 280, in bootstrap
    mach.load_commands_from_file(os.path.join(topdir, path))
  File "servo/python/_virtualenv/Lib/site-packages/mach/main.py", line 265, in load_commands_from_file
    imp.load_source(module_name, path)
  File "servo/python/servo/testing_commands.py", line 42, in <module>
    from update import updatecommandline
  File "servo/../testing/web-platform/update/__init__.py", line 17, in <module>
    from wptrunner.update import setup_logging, WPTUpdate
  File "servo/../testing/web-platform/tests/tools/wptrunner/wptrunner/update/__init__.py", line 8, in <module>
    from update import WPTUpdate
  File "servo/../testing/web-platform/tests/tools/wptrunner/wptrunner/update/update.py", line 8, in <module>
    from .. import environment as env
  File "servo/../testing/web-platform/tests/tools/wptrunner/wptrunner/environment.py", line 12, in <module>
    from wptserve.handlers import StringHandler
ImportError: No module named wptserve.handlers
```

Second error:
```text
Traceback (most recent call last):
  File "mach", line 93, in <module>
    main(sys.argv)
  File "mach", line 23, in main
    mach = mach_bootstrap.bootstrap(topdir)
  File "servo/python/mach_bootstrap.py", line 291, in bootstrap
    mach.load_commands_from_file(os.path.join(topdir, path))
  File "servo/python/_virtualenv/Lib/site-packages/mach/main.py", line 265, in load_commands_from_file
    imp.load_source(module_name, path)
  File "servo/python/servo/testing_commands.py", line 43, in <module>
    from servo_tidy import tidy
  File "servo/python/tidy/servo_tidy/tidy.py", line 34, in <module>
    from wptmanifest import parser, node
ImportError: No module named wptmanifest
```

The two commits fix these two errors respectively.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20227)
<!-- Reviewable:end -->
2018-03-07 09:19:25 -05:00
Anthony Ramine
90b23963b7 Introduce #[css(if_empty = "…", iterable)] 2018-03-07 13:07:13 +01:00
Anthony Ramine
92f116a95c Derive ToCss for TemplateAreas 2018-03-07 12:32:53 +01:00
Xidorn Quan
4c240eb632 Don't import wptmanifest when in firefox tree. 2018-03-07 17:22:12 +11:00
Xidorn Quan
29d9c85c56 Add wptserve into python import paths. 2018-03-07 17:14:25 +11:00
bors-servo
46ad9f2a30
Auto merge of #20226 - glennw:update-wr-nv-clip, r=jdm
Update WR (nVidia/ANGLE workaround, vertex shader optimizations).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20226)
<!-- Reviewable:end -->
2018-03-07 00:54:10 -05:00
Glenn Watson
a51bad51cd Update WR (nVidia/ANGLE workaround, vertex shader optimizations). 2018-03-07 15:52:59 +10:00
bors-servo
9eb417528b
Auto merge of #19947 - o0Ignition0o:mach_run_nightly, r=jdm
Add a --nightly | -n flag to mach run commands for linux

First tries to download and extract a specific nightly version to run mach commands against.

<!-- Please describe your changes on the following line: -->
I chose to split the Pull requests for each platform to avoid submitting a huge one, and to make sure I get the logic right.
I'm able to download / extract a nightly version, and I keep nightly versions in the target folder.
Windows and Mac OS support will be filed in separate PRs.
This is part of step two for #19505

The mentor on the issue is jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is part of a ./mach command.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19947)
<!-- Reviewable:end -->
2018-03-06 23:47:08 -05:00
bors-servo
3b96fb2cbe
Auto merge of #20222 - upsuper:chrome-thread-pool, r=bholley
Do not disable thread pool in the parent process

This is the Servo side change of [bug 1375913](https://bugzilla.mozilla.org/show_bug.cgi?id=1375913).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20222)
<!-- Reviewable:end -->
2018-03-06 17:54:34 -05:00
Xidorn Quan
20ec610e68 Do not disable thread pool in the parent process. 2018-03-07 09:40:33 +11:00
o0Ignition0o
10822ce730 Add a --nightly | -n flag to download and extract a specific nightly version to run mach commands against. This currently only work on linux, but windows and mac os support will follow in subsequent PRs. 2018-03-06 23:09:50 +01:00
bors-servo
26d2e77410
Auto merge of #20214 - mrobinson:stop-using-using-localclip-roundedrect, r=glennw
Stop using LocalClip::RoundedRect

We would like to remove this functionality from WebRender, so convert
its use to clip scroll nodes. This change also removes the redundant
BlocBlockStackingContextType in favor of Option<StackingContextType>,
which is just as expressive. This simplifies the code a bit.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they should not change behavior.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20214)
<!-- Reviewable:end -->
2018-03-06 15:53:11 -05:00
Martin Robinson
e100a72122 Stop using LocalClip::RoundedRect
We would like to remove this functionality from WebRender, so convert
its use to clip scroll nodes. This change also removes the redundant
BlocBlockStackingContextType in favor of Option<StackingContextType>,
which is just as expressive. This simplifies the code a bit.
2018-03-06 21:26:22 +01:00
bors-servo
c8eceb90a1
Auto merge of #20213 - nical:tidy-alphabetical-bs, r=jdm
Add the option in servo-tidy to not check for alphabetical ordering.

<!-- Please describe your changes on the following line: -->

An option to disable checking for alphabetical ordering of use/mod/extern crate statements in servo-tidy.

These checks are still enabled by default but WebRender will turn them off.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it doesn't affect servo.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20213)
<!-- Reviewable:end -->
2018-03-06 13:39:59 -05:00
bors-servo
96b9000fa2
Auto merge of #20212 - mkollaro:webidlcmake, r=jdm
Regenerate all WebIDLs when one of them changes

WebIDL files have dependencies between each other, but cmake doesn't have any
information about them. This can cause it to not update all the changed bindings
when switching branches.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20169

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it's a minor change in the build dependencies.
Switching between two of my branches was previously failing because a change in WebGL1 bindings didn't re-generate the WebGL2 bindings. I verified that it works with this patch.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20212)
<!-- Reviewable:end -->
2018-03-06 12:37:58 -05:00
bors-servo
785b7c7775
Auto merge of #20211 - servo:derive-all-the-things, r=emilio
Improve #[derive(ToCss)]

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20211)
<!-- Reviewable:end -->
2018-03-06 11:42:58 -05:00
bors-servo
94a6c2c429
Auto merge of #20181 - fabricedesre:end-load-pageshow, r=jdm
Fire the pageshow event at the end of the page load

<!-- Please describe your changes on the following line: -->
This implements step 8 of https://html.spec.whatwg.org/multipage/parsing.html#the-end

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because I could not find a wpt test for that, which is strange. I likely missed it :(

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20181)
<!-- Reviewable:end -->
2018-03-06 10:49:51 -05:00
Fabrice Desré
3dd015b2d9 Fire the pageshow event at the end of the page load r=jdm 2018-03-06 07:24:24 -08:00
Nicolas Silva
29a1617e27 Add the option in servo-tidy to not check for alphabetical ordering. 2018-03-06 16:10:30 +01:00
bors-servo
f5037cf621
Auto merge of #20144 - mkollaro:gettexparameter, r=jdm
Add WebGL function glGetTexParameter

<!-- Please describe your changes on the following line: -->
Add WebGL function glGetTexParameter

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #10209

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20144)
<!-- Reviewable:end -->
2018-03-06 09:48:56 -05:00
Martina Kollarova
288ef50fb7 Add WebGL function glGetTexParameter
Set the expected result of the test `tex-input-validation.html` to CRASH, since
that is caused by unrelated problems. The test was previously not executing
completely, because it stopped when it didn't find the implementation of
getTexParameter.
2018-03-06 15:28:10 +02:00
Martina Kollarova
25b95aa1a1 Regenerate all WebIDLs when one of them changes
WebIDL files have dependencies between each other, but cmake doesn't have any
information about them. This can cause it to not update all the changed bindings
when switching branches.
2018-03-06 14:55:53 +02:00
Anthony Ramine
88685be649 Don't use SequenceWriter if there is a single field to serialise 2018-03-06 13:14:26 +01:00
bors-servo
226d9a5b0e
Auto merge of #20210 - emilio:justify-items-kinda-sucks, r=Manishearth
style: Add a comment about the weird setup for justify-items.

And derive ToCss while at it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20210)
<!-- Reviewable:end -->
2018-03-06 05:29:17 -05:00
Emilio Cobos Álvarez
a5fc724349
style: Add a comment about the weird setup for justify-items.
And derive ToCss while at it.
2018-03-06 11:28:41 +01:00
Anthony Ramine
85950a801f Move #[css(iterable)] on fields rather than variants 2018-03-06 11:08:19 +01:00
Anthony Ramine
f5393cef8d Add some assertions for #[derive(ToCss)] on enums 2018-03-06 11:08:19 +01:00
Anthony Ramine
3b31ec36f1 Don't use Ident for #[css(function)]
CSS identifiers aren't Rust identifiers.
2018-03-06 11:08:19 +01:00
Anthony Ramine
529a30a682 Extract variant code to its own function in style_derive::to_css 2018-03-06 11:08:19 +01:00
Anthony Ramine
14dd4217fa Qualify path to ToCss in #[derive(ToCss)] 2018-03-06 11:08:19 +01:00
bors-servo
17b5a8332b
Auto merge of #20200 - servo:derive-all-the-things, r=emilio
Derive some more ToCss stuff again

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20200)
<!-- Reviewable:end -->
2018-03-06 03:33:18 -05:00
bors-servo
b7a8d78972
Auto merge of #20209 - servo:jdm-patch-6, r=glennw
Fix exception when updating WPT metadata.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20209)
<!-- Reviewable:end -->
2018-03-05 22:42:12 -05:00
Josh Matthews
00738bf1f6
Fix exception when updating WPT metadata. 2018-03-05 22:23:09 -05:00
bors-servo
2d3771daab
Auto merge of #20206 - servo:jdm-patch-2, r=nox
Ensure default paths are set when updating WPT metadata.

This fixes https://github.com/w3c/web-platform-tests/issues/9819 and will allow our nightly upstream sync to complete.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20206)
<!-- Reviewable:end -->
2018-03-05 14:47:38 -05:00
Josh Matthews
ac156f74a9
Ensure default paths are set when updating WPT metadata. 2018-03-05 14:37:16 -05:00
bors-servo
e20d338fed
Auto merge of #20202 - servo:fork-blurmac, r=jdm
Update devices and fork blurmac

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20202)
<!-- Reviewable:end -->
2018-03-05 13:49:02 -05:00
bors-servo
e682862906
Auto merge of #20203 - emilio:backout-toml-bump, r=backout
Revert "Auto merge of #20201 - Eijebong:bump, r=nox"

This reverts commit 05dcfe2983, reversing
changes made to 9dbb69868c.

This broke autoland because we don't build components/style/build_gecko.rs on
Servo's CI.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20203)
<!-- Reviewable:end -->
2018-03-05 12:27:46 -05:00
Simon Sapin
917ccaf268 Update devices and fork blurmac 2018-03-05 17:56:21 +01:00
Emilio Cobos Álvarez
39fb9e3a51
Revert "Auto merge of #20201 - Eijebong:bump, r=nox"
This reverts commit 05dcfe2983, reversing
changes made to 9dbb69868c.

This broke autoland because we don't build components/style/build_gecko.rs on
Servo's CI.
2018-03-05 17:30:36 +01:00
bors-servo
05dcfe2983
Auto merge of #20201 - Eijebong:bump, r=nox
Bump some dependencies now that metadeps is out of the way ᕕ( ᐛ )ᕗ

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20201)
<!-- Reviewable:end -->
2018-03-05 10:22:24 -05:00
Bastien Orivel
f09173506f Update error-chain to 0.11 2018-03-05 16:19:24 +01:00
Bastien Orivel
3fd8b63069 Update toml to 0.4 2018-03-05 16:19:09 +01:00
Anthony Ramine
2aa5f68c92 Derive ToCss for FontSize 2018-03-05 15:53:16 +01:00
Anthony Ramine
ca45695db1 Introduce #[css(skip)] 2018-03-05 15:53:15 +01:00
bors-servo
9dbb69868c
Auto merge of #20199 - Eijebong:metadeps, r=emilio
Remove metadeps from the dependency tree

🎉

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20199)
<!-- Reviewable:end -->
2018-03-05 09:20:33 -05:00
bors-servo
7931df716d
Auto merge of #20198 - servo:derive-all-the-things, r=emilio
Use darling::util::Override in #[derive(ToCss)]

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20198)
<!-- Reviewable:end -->
2018-03-05 08:24:35 -05:00
Bastien Orivel
fdd7f91f86 Remove metadeps from the dependency tree 2018-03-05 13:47:46 +01:00
Anthony Ramine
c4cfb127b8 Use darling::util::Override in #[derive(ToCss)] 2018-03-05 13:23:33 +01:00
bors-servo
266258331e
Auto merge of #20196 - servo:derive-all-the-things, r=emilio
Derive some more ToCss implementations

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20196)
<!-- Reviewable:end -->
2018-03-05 06:03:53 -05:00
Anthony Ramine
75b05c518d Derive ToCss for DeclaredValueOwned rather than DeclaredValue 2018-03-05 12:02:32 +01:00