Commit graph

285 commits

Author SHA1 Message Date
Matt Brubeck
377bcb53b9 Update comments about Node::layout_data 2014-07-24 22:42:28 -07:00
Bruno de Oliveira Abinader
7457750901 Prefer direct member access than type_id() 2014-07-23 09:12:55 -04:00
glennw
c3e6d956ff Merge pull request #2844 from glennw/atom-element
Convert element name to be stored as atom instead of string.
2014-07-18 10:13:24 +10:00
Glenn Watson
560e380767 Fix comments and variable names for atom wrapper. 2014-07-17 08:31:31 +10:00
Bruno de Oliveira Abinader
aea4ccf849 Added 'parent is/was in tree' param to bind_to_tree/unbind_from_tree
According to a talk with Ms2ger, both bind_to_tree / unbind_from_tree
should be called regardless if the tree is part of a Document. This
information is now passed as a parameter to their respective virtual
methods.
2014-07-16 08:59:56 -04:00
Glenn Watson
dddd3346a6 Convert element name to be stored as atom instead of string. 2014-07-16 07:33:29 +10:00
Ms2ger
829259fb79 Introduce abstractions for global scopes.
Part of #2811.
2014-07-15 15:33:57 +02:00
Ms2ger
439bc78cab Return a Temporary from *Binding::Wrap.
Returning a JS<T> is GC-unsafe.

This commit also includes some cleanup around Node and Document reflection.
2014-07-10 16:45:41 +02:00
Patrick Walton
78eeb8e2e7 Revert "Implement Element.matches()."
This reverts commit b6edd5318f.
2014-07-09 14:58:38 -07:00
Tetsuharu OHZEKI
b6edd5318f Implement Element.matches(). 2014-07-05 23:27:40 +09:00
Ms2ger
362feaa4a9 Mark some unused fields. 2014-06-28 17:08:57 +02:00
Ms2ger
924031135e Remove some into_owned calls. 2014-06-28 17:07:47 +02:00
Manish Goregaokar
f5b5b337d3 Upgrade to latest Rust. 2014-06-27 18:50:32 -06:00
Tetsuharu OHZEKI
975fee82da Remove needless mutabilities from script crate. 2014-06-22 21:22:58 +09:00
Ms2ger
c90a8529c5 Use internal mutability for Attr::value. 2014-06-22 20:39:21 +09:00
Manish Goregaokar
53d0e4ec04 Use Traceable for NodeFlags 2014-06-16 22:04:17 +05:30
Ms2ger
bb0efdd5a2 Make some locals immutable. 2014-06-13 21:41:28 +02:00
bors-servo
7ed5041891 auto merge of #2649 : ebalint/servo/2580_JS_T_unrooted_replace, r=jdm
removed .clone() calls
modified from_rooted method parameter: T to &T
2014-06-13 14:33:03 -04:00
Ms2ger
e09ed14362 Remove Reflectable::mut_reflector. 2014-06-13 19:19:58 +02:00
Edit Balint
bda29ade09 Replace uses of JS<T>.unrooted() with JS::from_rooted #2580 2014-06-13 19:06:28 +02:00
bors-servo
da668f53d9 auto merge of #2616 : Ms2ger/servo/attrvalue, r=jdm
Obsoletes #2073.
2014-06-13 11:41:13 -04:00
Ms2ger
0803e5d0ac Implement support for parsed attributes.
This commit is heavily based on earlier work by Bruno Abinader in #2073.
2014-06-13 14:07:49 +02:00
Tetsuharu OHZEKI
28f8d16c87 Fix the assertion failure with inserting node contains child which has id into the document
https://github.com/mozilla/servo/issues/2630
2014-06-13 20:36:27 +09:00
bors-servo
897e39dcf3 auto merge of #2640 : Ms2ger/servo/derefmut, r=jdm 2014-06-11 17:19:51 -04:00
Ms2ger
687722da2d Pass immutable self to Node::{SetNodeValue, SetTextContent}. 2014-06-11 22:53:53 +02:00
bors-servo
baa97fe6e5 auto merge of #2632 : brunoabinader/servo/document-queryselectorall, r=Ms2ger
Spec:
http://dom.spec.whatwg.org/#dom-parentnode-queryselectorall

Closes #851.
2014-06-11 16:05:04 -04:00
Ms2ger
23a6b6823b Use internal mutability for Document::{quirks_mode, encoding_name}. 2014-06-11 19:51:08 +02:00
Ms2ger
288e0bc877 Use internal mutability for CharacterData::data. 2014-06-11 19:51:07 +02:00
Ms2ger
d230077f9f Stop mutating Element::namespace. 2014-06-11 19:51:07 +02:00
Ms2ger
6df6a7d512 Use internal mutability for Node.flags. 2014-06-11 19:51:07 +02:00
Bruno de Oliveira Abinader
b0e8f7cebf Added Node's query_selector_all helper function 2014-06-10 12:11:20 -04:00
Patrick Walton
7350cfb004 script: Inline is_element_for_layout and friends.
8% improvement on style recalc on Wikipedia.
2014-06-09 19:15:56 -07:00
Ms2ger
efe69f3a82 Make Attr::value private. 2014-06-08 17:09:22 +02:00
bors-servo
f1194fc85b auto merge of #2607 : bjz/servo/leeeeeak, r=jdm
Introduced by yours-truly in 7212c3573e

Oopsie.
2014-06-06 17:49:21 -04:00
bors-servo
b52fbe0a5f auto merge of #2591 : brunoabinader/servo/document-queryselector-v3, r=jdm
This is a subtask for #2254 & #2576.

Spec:
http://dom.spec.whatwg.org/#dom-parentnode-queryselector
2014-06-06 17:22:25 -04:00
Bruno de Oliveira Abinader
c89112dabf Fixed traversal issues 2014-06-06 13:40:08 -07:00
Brendan Zabarauskas
bf21217504 Fix leak
Introduced by yours-truly in 7212c3573e

Oopsie.
2014-06-06 12:26:30 -07:00
Tetsuharu OHZEKI
2aa1554b0c Remove needless '&self mut' from VirtualMethods trait. 2014-06-07 00:58:43 +09:00
Bruno de Oliveira Abinader
249c484c24 Implement querySelector for Document 2014-06-05 16:54:26 -07:00
Bruno de Oliveira Abinader
f78d04b620 Implement TNode for JS<Node> 2014-06-05 16:54:26 -07:00
Brendan Zabarauskas
7212c3573e Use bitflags! for NodeFlags 2014-06-05 15:43:57 -07:00
Jack Moffitt
629c4c6afe Upgrade Rust. 2014-06-05 09:58:59 -06:00
bors-servo
246c9759be auto merge of #2555 : brson/servo/warnings, r=metajack
Depends on https://github.com/mozilla-servo/rust-fontconfig/pull/19, https://github.com/mozilla-servo/rust-harfbuzz/pull/21, https://github.com/mozilla-servo/rust-hubbub/pull/23, https://github.com/mozilla-servo/rust-layers/pull/68, https://github.com/mozilla-servo/sharegl/pull/29, https://github.com/mozilla-servo/rust-mozjs/pull/85.
2014-06-02 20:46:25 -04:00
Brian Anderson
c85e2c9594 Eliminate some warnings 2014-06-02 17:42:10 -07:00
Ms2ger
97efd122a3 Rename BindingDeclarations to Bindings. 2014-06-02 19:48:42 +02:00
Ms2ger
c675421279 Remove low-level pointer stitching methods from Node.
There is no good reason for the additional abstraction here.

This commit also adds assertions that were suggested in XXX comments.
2014-06-02 13:33:59 +02:00
Tetsuharu OHZEKI
3819ebb740 Remove needless '&mut self' from node.rs. 2014-06-02 04:28:04 +09:00
Tetsuharu OHZEKI
25a6deda4d Remove needless lifetime parameter from LayoutNodeHelpers. 2014-06-02 00:40:09 +09:00
Tetsuharu OHZEKI
106627e6eb "JS<T>::from_raw" should accept "*T" instead of "*mut T" 2014-05-31 01:10:19 +09:00
Tetsuharu OHZEKI
b4463c1fb2 Use Cell/RefCell for interior mutability of Node. 2014-05-30 03:54:24 +09:00