Commit graph

7310 commits

Author SHA1 Message Date
bors-servo
3ad1b9134f Auto merge of #10512 - KiChjang:base-element-attr, r=Ms2ger
Implement HTMLBaseElement attributes

The remaining test failure in `base_multiple.html` looks like there's a problem with the test itself (it does not have a `<base>` tag at all).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10512)
<!-- Reviewable:end -->
2016-04-13 18:51:42 +05:30
Keith Yeung
4a1eb47937 Implement HTMLBaseElement attributes 2016-04-13 08:57:17 -04:00
bors-servo
9954ee1334 Auto merge of #10564 - Ms2ger:url-clone, r=Manishearth
Remove a pointless Url clone.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10564)
<!-- Reviewable:end -->
2016-04-13 18:11:11 +05:30
bors-servo
0e953618d1 Auto merge of #10524 - mauricioc:keyword_values, r=SimonSapin
Add some Gecko-supported CSS keyword properties

I have added all properties that are marked with (exactly) PARSE_VALUES and H | K in [0] to properties.mako.rs, as part of #10408. A few questions and remarks:

* I created a SVG style struct. Should those properties be somewhere else instead?
* I did not know what to do with ime-mode (which lives in nsStyleUIReset), so I did not include it.
* Servo already has a -servo-overflow-clip-box property, while Gecko has overflow-clip-box. Should those be consolidated?
* There is a code comment (marked with XXX) about scroll-snap-type-y. Should I add a <%self:longhand> template tag for that, similar to the one in overflow-y?

I am getting error E0053 while trying to run "./mach build-geckolib -r" on master, and the bholley/stylo branch doesn't support the products keyword argument yet, so I haven't exactly checked this compiles properly. It doesn't add any new compilation errors before the E0053 one, though.

Let me know if some extra information (say, a table saying where each property went) would be useful in the review process. r? @bholley

[0] https://docs.google.com/spreadsheets/d/1pSw2SjNxXZAQ19SAuNKcs5u4S7Zkc1ebEOkSP4oITUQ/edit?pref=2&pli=1

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10524)
<!-- Reviewable:end -->
2016-04-13 17:31:12 +05:30
bors-servo
650e3502f6 Auto merge of #10562 - servo:gcc, r=Manishearth
Update gcc.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10562)
<!-- Reviewable:end -->
2016-04-13 16:49:59 +05:30
Ms2ger
b032a7894a Remove a pointless Url clone. 2016-04-13 12:45:21 +02:00
bors-servo
9b57d8d686 Auto merge of #8658 - jdm:origin2, r=Ms2ger+jdm
Implement origin concept and browsing contextless documents.

These pave the way for implementing other parts of specifications more thoroughly.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8658)
<!-- Reviewable:end -->
2016-04-13 16:09:38 +05:30
Josh Matthews
90454c279d Use origin when manipulating cookies. 2016-04-13 12:07:05 +02:00
Josh Matthews
fa42b452a0 Use origin for document.domain. 2016-04-13 12:07:04 +02:00
bors-servo
aec297565b Auto merge of #10554 - asajeffrey:fast-fail-handle-script-loaded-url-in-iframe, r=Ms2ger
Fast fail_handle_script_loaded_url_in_iframe_msg

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10554)
<!-- Reviewable:end -->
2016-04-13 15:23:51 +05:30
Ms2ger
73def51221 Update gcc. 2016-04-13 11:11:40 +02:00
Josh Matthews
a8233a135e Implement origin concept. 2016-04-13 10:37:55 +02:00
bors-servo
e8e354d5d3 Auto merge of #10497 - kaksmet:multiprocess-prefs, r=pcwalton
Share prefs to content processes

Without this `./mach run -b -- -M` would start fine but navigating to a site would fail with:

`thread 'ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }' panicked at 'assertion failed: mozbrowser_enabled()', /Users/ulf/Documents/Code/servo/components/script/dom/htmliframeelement.rs:163`

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10497)
<!-- Reviewable:end -->
2016-04-13 07:51:54 +05:30
bors-servo
7e63c1be63 Auto merge of #10486 - notriddle:overflow_premature_clip, r=pcwalton
Take transform:translate into account when computing clipping regions.

Note that this only works for translation; a more general fix would
require major changes to how display lists work.

Closes #10431?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10486)
<!-- Reviewable:end -->
2016-04-13 07:12:38 +05:30
bors-servo
bbcbd35095 Auto merge of #10546 - stjepang:fix-typo-in-jsrs, r=Ms2ger
Fix typo: `cannot not outlive` -> `cannot outlive`

A `Root` cannot outlive the `RootCollection` it is recorded in.
The docs were saying otherwise.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10546)
<!-- Reviewable:end -->
2016-04-13 06:30:59 +05:30
bors-servo
9fb5703c6d Auto merge of #10510 - frewsxcv:rowindex, r=KiChjang
Implement `rowIndex` property on `<tr>`.

Part of https://github.com/servo/servo/issues/10509.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10510)
<!-- Reviewable:end -->
2016-04-13 04:25:20 +05:30
Mauricio Collares
002b4af8b9 Add some Gecko-supported CSS keyword properties 2016-04-12 18:52:44 -03:00
Alan Jeffrey
6c5b2167f5 Fast-fail handle_script_loaded_url_in_iframe_msg (fixes #10416) 2016-04-12 16:43:28 -05:00
Michael Howell
6c9efbf383 Take transform:translate into account when computing clipping regions.
Note that this only works for translation; a more general fix would
require major changes to how display lists work.

Closes #10431?
2016-04-12 14:39:13 -07:00
bors-servo
155e4052d1 Auto merge of #10545 - amarant:unreachable-codegen, r=Ms2ger
remove unreachable code in codegen

code is unreachable after return, and identical to the upper block

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10545)
<!-- Reviewable:end -->
2016-04-13 03:05:33 +05:30
bors-servo
a4991f536c Auto merge of #10488 - perlun:remove-t-prefix-on-style-structs, r=SimonSapin
Removed the T prefix for the style traits

More work as described in #10185.

I am getting _extremely_ weird compile-time errors with this one, when it's trying to expand the `lazy_static!` macro. I think I'll need help getting that part sorted out. The rest should be pretty OK.

Anyone has ideas on how to resolve it?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10488)
<!-- Reviewable:end -->
2016-04-13 02:24:25 +05:30
bors-servo
421dcc92f0 Auto merge of #10538 - izgzhen:performance_timing, r=Ms2ger
Improve PerformanceTiming Interface

Solving https://github.com/servo/servo/issues/10428

- Fix timing precision in old `update_with_current_time`
- Correct time unit in `navigation_start`
- Add `LoadEventStart` and `LoadEventEnd` timing properties

There are still many properties left unimplemented. I tend to leave the for future PRs.

Welcome comments!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10538)
<!-- Reviewable:end -->
2016-04-13 01:45:10 +05:30
Per Lundberg
c7758a8ad8 Removed the T prefix for the style traits
More work as described in #10185.

The reason I upgraded lazy_static to 0.1.16 is because it fixes an issue with the Box name (std::boxed::Box was used in an unqualified name, which can cause name clashes when there is another type that exists with the same name).
2016-04-12 23:02:02 +03:00
bors-servo
85f4e58285 Auto merge of #10543 - jdm:imageload, r=jdm
Implement image request concept for HTMLImageElement. Implement HTMLI…

…mageElement.currentSrc.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10543)
<!-- Reviewable:end -->
2016-04-13 01:04:28 +05:30
Corey Farwell
23eb15c820 Implement rowIndex property on <tr>.
Part of https://github.com/servo/servo/issues/10509.
2016-04-12 14:58:17 -04:00
akhan7
90359b1cba Implement image request concept for HTMLImageElement. Implement HTMLImageElement.currentSrc. 2016-04-12 14:11:31 -04:00
Zhen Zhang
7169a08a34 fix performance timing precision and navigation_start unit; add LoadEventStart and LoadEventEnd timing 2016-04-13 01:30:02 +08:00
Stjepan Glavina
524bf440e7 Fix typo: cannot not outlive -> cannot outlive 2016-04-12 19:20:44 +02:00
Arnaud Marant
315120d6e8 remove unreachable code in codegen
code is unreachable after return, and identical to the upper block
2016-04-12 19:10:10 +02:00
Yoav Alon
5e3dcae71f Implement the table section IDL attributes for HTML tables 2016-04-12 18:35:55 +03:00
bors-servo
dfb482a2b7 Auto merge of #10523 - frewsxcv:cssom-htmlimageelement-extension, r=Ms2ger
Add CSSOM 'Extensions to the HTMLImageElement Interface' in WebIDL.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10523)
<!-- Reviewable:end -->
2016-04-12 15:59:27 +05:30
bors-servo
376980fb57 Auto merge of #10379 - dzbarsky:getActiveAttrib, r=emilio
Implement GetActiveAttrib

@emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10379)
<!-- Reviewable:end -->
2016-04-12 15:18:28 +05:30
Ulf Nilsson
c8f206d0f3 Propagate RUST_BACKTRACE to content processes 2016-04-12 09:28:08 +02:00
Ulf Nilsson
d433fb01ed Share prefs to content processes
Without this `./mach run -b -- -M` would start fine but navigating to a site would fail with:

`thread 'ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }' panicked at 'assertion failed: mozbrowser_enabled()', /Users/ulf/Documents/Code/servo/components/script/dom/htmliframeelement.rs:163`
2016-04-12 09:26:30 +02:00
David Zbarsky
34644401c6 Implement GetActiveAttrib 2016-04-11 23:12:04 -07:00
bors-servo
f9608022ca Auto merge of #10535 - frewsxcv:hr-align, r=mbrubeck
Implement 'align' IDL attribute on '<hr>'.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10535)
<!-- Reviewable:end -->
2016-04-12 11:18:14 +05:30
bors-servo
150338503d Auto merge of #10529 - pcwalton:nested-fixed-position-webrender, r=glennw
layout: Make child stacking contexts of fixed position stacking contexts also fixed position.

Improves YouTube.
Improves the Washington Post.

Closes #10526.

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10529)
<!-- Reviewable:end -->
2016-04-12 10:38:11 +05:30
bors-servo
a61fc5285f Auto merge of #10534 - asajeffrey:reenable-check-no-unwrap, r=Manishearth
Re-enabled etc/ci/check_no_unwrap

Got `etc/ci/check_no_unwrap.sh` to pass, and re-enabled it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10534)
<!-- Reviewable:end -->
2016-04-12 09:57:34 +05:30
bors-servo
934ae41fc9 Auto merge of #10522 - KiChjang:input-cleanup, r=frewsxcv
Various cleanups in HTMLInputElement

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10522)
<!-- Reviewable:end -->
2016-04-12 07:56:38 +05:30
bors-servo
11927da165 Auto merge of #10527 - servo:cr, r=larsbergstrom
Work around a Mako bug on Windows

http://logs.glob.uno/?c=mozilla%23servo#c403766
https://i.imgur.com/j5Zv4LX.png
https://bitbucket.org/zzzeek/mako/issues/150/line-ending-handling-broken-on-win32

r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10527)
<!-- Reviewable:end -->
2016-04-12 07:13:22 +05:30
bors-servo
61865f66b5 Auto merge of #10505 - amarant:10491-HTMLInputElement-attr, r=KiChjang
Issue #10491 add HTMLInputElement attributes that reflect content ide…

…ntically

it uses a new version of string-cache https://github.com/servo/string-cache/pull/148

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10505)
<!-- Reviewable:end -->
2016-04-12 05:58:16 +05:30
bors-servo
f0014bd9cd Auto merge of #10224 - emilio:shader-type-validations, r=jdm
webgl: Add attribute validations and other nits

Fixes https://github.com/servo/servo/issues/9958

Depends on a bunch of prs, and needs a test.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10224)
<!-- Reviewable:end -->
2016-04-12 05:18:49 +05:30
Corey Farwell
bd74844537 Implement 'align' IDL attribute on '<hr>'. 2016-04-11 19:46:57 -04:00
bors-servo
65120756c0 Auto merge of #10493 - pcwalton:inline-font-size-zero, r=mbrubeck
gfx: Clamp the font size we supply to Core Text to 0.01pt.

Core Text treats a font size of 0.0 as 12.0, which is obviously not what
we want.

Improves Twitter.
Improves Reddit /r/rust.

Closes #10492.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10493)
<!-- Reviewable:end -->
2016-04-12 04:39:37 +05:30
Alan Jeffrey
d01c312278 Re-enabled /etc/ci/check_no_unwrap. 2016-04-11 17:28:19 -05:00
Arnaud Marant
9b8f183cba Issue #10491 add HTMLInputElement attributes that reflect content identically
it uses a new version of string-cache https://github.com/servo/string-cache/pull/148
2016-04-12 00:15:57 +02:00
bors-servo
df21bb47d4 Auto merge of #10178 - danlrobertson:flex-order, r=SimonSapin
Implement flexbox reordering

Add style property for `order` and implement reordering by this property
in flex flow. Based on previous work by @zentner-kyle.

Fixes: #9957

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10178)
<!-- Reviewable:end -->
2016-04-12 03:17:50 +05:30
bors-servo
bc2237ea2b Auto merge of #10445 - metajack:enable-asmjs, r=jdm
Use better JS engine defaults

This adds in preferences for all the SM 39 available options (as
retrieved from Gecko), and uses the same defaults as Gecko. A few
properties are not supported yet, and incremental GC is still always
disabled regardless of the preference setting.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10445)
<!-- Reviewable:end -->
2016-04-12 02:37:05 +05:30
Daniel Robertson
3580f91291 Implement flexbox reordering
Add style property for order and implement reordering by this property
in flex flow. Based on previous work by @zentner-kyle.
2016-04-11 16:55:16 -04:00
Patrick Walton
18fbf8cf30 gfx: Clamp the font size we supply to Core Text to 0.01pt.
Core Text treats a font size of 0.0 as 12.0, which is obviously not what
we want.

Improves Twitter.
Improves Reddit /r/rust.

Closes #10492.
2016-04-11 13:52:41 -07:00