Commit graph

30726 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
b13f62714a
stylo: Make TraverseSubtree cheaper in the initial styling case.
We assert against the display: none / unstyled parent already, so there's no
need to check it here as well.
2017-11-22 21:07:57 +01:00
bors-servo
9ac05a5bee Auto merge of #19255 - mstange:bug1417709, r=emilio
Bug 1417709 - Add -moz-appearance: -moz-mac-vibrant-titlebar-light/dark and system colors with the same name.

<!-- Please describe your changes on the following line: -->

These are the servo changes that need to go with [bug 1417709](https://bugzilla.mozilla.org/show_bug.cgi?id=1417709).

r? emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because without these changes Firefox doesn't build.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19255)
<!-- Reviewable:end -->
2017-11-22 13:32:38 -06:00
Markus Stange
7be33e3a45 Regenerate structs.rs. 2017-11-22 14:09:55 -05:00
Markus Stange
b3ad54f468 Servo changes for system colors -moz-mac-vibrant-titlebar-light/dark 2017-11-22 14:00:05 -05:00
Markus Stange
753304411a Servo changes for -moz-appearance values -moz-mac-vibrant-titlebar-light/dark 2017-11-22 14:00:05 -05:00
bors-servo
a812af51d6 Auto merge of #19325 - m-novikov:tidy-ignore-without-duplicates, r=jdm
Report an errror if a package has duplicates allowed but there are no duplicates

Resolves: #19306

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19306 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19325)
<!-- Reviewable:end -->
2017-11-22 11:49:40 -06:00
bors-servo
218edeb883 Auto merge of #19336 - servo:jdm-patch-6, r=emilio
Instruct how to deal with outdated manifests.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19336)
<!-- Reviewable:end -->
2017-11-22 10:36:04 -06:00
Josh Matthews
b45e4fecff
Address tidy checks. 2017-11-22 10:48:51 -05:00
bors-servo
5213e2a5a9 Auto merge of #19338 - servo:compiletest, r=nox
Replace compiletest suite by doc-tests with `compile_fail`

`compiletest-rs` use internal rustc APIs and is broken in today’s Nightly. rustdoc however is maintained with rustc and so much less fragile.

Closes #9945.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19338)
<!-- Reviewable:end -->
2017-11-22 09:35:54 -06:00
Simon Sapin
b1ce298d4b Replace compiletest suite by doc-tests with compile_fail
compiletest-rs use internal rustc APIs and is broken in today’s Nightly.
rustdoc however is maintained with rustc and so much less fragile.
2017-11-22 16:25:17 +01:00
Simon Sapin
d96f0ff6a7 Use rustdoc --document-private-item instead of deprecated flags
… and use $RUSTDOCFLAGS instead of $RUSTDOC with a wrapper script
2017-11-22 15:32:40 +01:00
Josh Matthews
b501c8fa03
Instruct how to deal with outdated manifests. 2017-11-22 08:16:54 -05:00
bors-servo
3a08f87ec8 Auto merge of #19335 - servo:jdm-patch-5, r=nox
Unbreak docs build.

Running rustdoc on gecko-media is broken right now.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19335)
<!-- Reviewable:end -->
2017-11-22 06:48:10 -06:00
Josh Matthews
da46fe4812
Unbreak docs build. 2017-11-22 07:47:04 -05:00
bors-servo
3ecd0174cc Auto merge of #19332 - wilsoniya:moving-fixme, r=emilio
moving :dir() param serialization FIXME

<!-- Please describe your changes on the following line: -->
Per emilio's comment, https://github.com/servo/servo/pull/19195#discussion_r152205644, a `FIXME` regarding `:dir()` parameter serialization has been moved.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they only modify comment lines

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19332)
<!-- Reviewable:end -->
2017-11-22 04:04:39 -06:00
Michael Wilson
1ebc1382ce moving :dir() param serialization FIXME 2017-11-21 21:47:41 -08:00
bors-servo
a6ce817045 Auto merge of #19331 - hiikezoe:resolve-base-style-for-pseudo, r=emilio
Resolve base style for pseudo

<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1418867

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
2017-11-21 22:16:58 -06:00
Hiroyuki Ikezoe
64bd97a0d3 Update bindings. 2017-11-22 13:02:45 +09:00
Keith Yeung
17ca56aa79 Implement secure and host cookie prefixes 2017-11-21 19:15:58 -08:00
bors-servo
78fb3c206d Auto merge of #19328 - Eijebong:remove_old_cancellation_code, r=KiChjang
Remove cancellation map and ResourceId from the net* components

Fixes #19327

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19328)
<!-- Reviewable:end -->
2017-11-21 21:01:35 -06:00
Hiroyuki Ikezoe
dcedf11013 Pass element or pseudo element to Servo_StyleSet_GetBaseComputedValuesForElement() 2017-11-22 11:06:05 +09:00
bors-servo
93c2a5da89 Auto merge of #19326 - servo:jdm-patch-2, r=asajeffrey
Use same build environment during mutation testing.

ccache complains that the C++ compiler doesn't match the cached version.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19326)
<!-- Reviewable:end -->
2017-11-21 19:43:49 -06:00
Manish Goregaokar
78c8b4232f
Use FetchCanceller in XHR 2017-11-21 16:45:04 -08:00
Manish Goregaokar
57bb4553c1
Add FetchCanceller RAII handle 2017-11-21 16:45:03 -08:00
bors-servo
37fa711657 Auto merge of #19314 - servo:wr, r=jdm
Update WR and the whole macOS crate stack

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19314)
<!-- Reviewable:end -->
2017-11-21 18:40:36 -06:00
Dzmitry Malyshau
ba214bcec5 WR multi-document support 2017-11-22 00:43:34 +01:00
bors-servo
a20efc6d7b Auto merge of #19324 - drewler:fix_matchbat, r=jdm
Get back to working dir after vcvarsall.bat

<!-- Please describe your changes on the following line: -->

When using cmd.exe directly (instead of `x86_x64 Cross Tools Command Prompt for VS 2017`), vcvarsall.bat changes the working directory.
To prevent this, pushd and popd could be used.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because they are part of the build process.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19324)
<!-- Reviewable:end -->
2017-11-21 17:27:34 -06:00
Bastien Orivel
d55e0fa802 Remove cancellation map and ResourceId from the net* components
Fixes #19327
2017-11-21 23:03:16 +01:00
bors-servo
06d834c1b9 Auto merge of #19321 - emilio:supports-dumb, r=SimonSapin
style: Avoid unneessary malloc churn when evaluating @supports rules.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19321)
<!-- Reviewable:end -->
2017-11-21 15:27:59 -06:00
Maxim Novikov
e6d9fd8a4f Report an errror if a package has duplicates allowed but there are no duplicates
Resolves: #19306
2017-11-21 21:08:14 +01:00
bors-servo
d1e4fdb7fa Auto merge of #19322 - CYBAI:x-lang-out-of-mako, r=emilio
style: Move -x-lang outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19320
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19322)
<!-- Reviewable:end -->
2017-11-21 13:46:49 -06:00
Josh Matthews
5a36c481f0
Use same build environment during mutation testing. 2017-11-21 13:47:54 -05:00
bors-servo
dc35457b4a Auto merge of #19318 - jdm:webdriver, r=jgraham
Make wdspec tests runnable

This makes it possible to run tests in tests/wpt/web-platform-tests/webdriver/tests and focus on investigating why they fail.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #15274.
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19318)
<!-- Reviewable:end -->
2017-11-21 12:25:55 -06:00
Andrés Barreiro
1f2b5d684f Get back to working dir after vcvarsall.bat
When using cmd.exe directly, vcvarsall.bat changes the working directory.
To prevent this, pushd and popd could be used.
2017-11-21 19:17:29 +01:00
bors-servo
755fa371cb Auto merge of #19244 - asajeffrey:test-perf-submit-to-s3, r=jdm
Submit test-perf CSV files to S3

<!-- Please describe your changes on the following line: -->

Submit CSV files to S3 rather than json files to Perfherder.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19244)
<!-- Reviewable:end -->
2017-11-21 11:07:55 -06:00
bors-servo
b13107a318 Auto merge of #19225 - servo:media, r=jdm
Shut down the media stack when shutting down the constellation

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19225)
<!-- Reviewable:end -->
2017-11-21 10:13:02 -06:00
CYBAI
d671859426 style: Move -x-lang outside of mako 2017-11-21 23:46:34 +08:00
Alan Jeffrey
1a59ea9733 Run test-perf on linux-nightly. 2017-11-21 09:45:34 -06:00
Alan Jeffrey
be5eaa4447 Submit test-perf CSV files to S3. 2017-11-21 09:27:30 -06:00
Emilio Cobos Álvarez
a6923522a0
style: Avoid unneessary malloc churn when evaluating @supports rules. 2017-11-21 16:10:33 +01:00
bors-servo
9e5fe11f5a Auto merge of #19319 - hgallagher1993:local_branch, r=jdm
Removed unused import in net/http_cache.rs

<!-- Please describe your changes on the following line: -->
`use http_loader::is_redirect_status;` was unused

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19319)
<!-- Reviewable:end -->
2017-11-21 08:51:52 -06:00
Anthony Ramine
38fd9648ce Shut down the media stack when shutting down the constellation 2017-11-21 15:31:20 +01:00
Hugh Gallagher
1b4b1c2bb2 Removed unused import in net/http_cache.rs 2017-11-21 14:09:25 +00:00
bors-servo
3864f320e8 Auto merge of #19317 - emilio:property-allowed-in, r=SimonSapin
style: Move property allowance tests to PropertyId::parse_into.

It's not only more consistent (since we have a proper ParserContext there), but
also fixes a bunch of bugs where Gecko accidentally exposes and allows setting
internal state because of conversions from nsCSSPropertyID to PropertyId.

This adds the extra complexity of caring about aliases for longer, but that's
probably not a big deal in practice, since we have PropertyDeclarationId.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19317)
<!-- Reviewable:end -->
2017-11-21 07:47:52 -06:00
Emilio Cobos Álvarez
8de554f334
style: Move property allowance tests to PropertyId::parse_into.
It's not only more consistent (since we have a proper ParserContext there), but
also fixes a bunch of bugs where Gecko accidentally exposes and allows setting
internal state because of conversions from nsCSSPropertyID to PropertyId.

This adds the extra complexity of caring about aliases for longer, but that's
probably not a big deal in practice, since we also have PropertyDeclarationId.

MozReview-Commit-ID: C2Js8PfloxQ
2017-11-21 14:26:16 +01:00
bors-servo
17e97b9320 Auto merge of #19316 - servo:stylo-size-of, r=emilio
Fix Stylo tests to pass on both Stable and Nightly Rust

This is on top of https://github.com/servo/servo/pull/19285.

Rust Nightly has new enum memory layout optimizations: https://github.com/rust-lang/rust/pull/45225

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19316)
<!-- Reviewable:end -->
2017-11-21 05:41:12 -06:00
Simon Sapin
aaba33e56b Fix Stylo tests to pass on both Stable and Nightly Rust.
This is on top of https://github.com/servo/servo/pull/19285.

Rust Nightly has new enum memory layout optimizations:
https://github.com/rust-lang/rust/pull/45225
2017-11-21 12:24:08 +01:00
bors-servo
5905f8d3ea Auto merge of #19315 - emilio:chrome-rules-user-sheets, r=heycam
style: Enable chrome-only CSS features in user stylesheets.

MozReview-Commit-ID: FJ4vTiOrotH
Bug: 1418963
Reviewed-by: heycam

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19315)
<!-- Reviewable:end -->
2017-11-21 04:27:25 -06:00
Emilio Cobos Álvarez
c7a3c929f6
style: Enable chrome-only CSS features in user stylesheets.
MozReview-Commit-ID: FJ4vTiOrotH
Reviewed-by: heycam
Bug: 1418963
2017-11-21 10:59:47 +01:00
bors-servo
006202732f Auto merge of #19195 - wilsoniya:issue-16840, r=emilio
style: :dir() pseudo class now represented by enum

`:dir()` pseudo class param now represented as enum variants.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16840
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19195)
<!-- Reviewable:end -->
2017-11-21 02:56:49 -06:00