Commit graph

29657 commits

Author SHA1 Message Date
Bobby Holley
15b866d8de Revert #18668 - Add mprotect diagnostics for HashMap crash 2017-10-03 12:44:26 -07:00
bors-servo
3dc4614991 Auto merge of #18696 - emilio:ua-sheets-reflow, r=jdm
layout_thread: Avoid adding the UA sheets multiple times when there's no root flow.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18696)
<!-- Reviewable:end -->
2017-10-03 12:46:53 -05:00
bors-servo
eff768679d Auto merge of #18414 - jdm:animdecl-codesize, r=SimonSapin
Reduce the size of AnimationValue code

According to bloaty, these commits shave off 25k from code in the animated_properties module.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18414)
<!-- Reviewable:end -->
2017-10-03 11:25:28 -05:00
bors-servo
e07c6f38a5 Auto merge of #18725 - mrobinson:tick-animation-display-list, r=jdm
TickAnimations should create a display list

This is a regression from the removal of ReflowQueryType.

Fixes #18701.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #18701  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because this should fix tests currently failing on the build infrastructure, but the failures seem to be very timing dependent.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18725)
<!-- Reviewable:end -->
2017-10-03 10:21:23 -05:00
Emilio Cobos Álvarez
a08ab7bbec
style: Update rayon.
It has a couple soundness fixes.
2017-10-03 17:18:32 +02:00
bors-servo
31cef8c258 Auto merge of #18721 - emilio:matches-stylo, r=heycam
stylo: Implement Element.matches using stylo.

From bug 1404897.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18721)
<!-- Reviewable:end -->
2017-10-03 08:05:07 -05:00
Josh Matthews
01c35f99cd Remove 5k from AnimationValue::compute_squared_distance. 2017-10-03 13:22:32 +02:00
Josh Matthews
799014755e Remove 10k from AnimationValue::animate. 2017-10-03 13:22:32 +02:00
Josh Matthews
13df088201 Remove 10k from AnimationValue::from_declaration. 2017-10-03 13:22:31 +02:00
Neha
1f1ca3ac8d Parse srcset attribute 2017-10-03 13:18:01 +02:00
bors-servo
04de056cde Auto merge of #18661 - julian-seward1:master, r=emilio
Bug 1400754 - stylo: crash on Win64 Asan build.  r=manishearth, dmajor.

* adds a hashglobe::alloc::realloc, as that was previously not implemented,
  copying and simplifying from liballoc_system.

* routes malloc and realloc calls through hashglobe::alloc::, instead of
  doing it via direct 'extern "C"' calls.

* removes the #[cfg(feature = "known_system_malloc")] markings in
  fallible/lib.rs (the fallible vec stuff) on the assumption that we no
  longer need to special-case these uses.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18661)
<!-- Reviewable:end -->
2017-10-03 06:06:14 -05:00
Martin Robinson
7920ff7b57 TickAnimations should create a display list
This is a regression from the removal of ReflowQueryType.

Fixes #18701.
2017-10-03 13:00:52 +02:00
bors-servo
77afc3f33a Auto merge of #18714 - jdm:sizes, r=jdm
Parse sizes attribute values

Squashed version of #17808.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #11416
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18714)
<!-- Reviewable:end -->
2017-10-03 04:16:00 -05:00
Emilio Cobos Álvarez
6fc967f3f9
stylo: Implement Element.matches using stylo.
Bug: 1404897
Reviewed-by: heycam
MozReview-Commit-ID: 7nxYVcweu0W
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-10-03 11:02:45 +02:00
Emilio Cobos Álvarez
c65e7d607a
stylo: Add bindings to Servo selector lists.
Bug: 1404897
Reviewed-by: heycam
MozReview-Commit-ID: 4ZrWawDwuNe
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-10-03 11:02:44 +02:00
Martin Robinson
618fd27a3d Fix the test count in the WPT grouping_formatter
The internal WPT API seems to have changed again, so we must revert the
previous change here to get the correct test count.
2017-10-03 10:03:53 +02:00
bors-servo
2a5121357a Auto merge of #18703 - emilio:nth-index-cache-invalidate, r=bholley
style: Allow passing an nth-index-cache to the invalidation code.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18703)
<!-- Reviewable:end -->
2017-10-03 00:40:03 -05:00
Hiroyuki Ikezoe
c8c02aab86 Use NormalDeclarationIterator for AnimationValueIterator 2017-10-03 07:33:30 +09:00
Glenn Watson
eaf7c72ab2 Update WR (rounded rect clip fixes). 2017-10-03 06:41:50 +10:00
Emilio Cobos Álvarez
aba1cf8cd5
style: Allow passing an nth-index-cache to the invalidation code. 2017-10-02 21:02:28 +02:00
Julian Seward
419642a2bd Bug 1400754 - stylo: crash on Win64 Asan build. r=manishearth, dmajor.
* adds a hashglobe::alloc::realloc, as that was previously not implemented,
  copying and simplifying from liballoc_system.

* routes malloc and realloc calls through hashglobe::alloc::, instead of
  doing it via direct 'extern "C"' calls.
2017-10-02 20:53:23 +02:00
Rakhi Sharma
c31b0e4bd2 Parse sizes attribute values. 2017-10-02 20:31:06 +02:00
Paul Rouget
aaab56c627 do not force resource_path on android 2017-10-02 09:24:13 +02:00
bors-servo
e13f5a656a Auto merge of #18699 - emilio:remove-cfg, r=jdm
Remove some cfg'd imports.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18699)
<!-- Reviewable:end -->
2017-10-02 02:10:25 -05:00
bors-servo
28b8f8eba5 Auto merge of #18698 - emilio:always-been-cleaning-up-ifdefs, r=mrobinson
style: Remove the last of the explicit style fixups.

No more `modify_style_for_foo` in `properties.mako.rs`!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18698)
<!-- Reviewable:end -->
2017-10-02 01:06:23 -05:00
bors-servo
e554d1c9d4 Auto merge of #18700 - aethanyc:refactor-style-shape-source, r=heycam
style: Refactor style shape source

This was reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1404243

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18700)
<!-- Reviewable:end -->
2017-10-01 22:55:44 -05:00
Ting-Yu Lin
1a437f956c style: Update generated bindings
MozReview-Commit-ID: ILCV7MiArL4
2017-10-02 11:50:42 +08:00
Ting-Yu Lin
db6acc7de4 style: Change URL value storage in StyleShapeSource.
This is due to Bug 1404243 Part 4.

MozReview-Commit-ID: CFRCdw2Dayy
2017-10-02 11:50:37 +08:00
Ting-Yu Lin
3547a59e28 style: Remove refcount for StyleBasicShape
This is due to Bug 1404243 Part 3.

MozReview-Commit-ID: DKymebmAYLX
2017-10-02 11:50:30 +08:00
Emilio Cobos Álvarez
8976b1aeab
layout_thread: Avoid adding the UA sheets multiple times when there's no root flow.
Fixes #18631
2017-10-01 23:05:58 +02:00
Emilio Cobos Álvarez
0714652d35
style: Remove another cfg'd import.
And a redundant assertion while at it.
2017-10-01 22:56:00 +02:00
Emilio Cobos Álvarez
5954e0a4ba
style: Remove conditional imports in traversal.rs 2017-10-01 22:55:50 +02:00
Emilio Cobos Álvarez
5e4b5105f9
style: Remove the last of the explicit style fixups.
This one is particularly dumb, I think.
2017-10-01 22:54:12 +02:00
Emilio Cobos Álvarez
dd27ec1fa2
layout_thread: perform_post_main_layout_passes is always called with a root flow. 2017-10-01 21:24:23 +02:00
bors-servo
4d95e2cd46 Auto merge of #18692 - emilio:cleanups, r=nox
style: multiple cleanups.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18692)
<!-- Reviewable:end -->
2017-10-01 13:30:18 -05:00
bors-servo
a2403c5cd6 Auto merge of #18693 - servo:rustup, r=nox
Upgrade to rustc 1.22.0-nightly (c6884b12d 2017-09-30)

A new `AddAssign` impl in the standard library made inference ambiguous.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18693)
<!-- Reviewable:end -->
2017-10-01 09:46:05 -05:00
Simon Sapin
b6bfdc982d Upgrade to rustc 1.22.0-nightly (c6884b12d 2017-09-30)
A new `AddAssign` impl in the standard library made inference ambiguous.
2017-10-01 14:54:59 +02:00
Emilio Cobos Álvarez
9305fadc9f
style: Remove unused ComputedValues::has_visited_style. 2017-10-01 13:27:17 +02:00
Emilio Cobos Álvarez
ab8dcf0a18
style: Rename get_visited_style to just visited_style. 2017-10-01 13:27:16 +02:00
Emilio Cobos Álvarez
d2dab24748
style: Remove boilerplate code in the properties module. 2017-10-01 13:27:16 +02:00
Emilio Cobos Álvarez
4933a54803
style: deduplicate some code in the ComputedValues code. 2017-10-01 13:27:15 +02:00
Emilio Cobos Álvarez
2adfd84636
style: Avoid being so Arc-happy in the custom properties code. 2017-10-01 13:27:15 +02:00
bors-servo
65d9b345bb Auto merge of #18684 - mrobinson:reflow-goal, r=emilio
Combine ReflowGoal and ReflowQueryType

This simplifies the logic in the layout_thread and makes it clearer
which types of reflows generate display lists and cause display updates.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they shouldn't change behavior.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18684)
<!-- Reviewable:end -->
2017-09-30 14:15:41 -05:00
bors-servo
b9e12ee666 Auto merge of #18681 - servo:c62, r=emilio
Reenable c62-percent-000.htm (fixes #7791)

This seems to pass fine now.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18681)
<!-- Reviewable:end -->
2017-09-30 13:13:43 -05:00
bors-servo
2567c40829 Auto merge of #18680 - MortimerGoro:android_flavors, r=larsbergstrom
Implement Gradle flavors for Android VR compilations

<!-- Please describe your changes on the following line: -->

This PR adds support to easily generate Android VR builds. Rust/Java VR dependencies are not added by default.

Default build (No VR support)
```
./mach build --release --android
./mach package --release --android
./mach install --release --android
```

GoogleVR builds (e.g. Daydream)
```
./mach build --release --android --features googlevr
./mach package --release --android --flavor googlevr
./mach install --release --android
```

OculusVR builds (e.g. Gear VR)
```
./mach build --release --android --features oculusvr
./mach package --release --android --flavor oculusvr
./mach install --release --android
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18680)
<!-- Reviewable:end -->
2017-09-30 12:17:37 -05:00
Martin Robinson
0380431157 Combine ReflowGoal and ReflowQueryType
This simplifies the logic in the layout_thread and makes it clearer
which types of reflows generate display lists and cause display updates.
2017-09-30 16:06:48 +02:00
bors-servo
75a4dcf293 Auto merge of #18679 - emilio:precomputed-custom-props, r=manishearth
style: Use PrecomputedHasher for custom properties.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18679)
<!-- Reviewable:end -->
2017-09-30 07:36:04 -05:00
Emilio Cobos Álvarez
b7b22b76a8
style: Use PrecomputedHasher for custom properties. 2017-09-30 14:35:38 +02:00
Imanol Fernandez
e93130026a Implement Gradle flavors 2017-09-30 14:31:22 +02:00
Emilio Cobos Álvarez
497897ffc9
style: Update precomputed-hash. 2017-09-30 14:28:35 +02:00