bors-servo
47f6eb744f
Auto merge of #8188 - servo:jdm-patch-1, r=frewsxcv
...
Remove bad advice from WPT docs.
I misunderstood the purpose of `--no-run`.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8188 )
<!-- Reviewable:end -->
2015-10-25 09:29:32 -05:00
Josh Matthews
e843135be0
Remove bad advice from WPT docs.
...
I misunderstood the purpose of `--no-run`.
2015-10-25 09:48:35 -04:00
Corey Farwell
98a6fc07e2
Implement 'htmlFor' attribute for <label> elements
2015-10-25 08:06:44 -04:00
Corey Farwell
f97d1d148b
Implement 'control' attribute for <label> elements
2015-10-25 08:06:31 -04:00
bors-servo
4b5bc4f9a9
Auto merge of #8186 - Ms2ger:rm-clone, r=nox
...
Remove an unnecessary Atom::clone() call.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8186 )
<!-- Reviewable:end -->
2015-10-25 05:09:11 -05:00
Ms2ger
c86141c55a
Remove an unnecessary Atom::clone() call.
2015-10-25 11:08:15 +01:00
Ms2ger
f59ef17921
Correct the match urls for the white-space tests.
2015-10-25 10:37:30 +01:00
bors-servo
47a8256c2c
Auto merge of #8183 - saneyuki:matches, r=nox
...
script: Element.webkitMatchesSelector()
spec:
- 9ac9c15486
- https://github.com/whatwg/compat/issues/3
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8183 )
<!-- Reviewable:end -->
2015-10-25 02:47:30 -05:00
Tetsuharu OHZEKI
04967ed97e
script: Element.webkitMatchesSelector()
...
spec:
9ac9c15486
2015-10-25 15:27:20 +09:00
Dongie Agnir
15a8b6b62c
Mark failure for remove test as expected.
...
Currently unable to get former parent after unbind_from_tree, so it's
not possible to call ask_for_reset upon removal.
2015-10-24 19:22:03 -10:00
Dongie Agnir
d561b4ffe9
Remove extra indent.
2015-10-24 19:14:31 -10:00
Dongie Agnir
b5e991c89e
Replace if-else with match.
2015-10-24 19:10:52 -10:00
bors-servo
bb88832c07
Auto merge of #8073 - eefriedman:root-lint, r=Manishearth
...
Make unrooted_must_root a bit more aggressive.
Basically, instead of trying to check for specific kinds of statements,
just check the types of all local variables.
Also included are some commented-out proposals for some slightly more
aggressive lints which might be useful (but trigger a little too
frequently at the moment).
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8073 )
<!-- Reviewable:end -->
2015-10-24 20:20:04 -05:00
bors-servo
3b50f21963
Auto merge of #8181 - frewsxcv:no-alloc-get-element-by-id, r=nox
...
Remove unnecessary allocation with getElementById
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8181 )
<!-- Reviewable:end -->
2015-10-24 17:25:09 -05:00
Corey Farwell
48ea5959c7
Remove unnecessary allocation with getElementById
2015-10-24 17:50:42 -04:00
Dongie Agnir
fcfc3918a4
Update test.
...
Fix comments and test when size > 1.
2015-10-23 14:01:58 -10:00
Dongie Agnir
ea21db6a0f
Move cast into if block.
2015-10-23 13:59:02 -10:00
Dongie Agnir
663801ed79
ask for reset and pick on option insert.
2015-10-23 13:16:52 -10:00
Dongie Agnir
c070c7ad30
Update and correct tests.
2015-10-23 13:16:42 -10:00
Dongie Agnir
6e9e1465bf
Implement pick_option.
2015-10-23 13:12:06 -10:00
bors-servo
354e75a447
Auto merge of #8171 - Ms2ger:reflector, r=jdm
...
Remove the default implementation of Reflectable::init_reflector.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8171 )
<!-- Reviewable:end -->
2015-10-23 17:49:28 -05:00
bors-servo
22a6884a67
Auto merge of #8140 - mrobinson:canvas, r=pcwalton
...
Integrate Canvas into the DisplayList
Canvas is currently given a layer at the stacking context level.
Instead it's DisplayItem should be given a layer directly. This fixes
painting order issues where canvases are painted on top of other
positioned content that is later in tree order. It always simplifies
the code a bit.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8140 )
<!-- Reviewable:end -->
2015-10-23 17:17:12 -05:00
Dongie Agnir
b1d6b0f797
Implement ask_for_reset for HTMLSelectElement.
...
Fixes #7774
2015-10-23 11:47:20 -10:00
Eli Friedman
a9ef40c716
Don't allow unrooted values in function arguments.
2015-10-23 14:44:19 -07:00
Eli Friedman
81ecf7824c
Make unrooted_must_root a bit more aggressive.
...
Basically, instead of trying to check for specific kinds of statements,
just check the types of all local variables.
Also included are some commented-out proposals for some slightly more
aggressive lints which might be useful (but trigger a little too
frequently at the moment).
2015-10-23 14:43:44 -07:00
bors-servo
ff2c7bb47b
Auto merge of #8137 - romankl:gh/8126, r=nox
...
Remove unnecessary rooting from `CSSStyleDeclaration`
This commit will replace calls to `self.owner.root()` with `self.owner` to avoid unnecessary rooting of JS elements objects.
Ref.- Issue: #8126
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8137 )
<!-- Reviewable:end -->
2015-10-23 16:38:24 -05:00
bors-servo
e3bcf7bab7
Auto merge of #8091 - nox:cleanup-range, r=eefriedman
...
Remove Rc<T> usage from Range
I initially used this to correctly handle ranges when their respective containers
are mutated, to get weak references of Range objects. I now realise that the weak
references should be handled at a lower level, closer to the JS-managed object.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8091 )
<!-- Reviewable:end -->
2015-10-23 16:00:00 -05:00
Roman Klauke
fe2401c566
Remove unnecessary rooting from CSSStyleDeclaration
...
This commit will replace calls to `self.owner.root()` with `self.owner`
to avoid unnecessary rooting of JS elements objects.
Ref.- Issue: #8126
2015-10-23 20:27:15 +02:00
Rohan Prinja
fe59b62db7
make changes according to code review ( #8097 )
2015-10-24 01:42:22 +09:00
bors-servo
ac8097b5d2
Auto merge of #8170 - Ms2ger:cleanup-canvas, r=frewsxcv
...
Cleanup some code in htmlcanvaselement.rs.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8170 )
<!-- Reviewable:end -->
2015-10-23 09:34:28 -06:00
Ms2ger
970b8aa8bc
Remove the unused default implementation of Reflectable::init_reflector.
2015-10-23 17:21:04 +02:00
Ms2ger
9be52dc41a
Implement GlobalRef::reflector as an inherent method.
...
Reflectable is meant for actual DOM objects, not for references to them.
2015-10-23 17:20:17 +02:00
Ms2ger
8361d54a6e
Cleanup some code in htmlcanvaselement.rs.
2015-10-23 16:55:12 +02:00
bors-servo
6f59acdd0a
Auto merge of #8152 - frewsxcv:reftests, r=jdm
...
Use wptrunner for some old-style reftests.
Part of #5618
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8152 )
<!-- Reviewable:end -->
2015-10-23 08:51:29 -06:00
Corey Farwell
40caa2aee0
Move box_shadow_bg.html to wpt reftests.
2015-10-23 10:27:38 -04:00
Corey Farwell
4c6a9625bf
Move border_spacing_empty_table.html to wpt reftests.
2015-10-23 10:27:37 -04:00
Corey Farwell
890e1d93e2
Move border_style_none_a.html to wpt reftests.
2015-10-23 10:27:36 -04:00
Corey Farwell
62ef402f90
Move acid1_a.html to wpt reftests.
2015-10-23 10:27:34 -04:00
Corey Farwell
ecb5a1f7c6
Move case-insensitive-font-family.html to wpt reftests.
2015-10-23 10:27:33 -04:00
Corey Farwell
6034364552
Move float_clearance_intrinsic_width_a.html to wpt reftests.
2015-10-23 10:27:31 -04:00
Corey Farwell
fc958d4d2d
Move box_shadow_border_box_a.html to wpt reftests.
2015-10-23 10:27:30 -04:00
Corey Farwell
4116aa5e18
Move box_shadow_inset_bg.html to wpt reftests.
2015-10-23 10:27:29 -04:00
Corey Farwell
8cb1aa0d67
Move empty_cells_a.html to wpt reftests.
2015-10-23 10:27:27 -04:00
Corey Farwell
02a35f5540
Move filter_opacity_a.html to wpt reftests.
2015-10-23 10:27:26 -04:00
Corey Farwell
0439894c7c
Move hide_after_create.html to wpt reftests.
2015-10-23 10:27:25 -04:00
Corey Farwell
0eb67166ed
Move br.html to wpt reftests.
2015-10-23 10:27:23 -04:00
Corey Farwell
01c5134208
Move box_shadow_paint_order_a.html to wpt reftests.
2015-10-23 10:27:22 -04:00
Corey Farwell
8ba9e6efe3
Move box_sizing_border_box_a.html to wpt reftests.
2015-10-23 10:27:21 -04:00
Corey Farwell
247a16a078
Move canvas_as_block_element_a.html to wpt reftests.
2015-10-23 10:27:20 -04:00
Corey Farwell
8eca6d1cb6
Move clear_generated_content_table_a.html to wpt reftests.
2015-10-23 10:27:18 -04:00